Completely hide empty layers on iOS to work around a rendering bug

marijnh · marijnh · commit 8f1a6d7e6685 · 2025-09-04T12:00:46.000+02:00
FIX: Work around a rendering bug in Mobile Safari by completely hiding empty layers. Closes codemirror/dev#1600
diff --git a/src/layer.ts b/src/layer.ts
@@ -5,6 +5,7 @@ import {Direction} from "./bidi"
 import {BlockType} from "./decoration"
 import {BlockInfo} from "./heightmap"
 import {blockAt} from "./cursor"
+import browser from "./browser"
 
 /// Markers shown in a [layer](#view.layer) must conform to this
 /// interface. They are created in a measuring phase, and have to
@@ -284,6 +285,8 @@ class LayerView {
         old = next
       }
       this.drawn = markers
+      if (browser.ios) // Issue #1600
+        this.dom.style.display = this.dom.firstChild ? "" : "none"
     }
   }
 

Original file line number	Diff line number	Diff line change
`@@ -5,6 +5,7 @@ import {Direction} from "./bidi"`
`5`	`5`	`import {BlockType} from "./decoration"`
`6`	`6`	`import {BlockInfo} from "./heightmap"`
`7`	`7`	`import {blockAt} from "./cursor"`
	`8`	`+import browser from "./browser"`
`8`	`9`
`9`	`10`	`/// Markers shown in a [layer](#view.layer) must conform to this`
`10`	`11`	`/// interface. They are created in a measuring phase, and have to`
`@@ -284,6 +285,8 @@ class LayerView {`
`284`	`285`	`old = next`
`285`	`286`	`}`
`286`	`287`	`this.drawn = markers`
	`288`	`+ if (browser.ios) // Issue #1600`
	`289`	`+ this.dom.style.display = this.dom.firstChild ? "" : "none"`
`287`	`290`	`}`
`288`	`291`	`}`
`289`	`292`