Don't use newly estimated height for scroll anchor height in ViewState.update

marijnh · marijnh · commit ea33ee420c4e · 2025-04-22T14:34:29.000+02:00
FIX: Fix an issue where the editor would inappropriately scroll when editing near the bottom of the document with line wrapping enabled, in some cases. Closes codemirror/dev#1552
diff --git a/src/viewstate.ts b/src/viewstate.ts
@@ -234,7 +234,7 @@ export class ViewState {
       this.scrollAnchorHeight = scrollAnchor.top
     } else {
       this.scrollAnchorPos = -1
-      this.scrollAnchorHeight = this.heightMap.height
+      this.scrollAnchorHeight = prevHeight
     }
 
     let viewport = heightChanges.length ? this.mapViewport(this.viewport, update.changes) : this.viewport

Original file line number	Diff line number	Diff line change
`@@ -234,7 +234,7 @@ export class ViewState {`
`234`	`234`	`this.scrollAnchorHeight = scrollAnchor.top`
`235`	`235`	`} else {`
`236`	`236`	`this.scrollAnchorPos = -1`
`237`		`- this.scrollAnchorHeight = this.heightMap.height`
	`237`	`+ this.scrollAnchorHeight = prevHeight`
`238`	`238`	`}`
`239`	`239`
`240`	`240`	`let viewport = heightChanges.length ? this.mapViewport(this.viewport, update.changes) : this.viewport`