Trying to fix the browser component delay logic

shai-almog · shai-almog · commit 1d5e511c5632 · 2025-11-21T22:01:56.000+02:00
diff --git a/scripts/device-runner-app/tests/BaseTest.java b/scripts/device-runner-app/tests/BaseTest.java
@@ -13,14 +13,18 @@ protected Form createForm(String title, Layout layout, final String imageName) {
         return new Form(title, layout) {
             @Override
             protected void onShowCompleted() {
-                UITimer.timer(500, false, this, () -> {
+                registerReadyCallbackthis, () -> {
                     Cn1ssDeviceRunnerHelper.emitCurrentFormScreenshot(imageName);
                     done = true;
                 });
             }
         };
     }
 
+    protected void registerReadyCallback(Form parent, Runnable run) {
+        UITimer.timer(500, false, parent, run);
+    }
+
     protected boolean waitForDone() {
         int timeout = 100;
         while(!done) {
diff --git a/scripts/device-runner-app/tests/BrowserComponentScreenshotTest.java b/scripts/device-runner-app/tests/BrowserComponentScreenshotTest.java
@@ -4,21 +4,27 @@
 import com.codename1.testing.TestUtils;
 import com.codename1.ui.BrowserComponent;
 import com.codename1.ui.Form;
+import com.codename1.ui.CN;
 import com.codename1.ui.layouts.BorderLayout;
 
 public class BrowserComponentScreenshotTest extends BaseTest {
+    private BrowserComponent browser;
     @Override
     public boolean runTest() throws Exception {
         if (!BrowserComponent.isNativeBrowserSupported()) {
             return true;
         }
         Form form = createForm("Browser Test", new BorderLayout(), "BrowserComponent");
-        BrowserComponent browser = new BrowserComponent();
+        browser = new BrowserComponent();
         browser.setPage(buildHtml(), null);
         form.add(BorderLayout.CENTER, browser);
         form.show();
         return waitForDone();
     }
+    
+    protected void registerReadyCallback(Form parent, final Runnable run) {
+        browser.addWebEventListener(BrowserComponent.onLoad, evt -> CN.callSerially(run));
+    }
 
     private static String buildHtml() {
         return "<html><head><meta charset='utf-8'/>"
