BindTarget was still used. Restored it and deprecated code

shai-almog · shai-almog · commit 26edf9ad05a3 · 2025-12-31T06:30:22.000+02:00
diff --git a/CodenameOne/src/com/codename1/cloud/BindTarget.java b/CodenameOne/src/com/codename1/cloud/BindTarget.java
@@ -0,0 +1,43 @@
+/*
+ * Copyright (c) 2012, Codename One and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.  Codename One designates this
+ * particular file as subject to the "Classpath" exception as provided
+ * by Oracle in the LICENSE file that accompanied this code.
+ *
+ * This code is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
+ * version 2 for more details (a copy is included in the LICENSE file that
+ * accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ * Please contact Codename One through http://www.codenameone.com/ if you
+ * need additional information or have any questions.
+ */
+package com.codename1.cloud;
+
+import com.codename1.ui.Component;
+
+/**
+ * Allows binding arbitrary components to data storage
+ *
+ * @author Shai Almog
+ * @deprecated this mapped to an older iteration of properties that is no longer used
+ */
+public interface BindTarget {
+    /**
+     * Fired when a property of the component changes to a new value
+     *
+     * @param source       the source component
+     * @param propertyName the name of the property
+     * @param oldValue     the old value of the property
+     * @param newValue     the new value for the property
+     */
+    void propertyChanged(Component source, String propertyName, Object oldValue, Object newValue); // PMD Fix: UnnecessaryModifier removed
+}
diff --git a/CodenameOne/src/com/codename1/ui/CheckBox.java b/CodenameOne/src/com/codename1/ui/CheckBox.java
@@ -267,6 +267,7 @@ public Class[] getBindablePropertyTypes() {
 
     /**
      * {@inheritDoc}
+     * @deprecated uses the deprecated BindTarget interface
      */
     public void bindProperty(String prop, BindTarget target) {
         if (prop.equals("selected")) {
@@ -281,6 +282,7 @@ public void bindProperty(String prop, BindTarget target) {
 
     /**
      * {@inheritDoc}
+     * @deprecated uses the deprecated BindTarget interface
      */
     public void unbindProperty(String prop, BindTarget target) {
         if (prop.equals("selected")) {
diff --git a/CodenameOne/src/com/codename1/ui/Label.java b/CodenameOne/src/com/codename1/ui/Label.java
@@ -1221,6 +1221,7 @@ public Class[] getBindablePropertyTypes() {
 
     /**
      * {@inheritDoc}
+     * @deprecated uses the deprecated BindTarget interface
      */
     public void bindProperty(String prop, BindTarget target) {
         if (prop.equals("text")) {
@@ -1235,6 +1236,7 @@ public void bindProperty(String prop, BindTarget target) {
 
     /**
      * {@inheritDoc}
+     * @deprecated uses the deprecated BindTarget interface
      */
     public void unbindProperty(String prop, BindTarget target) {
         if (prop.equals("text")) {
diff --git a/CodenameOne/src/com/codename1/ui/RadioButton.java b/CodenameOne/src/com/codename1/ui/RadioButton.java
@@ -380,6 +380,7 @@ public Class[] getBindablePropertyTypes() {
 
     /**
      * {@inheritDoc}
+     * @deprecated uses the deprecated BindTarget interface
      */
     public void bindProperty(String prop, BindTarget target) {
         if (prop.equals("selected")) {
@@ -394,6 +395,7 @@ public void bindProperty(String prop, BindTarget target) {
 
     /**
      * {@inheritDoc}
+     * @deprecated uses the deprecated BindTarget interface
      */
     public void unbindProperty(String prop, BindTarget target) {
         if (prop.equals("selected")) {
diff --git a/CodenameOne/src/com/codename1/ui/TextArea.java b/CodenameOne/src/com/codename1/ui/TextArea.java
@@ -1825,6 +1825,7 @@ public Class[] getBindablePropertyTypes() {
 
     /**
      * {@inheritDoc}
+     * @deprecated uses the deprecated BindTarget interface
      */
     public void bindProperty(String prop, BindTarget target) {
         if (prop.equals("text")) {
@@ -1839,6 +1840,7 @@ public void bindProperty(String prop, BindTarget target) {
 
     /**
      * {@inheritDoc}
+     * @deprecated uses the deprecated BindTarget interface
      */
     public void unbindProperty(String prop, BindTarget target) {
         if (prop.equals("text")) {
diff --git a/CodenameOne/src/com/codename1/ui/list/GenericListCellRenderer.java b/CodenameOne/src/com/codename1/ui/list/GenericListCellRenderer.java
@@ -23,7 +23,6 @@
  */
 package com.codename1.ui.list;
 
-import com.codename1.cloud.CloudObject;
 import com.codename1.ui.Button;
 import com.codename1.ui.CheckBox;
 import com.codename1.ui.Command;
@@ -328,34 +327,8 @@ public Component getCellRendererComponent(Component list, Object model, T value,
                     entries[iter].setFocus(lead || entries[iter].isFocusable());
                 }
             } else {
-                if (value instanceof CloudObject) {
-                    CloudObject h = (CloudObject) value;
-                    Boolean enabled = h.getBoolean(ENABLED);
-                    if (enabled != null) {
-                        cmp.setEnabled(enabled.booleanValue());
-                    }
-                    int elen = entries.length;
-                    for (int iter = 0; iter < elen; iter++) {
-                        String currentName = entries[iter].getName();
-
-                        Object val;
-                        if (currentName.equals("$number")) {
-                            val = "" + (index + 1);
-                        } else {
-                            // a selected entry might differ in its value to allow for
-                            // behavior such as rollover images
-                            val = h.getObject("#" + currentName);
-                            if (val == null) {
-                                val = h.getObject(currentName);
-                            }
-                        }
-                        setComponentValueWithTickering(entries[iter], val, list, cmp);
-                        entries[iter].setFocus(entries[iter].isFocusable());
-                    }
-                } else {
-                    setComponentValueWithTickering(entries[0], value, list, cmp);
-                    entries[0].setFocus(entries[0].isFocusable());
-                }
+                setComponentValueWithTickering(entries[0], value, list, cmp);
+                entries[0].setFocus(entries[0].isFocusable());
             }
             return cmp;
         } else {
@@ -389,25 +362,8 @@ public Component getCellRendererComponent(Component list, Object model, T value,
                     setComponentValue(entries[iter], val, list, cmp);
                 }
             } else {
-                if (value instanceof CloudObject) {
-                    CloudObject h = (CloudObject) value;
-                    Boolean enabled = h.getBoolean(ENABLED);
-                    if (enabled != null) {
-                        cmp.setEnabled(enabled.booleanValue());
-                    }
-                    int elen = entries.length;
-                    for (int iter = 0; iter < elen; iter++) {
-                        String currentName = entries[iter].getName();
-                        if (currentName.equals("$number")) {
-                            setComponentValue(entries[iter], "" + (index + 1), list, cmp);
-                            continue;
-                        }
-                        setComponentValue(entries[iter], h.getObject(currentName), list, cmp);
-                    }
-                } else {
-                    if (entries.length > 0) {
-                        setComponentValue(entries[0], value, list, cmp);
-                    }
+                if (entries.length > 0) {
+                    setComponentValue(entries[0], value, list, cmp);
                 }
             }
             return cmp;
diff --git a/CodenameOne/src/com/codename1/ui/util/EventDispatcher.java b/CodenameOne/src/com/codename1/ui/util/EventDispatcher.java
@@ -167,6 +167,7 @@ public void fireDataChangeEvent(int index, int type) {
      * @param propertyName the name of the property
      * @param oldValue     the old value of the property
      * @param newValue     the new value for the property
+     * @deprecated uses the deprecated BindTarget interface
      */
     public void fireBindTargetChange(Component source, String propertyName, Object oldValue, Object newValue) {
         if (listeners == null || listeners.size() == 0) {
@@ -201,6 +202,7 @@ public void fireBindTargetChange(Component source, String propertyName, Object o
      * @param propertyName the name of the property
      * @param oldValue     the old value of the property
      * @param newValue     the new value for the property
+     * @deprecated uses the deprecated BindTarget interface
      */
     private void fireBindTargetChangeSync(BindTarget[] arr, Component source, String propertyName, Object oldValue, Object newValue) {
         int alen = arr.length;
