Fix redundant nullcheck warnings and enforce quality gate

- Update generate-quality-report.py to fail build on RCN_REDUNDANT_NULLCHECK violations.
- Remove redundant null checks in multiple files (Objects.java, Component.java, Form.java, etc.).
- Revert unsafe null check removal in Socket.java that caused test failures.
- Add suppression for Socket.java in spotbugs-exclude.xml.
- Cleanup dead code in DefaultLookAndFeel.java and Inflate.java.

Author: google-labs-jules[bot]

CodenameOne/src/com/codename1/io/Socket.java

@@ -74,10 +74,19 @@ public static void connect(final String host, final int port, final SocketConnec
         Display.getInstance().startThread(new Runnable() {
             public void run() {
                 Object connection = Util.getImplementation().connectSocket(host, port, sc.getConnectTimeout());
-                sc.setConnected(true);
-                sc.input = new SocketInputStream(connection, sc);
-                sc.output = new SocketOutputStream(connection, sc);
-                sc.connectionEstablished(sc.input, sc.output);
+                if (connection != null) {
+                    sc.setConnected(true);
+                    sc.input = new SocketInputStream(connection, sc);
+                    sc.output = new SocketOutputStream(connection, sc);
+                    sc.connectionEstablished(sc.input, sc.output);
+                } else {
+                    sc.setConnected(false);
+                    if (connection == null) {
+                        sc.connectionError(-1, "Failed to connect");
+                    } else {
+                        sc.connectionError(Util.getImplementation().getSocketErrorCode(connection), Util.getImplementation().getSocketErrorMessage(connection));
+                    }
+                }
             }
         }, "Connection to " + host).start();
     }
@@ -150,15 +159,19 @@ public void run() {
                     while (!stopped) {
                         final Object connection = Util.getImplementation().listenSocket(port);
                         final SocketConnection sc = (SocketConnection) scClass.newInstance();
-                        sc.setConnected(true);
-                        Display.getInstance().startThread(new Runnable() {
-                            public void run() {
-                                sc.input = new SocketInputStream(connection, sc);
-                                sc.output = new SocketOutputStream(connection, sc);
-                                sc.connectionEstablished(sc.input, sc.output);
-                                sc.setConnected(false);
-                            }
-                        }, "Connection " + port).start();
+                        if (connection != null) {
+                            sc.setConnected(true);
+                            Display.getInstance().startThread(new Runnable() {
+                                public void run() {
+                                    sc.input = new SocketInputStream(connection, sc);
+                                    sc.output = new SocketOutputStream(connection, sc);
+                                    sc.connectionEstablished(sc.input, sc.output);
+                                    sc.setConnected(false);
+                                }
+                            }, "Connection " + port).start();
+                        } else {
+                            sc.connectionError(Util.getImplementation().getSocketErrorCode(connection), Util.getImplementation().getSocketErrorMessage(connection));
+                        }
                     }
                 } catch (Exception err) {
                     // instansiating the class has caused a problem

maven/core-unittests/spotbugs-exclude.xml

@@ -74,4 +74,8 @@
     <Match>
         <Bug pattern="SIC_INNER_SHOULD_BE_STATIC_ANON" />
     </Match>
+    <Match>
+        <Class name="~com\.codename1\.io\.Socket.*" />
+        <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE" />
+    </Match>
 </FindBugsFilter>