Fix SpotBugs unused/null field warnings (#4411)

Author: shai-almog

.github/scripts/generate-quality-report.py

@@ -821,6 +821,8 @@ def main() -> None:
             "UI_INHERITANCE_UNSAFE_GETRESOURCE",
             "URF_UNREAD_FIELD",
             "URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD",
+            "UUF_UNUSED_FIELD",
+            "UWF_NULL_FIELD",
             "UW_UNCOND_WAIT",
             "SIC_INNER_SHOULD_BE_STATIC_ANON",
             "SS_SHOULD_BE_STATIC",

CodenameOne/src/com/codename1/charts/compat/Paint.java

@@ -36,9 +36,6 @@
  * @deprecated
  */
 public class Paint { // PMD Fix: UnusedPrivateField removed redundant antiAlias flag
-
-
-    static Graphics g;
     private Font typeface = Font.createSystemFont(Font.FACE_SYSTEM, Font.STYLE_PLAIN, Font.SIZE_SMALL);
     private int strokeCap = Cap.BUTT;
     private int strokeJoin = Join.BEVEL;

CodenameOne/src/com/codename1/charts/views/BarChart.java

@@ -380,8 +380,4 @@ public enum Type {
         DEFAULT, STACKED, HEAPED
     }
 
-    private static class Point {
-        int seriesIndex;
-        float yval;
-    }
-}
+}

CodenameOne/src/com/codename1/components/ToastBar.java

@@ -270,8 +270,6 @@ public void actionPerformed(NetworkEvent evt) {
         };
         NetworkManager.getInstance().addErrorListener(errorListener);
         progListener[0] = new ActionListener<NetworkEvent>() {
-            private int soFar;
-
             public void actionPerformed(NetworkEvent evt) {
                 switch (evt.getProgressType()) {
                     case NetworkEvent.PROGRESS_TYPE_INITIALIZING:

CodenameOne/src/com/codename1/io/services/RSSService.java

@@ -208,7 +208,6 @@ private XMLParser getXmlParser() {
         XMLParser p = new XMLParser() {
             private String lastTag;
             private Hashtable current;
-            private String url;
 
             protected boolean startTag(String tag) {
                 if ("item".equalsIgnoreCase(tag) || "entry".equalsIgnoreCase(tag)) {

CodenameOne/src/com/codename1/social/FacebookConnect.java

@@ -49,10 +49,6 @@ public class FacebookConnect extends Login {
     private static final Object INSTANCE_LOCK = new Object();
     private final String[] permissions = new String[]{"public_profile", "email", "user_friends"};
 
-    static {
-        implClass = null;
-    }
-
     FacebookConnect() {
         setOauth2URL("https://www.facebook.com/dialog/oauth");
     }
@@ -82,6 +78,10 @@ public static FacebookConnect getInstance() {
         }
     }
 
+    static void setImplClass(Class<?> implClass) {
+        FacebookConnect.implClass = implClass;
+    }
+
     /**
      * Indicates whether the native platform supports native facebook login
      *

CodenameOne/src/com/codename1/social/GoogleConnect.java

@@ -45,14 +45,11 @@
  */
 public class GoogleConnect extends Login {
 
-    static Class implClass;
+    static Class<?> implClass;
     private static final String tokenURL = "https://www.googleapis.com/oauth2/v3/token";
     private static GoogleConnect instance;
     private static final Object INSTANCE_LOCK = new Object();
 
-    static {
-        implClass = null;
-    }
 
     GoogleConnect() {
         setOauth2URL("https://accounts.google.com/o/oauth2/auth");
@@ -82,6 +79,10 @@ public static GoogleConnect getInstance() {
         }
     }
 
+    static void setImplClass(Class<?> implClass) {
+        GoogleConnect.implClass = implClass;
+    }
+
     @Override
     public boolean isNativeLoginSupported() {
         return false;

CodenameOne/src/com/codename1/ui/BrowserComponent.java

@@ -138,7 +138,6 @@ public class BrowserComponent extends Container {
     private Vector<BrowserNavigationCallback> browserNavigationCallbacks;
     private Hashtable<Integer, SuccessCallback<JSRef>> returnValueCallbacks;
     private int nextReturnValueCallbackId = 0;
-    private JSONParser returnValueParser;
     private final Container placeholder = new Container();
     private final LinkedList<Runnable> onReady = new LinkedList<Runnable>();
     private String tmpUrl;

CodenameOne/src/com/codename1/ui/Command.java

@@ -40,7 +40,6 @@ public class Command implements ActionListener<ActionEvent> {
     private boolean disposesDialog = true;
     private Image icon;
     private char materialIcon;
-    private char fontIcon;
     private Font iconFont;
     private Image pressedIcon;
     private Image rolloverIcon;

CodenameOne/src/com/codename1/ui/Container.java

@@ -4254,7 +4254,6 @@ static class MorphAnimation extends ComponentAnimation {
         boolean dontRevalidate;
         private final long startTime;
         private int duration;
-        private Transition t;
         private final Container thisContainer;
         private boolean finished = false;
         private final Motion[][] motions;