WTF

Author: shai-almog

CodenameOne/src/com/codename1/components/Accordion.java

@@ -81,7 +81,7 @@ public Accordion() {
                 FontImage.createMaterial(FontImage.MATERIAL_KEYBOARD_ARROW_RIGHT, UIManager.getInstance().getComponentStyle(uiidOpenCloseIcon));
         this.openIcon = FontImage.createMaterial(FontImage.MATERIAL_KEYBOARD_ARROW_DOWN, UIManager.getInstance().getComponentStyle(uiidOpenCloseIcon));
 
-        setScrollableY(true);
+        super.setScrollableY(true);
     }
 
     /**

CodenameOne/src/com/codename1/ui/Component.java

@@ -7252,7 +7252,7 @@ protected void deinitializeCustomStyle(Style s) {
      *
      * @return true if the component is working in a right to left mode
      */
-    public boolean isRTL() {
+    public final boolean isRTL() {
         return rtl;
     }
 

CodenameOne/src/com/codename1/ui/Form.java

@@ -4406,6 +4406,7 @@ public boolean isScrollableY() {
     /**
      * {@inheritDoc}
      */
+    @Override
     public void setScrollableY(boolean scrollableY) {
         getContentPane().setScrollableY(scrollableY);
     }

maven/core-unittests/spotbugs-exclude.xml

@@ -25,6 +25,14 @@
         <Bug pattern="BC_UNCONFIRMED_CAST_OF_RETURN_VALUE"/>
     </Match>
 
+    <!--
+    This inspection seems buggy. It highlighted the wrong line in
+    a file that didn't have any visible related problem.
+    -->
+    <Match>
+        <Bug pattern="NM_CONFUSING"/>
+    </Match>
+
     <!--
     This fails on writing to a static field from a non-static method.
     This is a bad practice in general because it could indicate a state
@@ -118,13 +126,13 @@
 
     <!-- Excluded classes... -->
 
-    <!-- Deprecated classes that should be excluded from checks -->
+    <!-- Badly written 3rd party class -->
     <Match>
-        <Class name="~com\.codename1\.db\.ThreadSafeDatabase(\$.*)?" />
+        <Class name="com.codename1.io.tar.TarEntry" />
     </Match>
 
-    <!-- Badly written 3rd party classes -->
+    <!-- Deprecated classes that should be excluded from checks -->
     <Match>
-        <Class name="com.codename1.io.tar.TarEntry" />
+        <Class name="~com\.codename1\.db\.ThreadSafeDatabase(\$.*)?" />
     </Match>
 </FindBugsFilter>