Improve coverage of core unit tests for Picker, Validator, Login, and JSObject (#4248)

Added tests for:
- Picker$3$1 (Picker3Test)
- Validator$3$1 (Validator3Test)
- Login$1 (Login1Test)
- JSObject$1, $6, $7 (JSObjectCoverageTest)
- JavascriptContext$3, $4, $6 (JSObjectCoverageTest)

Note: Picker$1$8 is unreachable dead code and cannot be tested.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>

Author: google-labs-jules[bot]

maven/core-unittests/src/test/java/com/codename1/javascript/JSObjectCoverageTest.java

@@ -0,0 +1,67 @@
+package com.codename1.javascript;
+
+import com.codename1.junit.FormTest;
+import com.codename1.junit.UITestBase;
+import com.codename1.ui.BrowserComponent;
+import com.codename1.ui.TestPeerComponent;
+import com.codename1.util.SuccessCallback;
+import com.codename1.testing.TestCodenameOneImplementation;
+import java.util.function.Function;
+
+public class JSObjectCoverageTest extends UITestBase {
+
+    @FormTest
+    public void testJSObjectAndContextAnonymousClasses() {
+        TestPeerComponent peer = new TestPeerComponent(null);
+        TestCodenameOneImplementation.getInstance().setBrowserComponent(peer);
+
+        BrowserComponent browser = new BrowserComponent();
+        JavascriptContext ctx = new JavascriptContext(browser);
+
+        TestCodenameOneImplementation.getInstance().setBrowserScriptResponder(new Function<String, String>() {
+            @Override
+            public String apply(String script) {
+                // ID generation script ends with "} id" or checks ID_KEY
+                if (script.endsWith("} id")) {
+                     return "0";
+                }
+                if (script.contains("typeof")) {
+                    return "object";
+                }
+                return null;
+            }
+        });
+
+        JSObject jsObj = new JSObject(ctx, "window");
+
+        // JSObject$1: callAsync(String, Object[], SuccessCallback)
+        jsObj.callAsync("method", new Object[]{}, new SuccessCallback() {
+            public void onSucess(Object value) {}
+        });
+
+        // JSObject$6: callStringAsync
+        jsObj.callStringAsync("method", new SuccessCallback<String>() {
+             public void onSucess(String value) {}
+        });
+
+        // JSObject$7: callObjectAsync
+        jsObj.callObjectAsync("method", new SuccessCallback<JSObject>() {
+             public void onSucess(JSObject value) {}
+        });
+
+        // JavascriptContext$3: getAsync(String, SuccessCallback)
+        ctx.getAsync("1+1", new SuccessCallback() {
+            public void onSucess(Object value) {}
+        });
+
+        // JavascriptContext$4: callAsync(JSObject, JSObject, Object[], SuccessCallback)
+        ctx.callAsync(jsObj, jsObj, new Object[]{}, new SuccessCallback() {
+            public void onSucess(Object value) {}
+        });
+
+        // JavascriptContext$6: call(String, JSObject, Object[], boolean, SuccessCallback)
+        ctx.callAsync("func", jsObj, new Object[]{}, new SuccessCallback() {
+            public void onSucess(Object value) {}
+        });
+    }
+}

maven/core-unittests/src/test/java/com/codename1/social/Login1Test.java

@@ -0,0 +1,51 @@
+package com.codename1.social;
+
+import com.codename1.io.AccessToken;
+import com.codename1.io.Oauth2;
+import com.codename1.junit.FormTest;
+import com.codename1.junit.UITestBase;
+import com.codename1.ui.events.ActionEvent;
+import com.codename1.ui.events.ActionListener;
+
+public class Login1Test extends UITestBase {
+
+    @FormTest
+    public void testLoginActionListener() {
+        Login login = new Login() {
+            @Override
+            public boolean isNativeLoginSupported() {
+                return false;
+            }
+
+            @Override
+            protected boolean validateToken(String token) {
+                return false;
+            }
+
+            @Override
+            protected Oauth2 createOauth2() {
+                return new Oauth2("url", "client", "redirect", "scope") {
+                     @Override
+                     public void showAuthentication(ActionListener al) {
+                         // Test success with AccessToken
+                         AccessToken token = new AccessToken("token", null);
+                         al.actionPerformed(new ActionEvent(token));
+
+                         // Test success with String
+                         al.actionPerformed(new ActionEvent("tokenString"));
+
+                         // Test failure with Exception
+                         al.actionPerformed(new ActionEvent(new Exception("Fail")));
+                     }
+                };
+            }
+        };
+
+        login.setClientId("id");
+        login.setClientSecret("secret");
+        login.setOauth2URL("url");
+        login.setRedirectURI("uri");
+
+        login.doLogin();
+    }
+}

maven/core-unittests/src/test/java/com/codename1/ui/spinner/Picker3Test.java

@@ -0,0 +1,41 @@
+package com.codename1.ui.spinner;
+
+import com.codename1.junit.FormTest;
+import com.codename1.junit.UITestBase;
+import com.codename1.ui.Display;
+import com.codename1.ui.DisplayTest;
+import com.codename1.ui.Form;
+import com.codename1.ui.layouts.BoxLayout;
+import com.codename1.ui.spinner.Picker;
+
+public class Picker3Test extends UITestBase {
+
+    @FormTest
+    public void testPickerInputDeviceClose() {
+        Form f = new Form("Picker Test", new BoxLayout(BoxLayout.Y_AXIS));
+        Picker p = new Picker();
+        p.setType(Display.PICKER_TYPE_STRINGS);
+        p.setStrings("A", "B", "C");
+        p.setUseLightweightPopup(true);
+
+        f.add(p);
+        f.show();
+
+        // Trigger editing
+        p.pressed();
+        p.released();
+
+        DisplayTest.flushEdt();
+
+        if (p.isEditing()) {
+            final boolean[] called = new boolean[1];
+            p.stopEditing(new Runnable() {
+                public void run() {
+                    called[0] = true;
+                }
+            });
+            f.getAnimationManager().flushAnimation(new Runnable() { public void run() {} });
+            DisplayTest.flushEdt();
+        }
+    }
+}

maven/core-unittests/src/test/java/com/codename1/ui/validation/Validator3Test.java

@@ -0,0 +1,63 @@
+package com.codename1.ui.validation;
+
+import com.codename1.junit.FormTest;
+import com.codename1.junit.UITestBase;
+import com.codename1.ui.Component;
+import com.codename1.ui.Container;
+import com.codename1.ui.Form;
+import com.codename1.ui.FontImage;
+import com.codename1.ui.layouts.BoxLayout;
+import com.codename1.ui.validation.Constraint;
+import com.codename1.ui.validation.Validator;
+
+public class Validator3Test extends UITestBase {
+
+    public static class TestContainer extends Container {
+        @Override
+        public void setScrollX(int scrollX) {
+            super.setScrollX(scrollX);
+        }
+        @Override
+        public boolean isScrollable() {
+            return true;
+        }
+        @Override
+        public Component getScrollable() {
+            return this;
+        }
+    }
+
+    @FormTest
+    public void testValidatorScrollListener() {
+        Form f = new Form("Validator Test");
+        f.setLayout(new BoxLayout(BoxLayout.Y_AXIS));
+
+        TestContainer scrollableCmp = new TestContainer();
+        scrollableCmp.setFocusable(true);
+        f.add(scrollableCmp);
+
+        Validator v = new Validator();
+        v.setShowErrorMessageForFocusedComponent(true);
+
+        v.addConstraint(scrollableCmp, new Constraint() {
+            @Override
+            public boolean isValid(Object value) {
+                return false;
+            }
+
+            @Override
+            public String getDefaultFailMessage() {
+                return "Failed";
+            }
+        });
+
+        v.setValidationFailureHighlightMode(Validator.HighlightMode.EMBLEM);
+        v.setValidationFailedEmblem(FontImage.createMaterial(FontImage.MATERIAL_ERROR, "Error", 4));
+
+        f.show();
+        scrollableCmp.requestFocus();
+
+        // Trigger scroll
+        scrollableCmp.setScrollX(50);
+    }
+}