Fixed CI build to use JDK 8 and compilation nuances

Author: shai-almog

scripts/setup-workspace.sh

@@ -1,6 +1,6 @@
 #!/usr/bin/env bash
 ###
-# Prepare Codename One workspace by installing Maven, provisioning JDK 11 and JDK 17,
+# Prepare Codename One workspace by installing Maven, provisioning JDK 8 and JDK 17,
 # building core modules, and installing Maven archetypes.
 ###
 set -euo pipefail
@@ -36,11 +36,12 @@ case "$arch_name" in
 esac
 
 # Determine platform-specific JDK download URLs
-arch_jdk11="$arch"
+arch_jdk8="$arch"
 if [ "$os" = "mac" ] && [ "$arch" = "aarch64" ]; then
-  arch_jdk11="x64"
+  arch_jdk8="x64"
 fi
-JDK11_URL="https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.28%2B6/OpenJDK11U-jdk_${arch_jdk11}_${os}_hotspot_11.0.28_6.tar.gz"
+
+JDK8_URL="https://github.com/adoptium/temurin8-binaries/releases/download/jdk8u462-b08/OpenJDK8U-jdk_${arch_jdk8}_${os}_hotspot_8u462b08.tar.gz"
 JDK17_URL="https://github.com/adoptium/temurin17-binaries/releases/download/jdk-17.0.16%2B8/OpenJDK17U-jdk_${arch}_${os}_hotspot_17.0.16_8.tar.gz"
 MAVEN_URL="https://archive.apache.org/dist/maven/maven-3/3.9.6/binaries/apache-maven-3.9.6-bin.tar.gz"
 
@@ -60,12 +61,12 @@ install_jdk() {
   eval "$dest_var=\"$home\""
 }
 
-log "Ensuring JDK 11 is available"
-if [ ! -x "${JAVA_HOME:-}/bin/java" ] || ! "${JAVA_HOME:-}/bin/java" -version 2>&1 | grep -q '11\.0'; then
-  log "Provisioning JDK 11 (this may take a while)..."
-  install_jdk "$JDK11_URL" JAVA_HOME
+log "Ensuring JDK 8 is available"
+if [ ! -x "${JAVA_HOME:-}/bin/java" ] || ! "${JAVA_HOME:-}/bin/java" -version 2>&1 | grep -q '8\.0'; then
+  log "Provisioning JDK 8 (this may take a while)..."
+  install_jdk "$JDK8_URL" JAVA_HOME
 else
-  log "Using existing JDK 11 at $JAVA_HOME"
+  log "Using existing JDK 8 at $JAVA_HOME"
 fi
 
 log "Ensuring JDK 17 is available"
@@ -98,7 +99,7 @@ ENV
 
 source "$ENV_DIR/env.sh"
 
-log "JDK 11 version:"; "$JAVA_HOME/bin/java" -version
+log "JDK 8 version:"; "$JAVA_HOME/bin/java" -version
 log "JDK 17 version:"; "$JAVA_HOME_17/bin/java" -version
 log "Maven version:"; "$MAVEN_HOME/bin/mvn" -version
 

vm/JavaAPI/src/java/io/ByteArrayOutputStream.java

@@ -192,7 +192,7 @@ public String toString(String charsetName) throws UnsupportedEncodingException {
      */
     @Override
     public synchronized void write(byte[] buffer, int offset, int len) {
-        Arrays.checkOffsetAndCount(buffer.length, offset, len);
+        checkOffsetAndCount(buffer.length, offset, len);
         if (len == 0) {
             return;
         }
@@ -201,6 +201,12 @@ public synchronized void write(byte[] buffer, int offset, int len) {
         this.count += len;
     }
 
+    static void checkOffsetAndCount(int arrayLength, int offset, int count) {
+        if ((offset | count) < 0 || offset > arrayLength || arrayLength - offset < count) {
+            throw new ArrayIndexOutOfBoundsException(offset);
+        }
+    }
+
     /**
      * Writes the specified byte {@code oneByte} to the OutputStream. Only the
      * low order byte of {@code oneByte} is written.

vm/JavaAPI/src/java/text/SimpleDateFormat.java

@@ -315,7 +315,7 @@ String format(Date source, StringBuffer toAppendTo) {
 					if (names == null) {
 						toAppendTo.append(calendar.getTimeZone().getID());
 					} else {
-						toAppendTo.append(names[DateFormatSymbols.ZONE_SHORTNAME]);
+						toAppendTo.append(names[2 /*DateFormatSymbols.ZONE_SHORTNAME */]);
 					}
 					break;
 				case TIMEZONE822_LETTER :
@@ -398,7 +398,7 @@ String format(Date source, StringBuffer toAppendTo) {
 
 	private String[] getTimeZoneDisplayNames(String id) {
 		for (String zoneStrings[] : getDateFormatSymbols().getZoneStrings()) {
-			if (zoneStrings[DateFormatSymbols.ZONE_ID].equalsIgnoreCase(id)) {
+			if (zoneStrings[0 /*DateFormatSymbols.ZONE_ID*/].equalsIgnoreCase(id)) {
 				return zoneStrings;
 			}
 		}
@@ -926,7 +926,7 @@ int parseTimeZone(String source, int ofs) throws ParseException {
 		for (String timezone[] : getDateFormatSymbols().getZoneStrings()) {
 			for (String z : timezone) {
 				if (z.equalsIgnoreCase(source)) {
-					TimeZone tz = TimeZone.getTimeZone(timezone[DateFormatSymbols.ZONE_ID]);
+					TimeZone tz = TimeZone.getTimeZone(timezone[0 /*DateFormatSymbols.ZONE_ID*/]);
 					return -(tz.getRawOffset() / MILLIS_TO_MINUTES);
 				}
 			}