Fix ES_COMPARING_PARAMETER_STRING_WITH_EQ SpotBugs warnings (#4361)

google-labs-jules[bot] · web-flow · commit 53ca24cc187d · 2025-12-25T21:32:59.000+02:00
Replaced string comparison using '==' with '.equals()' or 'Objects.equals()' in Font.java, SideMenuBar.java, and TestUtils.java.
Updated generate-quality-report.py to enforce this rule.

Co-authored-by: google-labs-jules[bot] &lt;161369871+google-labs-jules[bot]@users.noreply.github.com&gt;
diff --git a/.github/scripts/generate-quality-report.py b/.github/scripts/generate-quality-report.py
@@ -765,7 +765,8 @@ def main() -> None:
             "DM_DEFAULT_ENCODING",
             "EQ_CHECK_FOR_OPERAND_NOT_COMPATIBLE_WITH_THIS",
             "IA_AMBIGUOUS_INVOCATION_OF_INHERITED_OR_OUTER_METHOD",
-            "RpC_REPEATED_CONDITIONAL_TEST"
+            "RpC_REPEATED_CONDITIONAL_TEST",
+            "ES_COMPARING_PARAMETER_STRING_WITH_EQ"
         }
         violations = [
             f for f in spotbugs.findings
diff --git a/CodenameOne/src/com/codename1/testing/TestUtils.java b/CodenameOne/src/com/codename1/testing/TestUtils.java
@@ -1990,7 +1990,7 @@ public static void assertLabel(String name, String text) {
         }
         Label l = (Label) findByName(name);
         assertBool(l != null, "Null label" + text);
-        assertBool(text == l.getText() || text.equals(l.getText()), name + " != " + text);
+        assertBool(Objects.equals(text, l.getText()), name + " != " + text);
     }
 
     /**
@@ -2005,7 +2005,7 @@ public static void assertLabel(int[] path, String text) {
         }
         Label l = (Label) getComponentByPath(path);
         assertBool(l != null, "Null label" + text);
-        assertBool(text == l.getText() || text.equals(l.getText()), (l.getText()) + " != " + text);
+        assertBool(Objects.equals(text, l.getText()), (l.getText()) + " != " + text);
     }
 
     /**
diff --git a/CodenameOne/src/com/codename1/ui/Font.java b/CodenameOne/src/com/codename1/ui/Font.java
@@ -481,7 +481,7 @@ public int stringWidth(String str) {
         }
         // Its common to use a space character to create a label that takes up space but the value
         // of string width in this case becomes less important
-        if (str == " ") {
+        if (" ".equals(str)) {
             return 5;
         }
         return Display.impl.stringWidth(font, str);
diff --git a/CodenameOne/src/com/codename1/ui/SideMenuBar.java b/CodenameOne/src/com/codename1/ui/SideMenuBar.java
@@ -36,7 +36,8 @@
 import com.codename1.ui.layouts.Layout;
 import com.codename1.ui.plaf.Style;
 import com.codename1.ui.plaf.UIManager;
-import com.codename1.ui.util.Resources;
+import com.codename1.ui.util.Resources;
+import com.codename1.compat.java.util.Objects;
 
 import java.util.Vector;
 
@@ -346,7 +347,7 @@ public void actionPerformed(ActionEvent evt) {
                         if (p == null) {
                             //has left menu
                             hasSideMenus[0] = true;
-                        } else if (p.equals(COMMAND_PLACEMENT_VALUE_RIGHT)) {
+                        } else if (COMMAND_PLACEMENT_VALUE_RIGHT.equals(p)) {
                             //has right menu
                             hasSideMenus[1] = true;
                         }
@@ -830,7 +831,7 @@ private void addOpenButton(Command cmd, boolean checkCommands) {
     }
 
     private void validateCommandPlacement(String placement) {
-        if (placement == COMMAND_PLACEMENT_VALUE_TOP) {
+        if (COMMAND_PLACEMENT_VALUE_TOP.equals(placement)) {
             ((BorderLayout) getTitleAreaContainer().getLayout()).setCenterBehavior(BorderLayout.CENTER_BEHAVIOR_SCALE);
             if (!(getTitleComponent() instanceof Button)) {
                 Button b = new Button(parent.getTitle());
@@ -844,7 +845,7 @@ public void actionPerformed(ActionEvent evt) {
             }
             return;
         }
-        if (placement == COMMAND_PLACEMENT_VALUE_RIGHT) {
+        if (COMMAND_PLACEMENT_VALUE_RIGHT.equals(placement)) {
             if (rightSideButton != null && rightSideButton.getParent() != null) {
                 return;
             }
@@ -886,7 +887,7 @@ private void clean() {
 
     private void setMenuGlassPane(Form m, final String placement) {
         boolean isRTLValue = m.isRTL();
-        if (placement == COMMAND_PLACEMENT_VALUE_RIGHT) {
+        if (COMMAND_PLACEMENT_VALUE_RIGHT.equals(placement)) {
             isRTLValue = !isRTLValue;
         }
         final boolean isRTL = isRTLValue;
@@ -1027,7 +1028,7 @@ Container createSideNavigationPanel(Vector commands, String placement) {
 
         for (int iter = commands.size() - 1; iter > -1; iter--) {
             Command c = (Command) commands.elementAt(iter);
-            if (c.getClientProperty(COMMAND_PLACEMENT_KEY) != placement) {
+            if (!Objects.equals(c.getClientProperty(COMMAND_PLACEMENT_KEY), placement)) {
                 continue;
             }
             Component cmp = (Component) c.getClientProperty(COMMAND_SIDE_COMPONENT);
@@ -1056,7 +1057,7 @@ Container createSideNavigationPanel(Vector commands, String placement) {
             }
         }
         boolean isRTLValue = isRTL();
-        if (placement == COMMAND_PLACEMENT_VALUE_RIGHT) {
+        if (COMMAND_PLACEMENT_VALUE_RIGHT.equals(placement)) {
             isRTLValue = !isRTLValue;
         }
         UIManager uim = menu.getUIManager();
@@ -1081,12 +1082,12 @@ Container createSideNavigationPanel(Vector commands, String placement) {
             shadowLabel.getStyle().setMargin(0, 0, 0, 0);
             shadowLabel.getStyle().setBgTransparency(0);
             Container c = new Container(new BorderLayout());
-            if (placement == COMMAND_PLACEMENT_VALUE_RIGHT) {
+            if (COMMAND_PLACEMENT_VALUE_RIGHT.equals(placement)) {
                 shadowLabel.setPreferredW(shadow.getWidth());
                 c.addComponent(BorderLayout.WEST, shadowLabel);
                 shadowLabel.getStyle().setBgImage(shadow.rotate180Degrees(true));
             } else {
-                if (placement == COMMAND_PLACEMENT_VALUE_TOP) {
+                if (COMMAND_PLACEMENT_VALUE_TOP.equals(placement)) {
                     //shadowLabel.setPreferredH(shadow.getHeight());
                     //c.addComponent(BorderLayout.SOUTH, shadowLabel);
                     //shadowLabel.getStyle().setBgImage(shadow.rotate90Degrees(true));
@@ -1377,7 +1378,7 @@ public void paint(Graphics g) {
             };
         }
 
-        if (placement == COMMAND_PLACEMENT_VALUE_TOP) {
+        if (COMMAND_PLACEMENT_VALUE_TOP.equals(placement)) {
             int v = 0;
             if (Display.getInstance().isPortrait()) {
                 if (Display.getInstance().isTablet()) {
@@ -1427,7 +1428,7 @@ public void paint(Graphics g) {
                 } else {
                     v = getUIManager().getThemeConstant("sideMenuSizePortraitInt", -1);
                     if (v < 0) {
-                        if (placement == COMMAND_PLACEMENT_VALUE_RIGHT) {
+                        if (COMMAND_PLACEMENT_VALUE_RIGHT.equals(placement)) {
                             if (isRTL()) {
                                 v = openButton.getWidth();
                             } else {
@@ -1466,11 +1467,11 @@ public void paint(Graphics g) {
             sidePanel = null;
         }
         sidePanel = createSideNavigationComponent(getCommands(), placement);
-        if (placement == COMMAND_PLACEMENT_VALUE_RIGHT) {
+        if (COMMAND_PLACEMENT_VALUE_RIGHT.equals(placement)) {
             m.addComponent(BorderLayout.WEST, rightPanel);
             m.addComponent(BorderLayout.CENTER, sidePanel);
         } else {
-            if (placement == COMMAND_PLACEMENT_VALUE_TOP) {
+            if (COMMAND_PLACEMENT_VALUE_TOP.equals(placement)) {
                 m.addComponent(BorderLayout.NORTH, rightPanel);
                 m.addComponent(BorderLayout.CENTER, sidePanel);
                 Button button = new Button(" ");
@@ -1547,7 +1548,7 @@ public MenuTransition(int speed, boolean fwd, int dest, String placement) {
 
         public void initTransition() {
             super.initTransition();
-            if (placement == COMMAND_PLACEMENT_VALUE_TOP) {
+            if (COMMAND_PLACEMENT_VALUE_TOP.equals(placement)) {
                 if (Display.getInstance().areMutableImagesFast()) {
                     if (fwd) {
                         buffer = updateRightPanelBgImage(placement, getSource());
@@ -1576,7 +1577,7 @@ public void initTransition() {
                 }
             } else {
                 isRTL = (getSource().getUIManager().getLookAndFeel().isRTL());
-                if (placement == COMMAND_PLACEMENT_VALUE_RIGHT) {
+                if (COMMAND_PLACEMENT_VALUE_RIGHT.equals(placement)) {
                     isRTL = !isRTL;
                 }
                 if (Display.getInstance().areMutableImagesFast()) {
@@ -1618,7 +1619,7 @@ public void initTransition() {
                 shadow = Resources.getSystemResource().getImage("sidemenu-shadow.png");
             }
             boolean isRTLValue = isRTL();
-            if (placement == COMMAND_PLACEMENT_VALUE_RIGHT) {
+            if (COMMAND_PLACEMENT_VALUE_RIGHT.equals(placement)) {
                 isRTLValue = !isRTLValue;
             }
             if (isRTLValue) {
@@ -1658,7 +1659,7 @@ public void paint(Graphics g) {
             }
             Component src = getSource();
             Component dest = getDestination();
-            if (placement == COMMAND_PLACEMENT_VALUE_TOP) {
+            if (COMMAND_PLACEMENT_VALUE_TOP.equals(placement)) {
                 if (Display.getInstance().areMutableImagesFast()) {
                     if (fwd) {
                         dest.paintComponent(g, true);

Original file line number	Diff line number	Diff line change
`@@ -1990,7 +1990,7 @@ public static void assertLabel(String name, String text) {`
`1990`	`1990`	`}`
`1991`	`1991`	`Label l = (Label) findByName(name);`
`1992`	`1992`	`assertBool(l != null, "Null label" + text);`
`1993`		`- assertBool(text == l.getText() \|\| text.equals(l.getText()), name + " != " + text);`
	`1993`	`+ assertBool(Objects.equals(text, l.getText()), name + " != " + text);`
`1994`	`1994`	`}`
`1995`	`1995`
`1996`	`1996`	`/**`
`@@ -2005,7 +2005,7 @@ public static void assertLabel(int[] path, String text) {`
`2005`	`2005`	`}`
`2006`	`2006`	`Label l = (Label) getComponentByPath(path);`
`2007`	`2007`	`assertBool(l != null, "Null label" + text);`
`2008`		`- assertBool(text == l.getText() \|\| text.equals(l.getText()), (l.getText()) + " != " + text);`
	`2008`	`+ assertBool(Objects.equals(text, l.getText()), (l.getText()) + " != " + text);`
`2009`	`2009`	`}`
`2010`	`2010`
`2011`	`2011`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -481,7 +481,7 @@ public int stringWidth(String str) {`
`481`	`481`	`}`
`482`	`482`	`// Its common to use a space character to create a label that takes up space but the value`
`483`	`483`	`// of string width in this case becomes less important`
`484`		`- if (str == " ") {`
	`484`	`+ if (" ".equals(str)) {`
`485`	`485`	`return 5;`
`486`	`486`	`}`
`487`	`487`	`return Display.impl.stringWidth(font, str);`