fix: Android safe areas should work when there are no cutouts (#3926)

This fixes #3925, where it was demonstrated that the Sheet was being cut off by the bottom navigation bar.
I found that the current code for updating the safe area would always return zero insets if the device didn't have a cutout.
Fixed it so that system bars would still be incorporated into the safe area even with there were no cutouts.

Author: shannah

Ports/Android/src/com/codename1/impl/android/CodenameOneView.java

@@ -164,7 +164,6 @@ public void visibilityChangedTo(boolean visible) {
 
     private void updateSafeArea() {
         final Activity activity = CodenameOneView.this.implementation.getActivity();
-
         final Rect rect = this.safeArea;
         final View rootView = activity.getWindow().getDecorView();
         if (Build.VERSION.SDK_INT >= VERSION_CODE_P) {
@@ -176,69 +175,73 @@ private void updateSafeArea() {
                     Method getDisplayCutoutMethod = windowInsetsClass.getMethod("getDisplayCutout");
                     Object cutout = getDisplayCutoutMethod.invoke(insets);
 
+                    int left = 0;
+                    int top = 0;
+                    int right = 0;
+                    int bottom = 0;
                     if (cutout != null) {
                         Class<?> displayCutoutClass = Class.forName("android.view.DisplayCutout");
                         Method getSafeInsetLeft = displayCutoutClass.getMethod("getSafeInsetLeft");
                         Method getSafeInsetTop = displayCutoutClass.getMethod("getSafeInsetTop");
                         Method getSafeInsetRight = displayCutoutClass.getMethod("getSafeInsetRight");
                         Method getSafeInsetBottom = displayCutoutClass.getMethod("getSafeInsetBottom");
+                        left = ((Integer) getSafeInsetLeft.invoke(cutout)).intValue();
+                        top = ((Integer) getSafeInsetTop.invoke(cutout)).intValue();
+                        right = ((Integer) getSafeInsetRight.invoke(cutout)).intValue();
+                        bottom = ((Integer) getSafeInsetBottom.invoke(cutout)).intValue();
+                    }
 
-                        int left = ((Integer) getSafeInsetLeft.invoke(cutout)).intValue();
-                        int top = ((Integer) getSafeInsetTop.invoke(cutout)).intValue();
-                        int right = ((Integer) getSafeInsetRight.invoke(cutout)).intValue();
-                        int bottom = ((Integer) getSafeInsetBottom.invoke(cutout)).intValue();
-                        boolean imeVisible = false;
-                        try {
-                            Method isVisibleMethod = insets.getClass().getMethod("isVisible", int.class);
-                            Class<?> typeClass = Class.forName("android.view.WindowInsets$Type");
-                            int imeType = ((Integer) typeClass.getMethod("ime").invoke(null)).intValue();
-                            imeVisible = (Boolean) isVisibleMethod.invoke(insets, imeType);
-                        } catch (Throwable t) {
-                            // Fallback or log
-                        }
+                    boolean imeVisible = false;
+                    try {
+                        Method isVisibleMethod = insets.getClass().getMethod("isVisible", int.class);
+                        Class<?> typeClass = Class.forName("android.view.WindowInsets$Type");
+                        int imeType = ((Integer) typeClass.getMethod("ime").invoke(null)).intValue();
+                        imeVisible = (Boolean) isVisibleMethod.invoke(insets, imeType);
+                    } catch (Throwable t) {
+                        // Fallback or log
+                    }
 
-                        Rect systemBarInsets = AndroidImplementation.getSystemBarInsets(rootView);
-                        top = Math.max(systemBarInsets.top, top);
-                        if (imeVisible) {
-                            // Avoid double-counting the bottom gesture bar
-                            bottom = Math.max(bottom, 0);
-                        } else {
-                            bottom = Math.max(systemBarInsets.bottom, bottom);
-                        }
-                        left = Math.max(systemBarInsets.left, left);
-                        right = Math.max(systemBarInsets.right, right);
-
-                        if (!AndroidImplementation.isImmersive()) {
-                            top -= systemBarInsets.top;
-                            if (!imeVisible) {
-                                bottom -= systemBarInsets.bottom;
-                            }
-                            left -= systemBarInsets.left;
-                            right -= systemBarInsets.right;
+                    Rect systemBarInsets = AndroidImplementation.getSystemBarInsets(rootView);
+                    top = Math.max(systemBarInsets.top, top);
+                    if (imeVisible) {
+                        // Avoid double-counting the bottom gesture bar
+                        bottom = Math.max(bottom, 0);
+                    } else {
+                        bottom = Math.max(systemBarInsets.bottom, bottom);
+                    }
+                    left = Math.max(systemBarInsets.left, left);
+                    right = Math.max(systemBarInsets.right, right);
+
+                    if (!AndroidImplementation.isImmersive()) {
+                        top -= systemBarInsets.top;
+                        if (!imeVisible) {
+                            bottom -= systemBarInsets.bottom;
                         }
+                        left -= systemBarInsets.left;
+                        right -= systemBarInsets.right;
+                    }
 
-                        // Only apply if at least one is non-zero
-                        if (left != 0 || top != 0 || right != 0 || bottom != 0) {
-                            boolean isChanged = rect.left != left
-                                    || rect.right != right
-                                    || rect.top != top
-                                    || rect.bottom != bottom;
-                            rect.left = left;
-                            rect.top = top;
-                            rect.right = right;
-                            rect.bottom = bottom;
-
-                            if (isChanged) {
-                                Display.getInstance().callSerially(new Runnable() {
-                                    public void run() {
-                                        AndroidImplementation.getInstance().revalidate();
-                                    }
-                                });
-                            }
+                    // Only apply if at least one is non-zero
+                    if (left != 0 || top != 0 || right != 0 || bottom != 0) {
+                        boolean isChanged = rect.left != left
+                                || rect.right != right
+                                || rect.top != top
+                                || rect.bottom != bottom;
+                        rect.left = left;
+                        rect.top = top;
+                        rect.right = right;
+                        rect.bottom = bottom;
+
+                        if (isChanged) {
+                            Display.getInstance().callSerially(new Runnable() {
+                                public void run() {
+                                    AndroidImplementation.getInstance().revalidate();
+                                }
+                            });
                         }
                     }
                 }
-            } catch (Exception e) {
+            } catch (Throwable e) {
                 rect.top = 0;
                 rect.left = 0;
                 rect.right = 0;