Fix SpotBugs "Condition has no effect" (UC_USELESS_CONDITION) warnings

Updated .github/scripts/generate-quality-report.py to fail on UC_USELESS_CONDITION.
Fixed UC_USELESS_CONDITION warnings in:
- CodenameOne/src/com/codename1/ui/layouts/mig/Grid.java
- CodenameOne/src/com/codename1/ui/MenuBar.java
- CodenameOne/src/com/codename1/util/MathUtil.java
- CodenameOne/src/com/codename1/impl/CodenameOneImplementation.java
- CodenameOne/src/com/codename1/ui/Component.java
- CodenameOne/src/com/codename1/ui/ComponentGroup.java
- CodenameOne/src/com/codename1/ui/html/CSSEngine.java
- CodenameOne/src/com/codename1/ui/html/CSSParser.java
- CodenameOne/src/com/codename1/ui/html/HTMLComponent.java
- CodenameOne/src/com/codename1/ui/html/ResourceThreadQueue.java
- CodenameOne/src/com/codename1/ui/layouts/mig/UnitValue.java
- CodenameOne/src/com/codename1/util/regex/RECharacter.java
- CodenameOne/src/com/codename1/xml/XMLParser.java

Author: google-labs-jules[bot]

.github/scripts/generate-quality-report.py

@@ -770,7 +770,8 @@ def main() -> None:
             "ES_COMPARING_PARAMETER_STRING_WITH_EQ",
             "FE_FLOATING_POINT_EQUALITY",
             "FE_TEST_IF_EQUAL_TO_NOT_A_NUMBER",
-            "SA_FIELD_SELF_ASSIGNMENT"
+            "SA_FIELD_SELF_ASSIGNMENT",
+            "UC_USELESS_CONDITION"
         }
         violations = [
             f for f in spotbugs.findings

CodenameOne/src/com/codename1/impl/CodenameOneImplementation.java

@@ -8475,14 +8475,14 @@ protected int drawLabelText(Object nativeGraphics, int textDecoration, boolean r
                 // Instead we simple reposition the text, and draw the 3 points, this is quite simple, but
                 // the downside is that a part of a letter may be shown here as well.
 
-                if (rtl && !isTickerRunning && endsWith3Points) {
-                    // PMD Fix (CollapsibleIfStatements): Separate combined RTL and ticker checks into a single conditional.
-                    String points = "...";
-                    int pointsW = stringWidth(nativeFont, points);
-                    drawString(nativeGraphics, nativeFont, points, shiftText + x, y, textDecoration, fontHeight);
-                    clipRect(nativeGraphics, pointsW + shiftText + x, y, textSpaceW - pointsW, fontHeight);
-                }
                 if (rtl) {
+                    if (!isTickerRunning && endsWith3Points) {
+                        // PMD Fix (CollapsibleIfStatements): Separate combined RTL and ticker checks into a single conditional.
+                        String points = "...";
+                        int pointsW = stringWidth(nativeFont, points);
+                        drawString(nativeGraphics, nativeFont, points, shiftText + x, y, textDecoration, fontHeight);
+                        clipRect(nativeGraphics, pointsW + shiftText + x, y, textSpaceW - pointsW, fontHeight);
+                    }
                     x = x - txtW + textSpaceW;
                 } else if (endsWith3Points) {
                     String points = "...";

CodenameOne/src/com/codename1/ui/Component.java

@@ -5816,10 +5816,7 @@ private void pointerReleaseImpl(Component lead, int x, int y) {
                 return;
             }
 
-            int scroll = scrollY;
-            if (shouldScrollX) {
-                scroll = scrollX;
-            }
+            int scroll = shouldScrollX ? scrollX : scrollY;
             float speed = getDragSpeed(!shouldScrollX);
             int tl;
             if (getTensileLength() > -1) {

CodenameOne/src/com/codename1/ui/ComponentGroup.java

@@ -263,10 +263,7 @@ public Object getPropertyValue(String name) {
             return groupFlag;
         }
         if (name.equals("forceGroup")) {
-            if (forceGroup) {
-                return Boolean.TRUE;
-            }
-            return Boolean.FALSE;
+            return forceGroup ? Boolean.TRUE : Boolean.FALSE;
         }
         return null;
     }

CodenameOne/src/com/codename1/ui/MenuBar.java

@@ -752,7 +752,6 @@ public void actionPerformed(ActionEvent evt) {
                 c = result;
                 // a touch menu will always send its commands on its own...
                 if (!isTouchMenus()) {
-                    c = result;
                     if (c != null) {
                         ActionEvent e = new ActionEvent(c, ActionEvent.Type.Command);
                         c.actionPerformed(e);

CodenameOne/src/com/codename1/ui/html/CSSEngine.java

@@ -1669,9 +1669,8 @@ private void applyStyleToUIElement(Component ui, CSSElement selector, HTMLElemen
     }
 
     private void addOutlineToStyle(Style style, Border outline) {
-        Border curBorder = style.getBorder();
-        if (curBorder != null) {
-            curBorder.addOuterBorder(outline);
+        if (style.getBorder() != null) {
+            style.getBorder().addOuterBorder(outline);
         } else {
             style.setBorder(outline);
         }

CodenameOne/src/com/codename1/ui/html/CSSParser.java

@@ -102,7 +102,7 @@ private char handleCSSComment(ExtInputStreamReader r) throws IOException {
         char c = r.readCharFromReader();
         if (c == '*') {
             char lastC = '\0';
-            while ((c != '/') || (lastC != '*')) {
+            while (!(c == '/' && lastC == '*')) {
                 lastC = c;
                 c = r.readCharFromReader();
             }

CodenameOne/src/com/codename1/ui/html/HTMLComponent.java

@@ -2227,7 +2227,7 @@ private Label addString(String str, int align) {
                             for (int j = 0; j < spacesPerWord; j++) {
                                 newStr += ' ';
                             }
-                            if (i <= addtlSpaces) {
+                            if (i - 1 < addtlSpaces) {
                                 newStr += ' ';
                             }
                             newStr += ' ' + (String) words.elementAt(i);

CodenameOne/src/com/codename1/ui/html/ResourceThreadQueue.java

@@ -446,7 +446,7 @@ public void streamReady(InputStream is, DocumentInfo docInfo) {
                         htmlC.getHTMLCallback().parsingError(cssDocInfo != null ? HTMLCallback.ERROR_CSS_NOT_FOUND : HTMLCallback.ERROR_IMAGE_NOT_FOUND, null, null, null, (cssDocInfo != null ? "CSS" : "Image") + " not found at " + (cssDocInfo != null ? cssDocInfo.getUrl() : imageUrl));
                     }
                 } else {
-                    if (cssDocInfo != null) { // CSS
+                    if (this.cssDocInfo != null) { // CSS
                         if (HTMLComponent.SUPPORT_CSS) { // no need to also check if loadCSS is true, since if we got so far - it is...
                             CSSElement result = CSSParser.getInstance().parseCSSSegment(com.codename1.io.Util.getReader(is), is, htmlC, cssDocInfo.getUrl());
                             result.setAttribute(result.getAttributeName(Integer.valueOf(CSSElement.CSS_PAGEURL)), cssDocInfo.getUrl());

CodenameOne/src/com/codename1/ui/layouts/mig/Grid.java

@@ -288,7 +288,7 @@ public Grid(ContainerWrapper container, LC lc, AC rowConstr, AC colConstr, Map<?
                 setCell(cellXY[1], cellXY[0], cell);
 
                 // Add a rectangle so we can know that spanned cells occupy more space.
-                if (spanx > 1 || spany > 1) {
+                if (spanx != 1 || spany != 1) {
                     spannedRects.add(new int[]{cellXY[0], cellXY[1], spanx, spany});
                 }
             }