Checkstyle fixes second round (#3981)

Author: shai-almog

CodenameOne/src/com/codename1/charts/ChartComponent.java

@@ -133,7 +133,7 @@ public class ChartComponent extends Component {
      * Util object for rendering the chart.
      */
     private final ChartUtil util = new ChartUtil();
-    private ArrayList<IZoomTransition> animations = new ArrayList<IZoomTransition>();
+    private final ArrayList<IZoomTransition> animations = new ArrayList<IZoomTransition>();
     /**
      * The chart that is to be rendered in this component.
      */
@@ -606,7 +606,7 @@ public void pointerDragged(int[] x, int[] y) {
 
             if (chart instanceof XYChart) {
                 XYChart xyChart = (XYChart) chart;
-                double panLimits[] = xyChart.getRenderer().getPanLimits();
+                double[] panLimits = xyChart.getRenderer().getPanLimits();
                 if (dragStartBBox == null) {
                     dragStart = new Point(x[0], y[0]);
                     dragStartBBox = getBBox();
@@ -872,7 +872,7 @@ private void zoomTransition(double minX, double maxX, double minY, double maxY,
             float[] newRect = new float[]{(float) minX, (float) (maxX - minX), (float) minY, (float) (maxY - minY)};
 
             float currentAspect = currentRect[2] / currentRect[3];
-            float newAspect = newRect[3] / newRect[3];
+            float newAspect = 1.0f;
             Rectangle newViewPort = new Rectangle((int) newRect[0], (int) newRect[1], (int) newRect[2], (int) newRect[3]);
             if (newAspect != currentAspect) {
                 newViewPort.setHeight((int) (((double) newViewPort.getWidth()) / currentAspect));
@@ -949,7 +949,7 @@ private class ZoomTransition implements Animation, IZoomTransition {
         private final Rectangle currentViewPort;
         private final Rectangle newViewPort;
         private final Transform origTransform;
-        private Motion motion;
+        private final Motion motion;
         private boolean finished = false;
 
         ZoomTransition(Rectangle currentViewPort, Rectangle newViewPort, int duration) {

CodenameOne/src/com/codename1/charts/ChartUtil.java

@@ -35,7 +35,7 @@
  * @author shannah
  */
 public class ChartUtil {
-    private Canvas c = new Canvas();
+    private final Canvas c = new Canvas();
 
     /**
      * Draws the given chart onto the given graphics

CodenameOne/src/com/codename1/charts/compat/Canvas.java

@@ -239,7 +239,7 @@ public void drawRoundRect(Rectangle2D rect, float rx, float ry, Paint mPaint) {
             g.drawRoundRect((int) rect.getX(), (int) rect.getY(), (int) (rect.getWidth()), (int) (rect.getHeight()), (int) rx, (int) ry);
         } else if (Paint.Style.FILL_AND_STROKE.equals(style)) {
             g.fillRoundRect((int) rect.getX(), (int) rect.getY(), (int) (rect.getWidth()), (int) (rect.getHeight()), (int) rx, (int) ry);
-            g.drawRoundRect((int) rect.getX(), (int) rect.getY(), (int) (getWidth()), (int) (rect.getHeight()), (int) rx, (int) ry);
+            g.drawRoundRect((int) rect.getX(), (int) rect.getY(), getWidth(), (int) (rect.getHeight()), (int) rx, (int) ry);
         }
         g.drawRoundRect((int) rect.getX(), (int) rect.getY(), (int) (rect.getWidth()), (int) (rect.getHeight()), (int) rx, (int) ry);
 

CodenameOne/src/com/codename1/charts/models/AreaSeries.java

@@ -28,16 +28,16 @@ public class AreaSeries {
     /**
      * The series data table.
      */
-    private Map<String, HashMap<Integer, Double>> mTable = new HashMap<String, HashMap<Integer, Double>>();
+    private final Map<String, HashMap<Integer, Double>> mTable = new HashMap<String, HashMap<Integer, Double>>();
 
     /**
      * The categories.
      */
-    private List<String> mCategories = new ArrayList<String>();
+    private final List<String> mCategories = new ArrayList<String>();
     /**
      * The series.
      */
-    private List<String> mSeries = new ArrayList<String>();
+    private final List<String> mSeries = new ArrayList<String>();
 
     /**
      * Adds a new Category series to the table.

CodenameOne/src/com/codename1/charts/models/CategorySeries.java

@@ -23,11 +23,11 @@
  */
 public class CategorySeries {
     /** The series title. */
-    private String mTitle;
+    private final String mTitle;
     /** The series categories. */
-    private List<String> mCategories = new ArrayList<String>();
+    private final List<String> mCategories = new ArrayList<String>();
     /** The series values. */
-    private List<Double> mValues = new ArrayList<Double>();
+    private final List<Double> mValues = new ArrayList<Double>();
 
     /**
      * Builds a new category series.

CodenameOne/src/com/codename1/charts/models/MultipleCategorySeries.java

@@ -23,13 +23,13 @@
  */
 public class MultipleCategorySeries {
     /** The series title. */
-    private String mTitle;
+    private final String mTitle;
     /** The series local keys. */
-    private List<String> mCategories = new ArrayList<String>();
+    private final List<String> mCategories = new ArrayList<String>();
     /** The series name. */
-    private List<String[]> mTitles = new ArrayList<String[]>();
+    private final List<String[]> mTitles = new ArrayList<String[]>();
     /** The series values. */
-    private List<double[]> mValues = new ArrayList<double[]>();
+    private final List<double[]> mValues = new ArrayList<double[]>();
 
     /**
      * Builds a new category series.

CodenameOne/src/com/codename1/charts/models/RangeCategorySeries.java

@@ -23,7 +23,7 @@
  */
 public class RangeCategorySeries extends CategorySeries {
     /** The series values. */
-    private List<Double> mMaxValues = new ArrayList<Double>();
+    private final List<Double> mMaxValues = new ArrayList<Double>();
 
     /**
      * Builds a new category series.

CodenameOne/src/com/codename1/charts/models/SeriesSelection.java

@@ -16,13 +16,13 @@
 package com.codename1.charts.models;
 
 public class SeriesSelection {
-    private int mSeriesIndex;
+    private final int mSeriesIndex;
 
-    private int mPointIndex;
+    private final int mPointIndex;
 
-    private double mXValue;
+    private final double mXValue;
 
-    private double mValue;
+    private final double mValue;
 
     public SeriesSelection(int seriesIndex, int pointIndex, double xValue, double value) {
         mSeriesIndex = seriesIndex;

CodenameOne/src/com/codename1/charts/models/XYMultipleSeriesDataset.java

@@ -23,7 +23,7 @@
  */
 public class XYMultipleSeriesDataset {
     /** The included series. */
-    private List<XYSeries> mSeries = new ArrayList<XYSeries>();
+    private final List<XYSeries> mSeries = new ArrayList<XYSeries>();
 
     /**
      * Adds a new XY series to the list.

CodenameOne/src/com/codename1/charts/models/XYSeries.java

@@ -48,7 +48,7 @@ public class XYSeries {
     /** The maximum value for the Y axis. */
     private double mMaxY = MathHelper.NULL_VALUE;
     /** Contains the annotations. */
-    private List<String> mAnnotations = new ArrayList<String>();
+    private final List<String> mAnnotations = new ArrayList<String>();
 
     /**
      * Builds a new XY series.