Improved CI build validation

Author: shai-almog

CodenameOne/src/com/codename1/impl/CodenameOneImplementation.java

@@ -123,8 +123,8 @@ public abstract class CodenameOneImplementation {
      */
     private static final int RTL_RANGE_BEGIN = 0x590;
     private static final int RTL_RANGE_END = 0x7BF;
-    private static Object displayLock;
-    private static boolean bidi;
+    private Object displayLock;
+    private boolean bidi;
     private static boolean pollingThreadRunning;
     private static PushCallback callback;
     private static PurchaseCallback purchaseCallback;
@@ -927,16 +927,6 @@ public boolean paintNativePeersBehind() {
         return false;
     }
 
-    /**
-     * Returns a lock object which can be synchronized against, this lock is used
-     * by the EDT.
-     *
-     * @return a lock object
-     */
-    public Object getDisplayLock() {
-        return displayLock;
-    }
-
     /**
      * Installs the display lock allowing implementors to synchronize against the
      * Display mutex, this method is invoked internally and should not be used.
@@ -8786,7 +8776,7 @@ public void postMessage(MessageEvent message) {
      * @return true in case of dark mode
      */
     public Boolean isDarkMode() {
-        return null;
+        return Boolean.FALSE;
     }
 
     /**

CodenameOne/src/com/codename1/io/FileSystemStorage.java

@@ -161,7 +161,6 @@ public void delete(String file) {
      * @param retryCount the number of times to retry
      */
     public void deleteRetry(final String file, final int retryCount) {
-        System.gc();
         try {
             Util.getImplementation().deleteFile(file);
         } catch (Throwable t) {

CodenameOne/src/com/codename1/location/LocationManager.java

@@ -52,7 +52,7 @@ public abstract class LocationManager {
     public static final int OUT_OF_SERVICE = 1;
     public static final int TEMPORARILY_UNAVAILABLE = 2;
     private static LocationListener listener;
-    private static LocationRequest request;
+    private LocationRequest request;
     private static Class backgroundlistener;
     private int status = TEMPORARILY_UNAVAILABLE;
 

CodenameOne/src/com/codename1/payment/Purchase.java

@@ -56,9 +56,9 @@ public abstract class Purchase {
     private static final Object PENDING_PURCHASE_LOCK = new Object();
     private static final Object synchronizationLock = new Object();
     private static final Object receiptsLock = new Object();
-    private static ReceiptStore receiptStore;
-    private static List<Receipt> receipts;
-    private static Date receiptsRefreshTime;
+    private ReceiptStore receiptStore;
+    private List<Receipt> receipts;
+    private Date receiptsRefreshTime;
     /**
      * Boolean flag to prevent {@link #synchronizeReceipts(long, com.codename1.util.SuccessCallback) }
      * re-entry.
@@ -281,7 +281,7 @@ public boolean isItemListingSupported() {
     /**
      * Returns the product list for the given SKU array
      *
-     * @param sku the ids for the specific products
+     * @param skus the ids for the specific products
      * @return the product instances
      * @throws RuntimeException This method is a part of the managed payments API and will fail if
      *                          isManagedPaymentSupported() returns false

CodenameOne/src/com/codename1/ui/Component.java

@@ -237,7 +237,7 @@ public class Component implements Animation, StyleListener, Editable {
      * <p>
      * Users can disable this with {@code CN.setProperty("Component.revalidateOnStyleChange", "false")}.
      */
-    static boolean revalidateOnStyleChange = true;
+    private static boolean revalidateOnStyleChange = true;
     static int restoreDragPercentage = -1;
     private static byte defaultDragTransparency = 55;
     private static boolean disableSmoothScrolling = false;
@@ -534,6 +534,14 @@ public static boolean isSetCursorSupported() {
         return Display.getInstance().getImplementation().isSetCursorSupported();
     }
 
+    static void setRevalidateOnStyleChange(boolean val) {
+        revalidateOnStyleChange = val;
+    }
+
+    static boolean isRevalidateOnStyleChange() {
+        return revalidateOnStyleChange;
+    }
+
     /**
      * Parses the preferred size given as a string
      *
@@ -3197,8 +3205,8 @@ private void drawPaintersImpl(com.codename1.ui.Graphics g, Component par, Compon
     }
 
     private void paintRippleEffect(Graphics g) {
-        if (isRippleEffect() && Form.rippleComponent == this && Form.rippleMotion != null) {
-            paintRippleOverlay(g, Form.rippleX, Form.rippleY, Form.rippleMotion.getValue());
+        if (isRippleEffect() && Form.getRippleComponent() == this && Form.getRippleMotion() != null) {
+            paintRippleOverlay(g, Form.rippleX, Form.rippleY, Form.getRippleMotion().getValue());
         }
     }
 
@@ -4497,7 +4505,7 @@ protected void updateState() {
                         sourceStyle.setMargin(RIGHT, marginRight.getValue());
                         requiresRevalidate = true;
                     }
-                    if (!Component.revalidateOnStyleChange) {
+                    if (!Component.isRevalidateOnStyleChange()) {
                         // If revalidation on stylechange is not enabled, then the style animation
                         // won't work. We need to explicitly revalidate or repaint here.
                         if (requiresRevalidate) {
@@ -7063,7 +7071,7 @@ public void styleChanged(String propertyName, Style source) {
             setShouldCalcPreferredSize(true);
             Container parent = getParent();
             if (parent != null && parent.getComponentForm() != null) {
-                if (revalidateOnStyleChange) {
+                if (isRevalidateOnStyleChange()) {
                     parent.revalidateLater();
                 }
             }

CodenameOne/src/com/codename1/ui/Container.java

@@ -78,13 +78,13 @@
  * @see Component
  */
 public class Container extends Component implements Iterable<Component> {
-    static boolean enableLayoutOnPaint = true;
+    private static boolean enableLayoutOnPaint = true;
     /**
      * Workaround for the behavior of the sidemenu bar on iOS etc. which translates aggressively,
      * this is visible with the table component where the lines slide out of place
      */
     static int sidemenuBarTranslation;
-    static boolean blockOverdraw = false;
+    private static boolean blockOverdraw;
     boolean scrollableX;
     boolean scrollableY;
     /**
@@ -152,6 +152,10 @@ public Container(Layout layout, String uiid) {
         setFocusable(false);
     }
 
+    static void blockOverdraw() {
+        blockOverdraw = true;
+    }
+
     /**
      * Constructs a new Container with a new layout manager.
      *
@@ -1002,6 +1006,10 @@ public void replaceAndWait(final Component current, final Component next, final
         replaceComponents(current, next, t, true, false, null, 0, 0, true);
     }
 
+    static void setEnableLayoutOnPaint(boolean val) {
+        enableLayoutOnPaint = val;
+    }
+
     /**
      * This method replaces the current Component with the next Component.
      * Current Component must be contained in this Container.
@@ -1014,13 +1022,13 @@ public void replaceAndWait(final Component current, final Component next, final
      * @param layoutAnimationSpeed the speed of the layout animation after replace  is completed
      */
     public void replaceAndWait(final Component current, final Component next, final Transition t, int layoutAnimationSpeed) {
-        enableLayoutOnPaint = false;
+        setEnableLayoutOnPaint(false);
         replaceComponents(current, next, t, true, false, null, 0, layoutAnimationSpeed, true);
         if (layoutAnimationSpeed > 0) {
             animateLayoutAndWait(layoutAnimationSpeed);
         }
         dontRecurseContainer = false;
-        enableLayoutOnPaint = true;
+        setEnableLayoutOnPaint(true);
     }
 
     /**
@@ -3700,7 +3708,7 @@ public void morphAndWait(Component source, Component destination, int duration)
 
     private void morph(Component source, Component destination, int duration, boolean wait, Runnable onCompletion) {
         setShouldCalcPreferredSize(true);
-        enableLayoutOnPaint = false;
+        setEnableLayoutOnPaint(false);
         dontRecurseContainer = true;
         int deltaX = getAbsoluteX();
         int deltaY = getAbsoluteY();
@@ -3755,7 +3763,7 @@ private void morph(Component source, Component destination, int duration, boolea
      */
     private ComponentAnimation animateHierarchy(final int duration, boolean wait, int opacity, boolean add) {
         setShouldCalcPreferredSize(true);
-        enableLayoutOnPaint = false;
+        setEnableLayoutOnPaint(false);
         dontRecurseContainer = true;
         Vector comps = new Vector();
         findComponentsInHierachy(comps);
@@ -3853,7 +3861,7 @@ public ComponentAnimation createAnimateUnlayout(int duration, int opacity, Runna
      */
     private ComponentAnimation animateUnlayout(final int duration, boolean wait, int opacity, Runnable callback, boolean add) {
         setShouldCalcPreferredSize(true);
-        enableLayoutOnPaint = false;
+        setEnableLayoutOnPaint(false);
         final int componentCount = getComponentCount();
         int[] beforeX = new int[componentCount];
         int[] beforeY = new int[componentCount];
@@ -3913,7 +3921,7 @@ private ComponentAnimation animateLayout(final int duration, boolean wait, int o
             return null;
         }
         setShouldCalcPreferredSize(true);
-        enableLayoutOnPaint = false;
+        setEnableLayoutOnPaint(false);
         final int componentCount = getComponentCount();
         int[] beforeX = new int[componentCount];
         int[] beforeY = new int[componentCount];
@@ -4362,7 +4370,7 @@ protected void updateState() {
             }
             thisContainer.repaint();
             if (System.currentTimeMillis() - startTime >= duration) {
-                enableLayoutOnPaint = true;
+                setEnableLayoutOnPaint(true);
                 thisContainer.dontRecurseContainer = false;
                 Form f = thisContainer.getComponentForm();
                 finished = true;

CodenameOne/src/com/codename1/ui/Display.java

@@ -288,9 +288,9 @@ public final class Display extends CN1Constants {
     private static final int MAX_ASYNC_EXCEPTION_DEPTH = 10;
     private static final int[] xArray1 = new int[1];
     private static final int[] yArray1 = new int[1];
-    static int transitionDelay = -1;
+    private int transitionDelay = -1;
     static CodenameOneImplementation impl;
-    private static String selectedVirtualKeyboard = null;
+    private String selectedVirtualKeyboard = null;
     private static final Map<String, VirtualKeyboardInterface> virtualKeyboards = new HashMap<String, VirtualKeyboardInterface>();
     private final LinkedList<Runnable> runningSerialCallsQueue = new LinkedList<Runnable>();
     boolean codenameOneExited;
@@ -3491,7 +3491,7 @@ public String getProperty(String key, String defaultValue) {
             return out == null ? defaultValue : out;
         }
         if ("Component.revalidateOnStyleChange".equals(key)) {
-            return Component.revalidateOnStyleChange ? "true" : "false";
+            return Component.isRevalidateOnStyleChange() ? "true" : "false";
         }
         if (localProperties != null) {
             String v = localProperties.get(key);
@@ -3516,14 +3516,14 @@ public void setProperty(String key, String value) {
             return;
         }
         if ("blockOverdraw".equals(key)) {
-            Container.blockOverdraw = true;
+            Container.blockOverdraw();
             return;
         }
         if ("blockCopyPaste".equals(key)) {
             impl.blockCopyPaste("true".equals(value));
         }
         if ("Component.revalidateOnStyleChange".equals(key)) {
-            Component.revalidateOnStyleChange = "true".equalsIgnoreCase(value);
+            Component.setRevalidateOnStyleChange("true".equalsIgnoreCase(value));
         }
         if (key.startsWith("platformHint.")) {
             impl.setPlatformHint(key, value);

CodenameOne/src/com/codename1/ui/Form.java

@@ -70,8 +70,8 @@
 public class Form extends Container {
     private static final String Z_INDEX_PROP = "cn1$_zIndex";
     static int activePeerCount;
-    static Motion rippleMotion;
-    static Component rippleComponent;
+    private static Motion rippleMotion;
+    private static Component rippleComponent;
     static int rippleX;
     static int rippleY;
     /**
@@ -256,6 +256,10 @@ public Form(Layout contentPaneLayout) {
         initGlobalToolbar();
     }
 
+    static Motion getRippleMotion() {
+        return rippleMotion;
+    }
+
     /**
      * Sets the title after invoking the constructor
      *
@@ -2031,6 +2035,14 @@ public boolean animate() {
         return super.animate();
     }
 
+    static Component getRippleComponent() {
+        return rippleComponent;
+    }
+
+    private static void resetRippleComponent() {
+        rippleComponent = null;
+    }
+
     /**
      * Makes sure all animations are repainted so they would be rendered in every
      * frame
@@ -2039,7 +2051,7 @@ void repaintAnimations() {
         if (rippleComponent != null) {
             rippleComponent.repaint();
             if (rippleMotion == null) {
-                rippleComponent = null;
+                resetRippleComponent();
             }
         }
         if (animatableComponents != null) {
@@ -3089,11 +3101,15 @@ public void keyRepeated(int keyCode) {
         }
     }
 
+    static void setRippleComponent(Component cmp) {
+        rippleComponent = cmp;
+    }
+
     private void initRippleEffect(int x, int y, Component cmp) {
         if (cmp.isRippleEffect()) {
             rippleMotion = Motion.createEaseInMotion(0, 1000, 800);
             rippleMotion.start();
-            rippleComponent = cmp;
+            setRippleComponent(cmp);
             rippleX = x;
             rippleY = y;
         }

CodenameOne/src/com/codename1/ui/Tabs.java

@@ -304,7 +304,7 @@ public boolean animate() {
                     component.paintLockRelease();
                 }
                 slideToDestMotion = null;
-                enableLayoutOnPaint = true;
+                setEnableLayoutOnPaint(true);
                 deregisterAnimatedInternal();
                 setSelectedIndex(active);
             }
@@ -1653,7 +1653,7 @@ public void actionPerformed(ActionEvent evt) {
                                 component.setX(component.getX() + diffX);
                                 component.paintLock(false);
                             }
-                            enableLayoutOnPaint = false;
+                            setEnableLayoutOnPaint(false);
                             repaint();
                         }
                     }
@@ -1667,7 +1667,7 @@ public void actionPerformed(ActionEvent evt) {
                                 component.setY(component.getY() + diffY);
                                 component.paintLock(false);
                             }
-                            enableLayoutOnPaint = false;
+                            setEnableLayoutOnPaint(false);
                             repaint();
                         }
                     }

maven/core-unittests/spotbugs-exclude.xml

@@ -65,6 +65,17 @@
         <Bug pattern="SE_NO_SERIALVERSIONID"/>
     </Match>
 
+    <!-- We don't support clone() -->
+    <Match>
+        <Bug pattern="CN_IMPLEMENTS_CLONE_BUT_NOT_CLONEABLE"/>
+    </Match>
+
+    <!-- We don't support clone() -->
+    <Match>
+        <Bug pattern="CN_IDIOM_NO_SUPER_CALL"/>
+    </Match>
+
+
     <!-- Match>
         <Bug pattern="UI_INHERITANCE_UNSAFE_GETRESOURCE"/>
     </Match>