Refine build scripts to use JDK8 and fix macOS JDK paths

Author: shai-almog

BUILDING.md

@@ -1,39 +1,37 @@
 # Building Codename One
 
-This document provides reproducible instructions for building Codename One and its Android and iOS ports with Maven.
+This guide explains how to build Codename One and its Android and iOS ports locally using Maven.
 
 ## Prerequisites
 
-- **JDK 11** (Codename One also builds with JDK 8, but these instructions use JDK 11).
-- **JDK 17** for building the Android port.
-- **Apache Maven 3.6+**.
-- macOS with Xcode (only for building the iOS port).
+- **JDK 8** (Codename One also builds with JDK 11, but these steps use JDK 8)
+- **JDK 17** for building the Android port
+- **Apache Maven 3.6+**
+- macOS with Xcode (required only for the iOS port)
 
-The `setup-workspace.sh` script downloads these dependencies automatically when they are not already installed.
+The helper scripts in the `scripts/` directory download these dependencies when they are not already installed.
 
 ### Installing JDKs on Linux
 
 Download binaries from [Adoptium](https://adoptium.net):
 
 ```bash
-# JDK 11 (Linux x64; adjust `_x64_linux_` for your OS and architecture)
-curl -L -o temurin11.tar.gz https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.28%2B6/OpenJDK11U-jdk_x64_linux_hotspot_11.0.28_6.tar.gz
-tar xf temurin11.tar.gz
-export JAVA_HOME=$PWD/jdk-11*
+# JDK 8 (Linux x64; adjust `_x64_linux_` for your platform)
+curl -L -o temurin8.tar.gz https://github.com/adoptium/temurin8-binaries/releases/download/jdk8u442-b06/OpenJDK8U-jdk_x64_linux_hotspot_8u442b06.tar.gz
+tar xf temurin8.tar.gz
+export JAVA_HOME=$PWD/jdk8u442-b06
 
-# JDK 17 (Linux x64; adjust `_x64_linux_` for your OS and architecture)
+# JDK 17 (Linux x64; adjust `_x64_linux_` for your platform)
 curl -L -o temurin17.tar.gz https://github.com/adoptium/temurin17-binaries/releases/download/jdk-17.0.16%2B8/OpenJDK17U-jdk_x64_linux_hotspot_17.0.16_8.tar.gz
 tar xf temurin17.tar.gz
-export JAVA_HOME_17=$PWD/jdk-17*
+export JAVA_HOME_17=$PWD/jdk-17.0.16+8
 
 export PATH="$JAVA_HOME/bin:$PATH"
 ```
 
-The Android port uses JDK 17 while Maven runs with JDK 11. The helper scripts download both JDKs and set `JAVA_HOME` and `JAVA_HOME_17`.
-
 ## Preparing the workspace
 
-Clone the repository and run the setup script to install Maven, download JDK 11 and JDK 17, build the core modules, and install the Maven archetypes. This step must be performed before building any ports.
+Clone the repository and run the setup script to download JDK 8 and JDK 17, install Maven, build the core modules, and install the Maven archetypes. This step must be performed before building any ports.
 
 ```bash
 git clone https://github.com/codenameone/CodenameOne
@@ -46,35 +44,31 @@ The script runs `mvn install` in `maven/`, installs `cn1-maven-archetypes`, and
 
 ## Building the Android port
 
-Run the Android build script. It sources the environment from `tools/env.sh`, ensuring `JAVA_HOME` points to JDK 11 and `JAVA_HOME_17` points to JDK 17. If the JDKs are missing, the script will run `setup-workspace.sh` to download them:
+The Android port uses JDK 17 for compilation while Maven runs with JDK 8. Run the build script:
 
 ```bash
 ./scripts/build-android-port.sh -DskipTests
 ```
 
-The resulting artifacts are placed in `maven/android/target`.
+Artifacts are placed in `maven/android/target`.
 
 ## Building the iOS port
 
-The iOS port can only be built on macOS with Xcode installed. The build script sources `tools/env.sh` and ensures `JAVA_HOME` points to JDK 11, running `setup-workspace.sh` if necessary:
+The iOS port can only be built on macOS with Xcode installed. Run the iOS script:
 
 ```bash
 ./scripts/build-ios-port.sh -DskipTests
 ```
 
-The build output is in `maven/ios/target`.
+Artifacts are produced in `maven/ios/target`.
 
 ## Convenience scripts
 
-The `scripts` directory contains helper scripts:
-
-- `setup-workspace.sh` – installs Maven, downloads JDK 11 and JDK 17, builds the core modules, installs Maven archetypes, provisions the Codename One build client, and writes `tools/env.sh`.
-- `build-android-port.sh` – builds the Android port using JDK 11 for Maven and JDK 17 for compilation.
-- `build-ios-port.sh` – builds the iOS port on macOS with JDK 11.
-
-These scripts accept additional Maven arguments, which are passed through to the underlying `mvn` commands.
+- `setup-workspace.sh` – installs Maven, downloads JDK 8 and JDK 17, builds the core modules, installs Maven archetypes, provisions the Codename One build client, and writes `tools/env.sh`.
+- `build-android-port.sh` – builds the Android port using JDK 8 for Maven and JDK 17 for compilation.
+- `build-ios-port.sh` – builds the iOS port on macOS with JDK 8.
 
 ## Further reading
 
-- Blog post: *Building Codename One from source, Maven edition* – https://www.codenameone.com/blog/building-codename-one-from-source-maven-edition.html
-- Maven developers guide – https://shannah.github.io/codenameone-maven-manual/
+- Blog post: <https://www.codenameone.com/blog/building-codename-one-from-source-maven-edition.html>
+- Maven developers guide: <https://shannah.github.io/codenameone-maven-manual/>

scripts/build-android-port.sh

@@ -1,55 +1,35 @@
-#!/bin/bash
-# Build Codename One Android port
-set -e
-
-DIR="$(cd "$(dirname "$0")" && pwd)/.."
-cd "$DIR"
-
-if [ -f "$DIR/tools/env.sh" ]; then
-  source "$DIR/tools/env.sh"
-fi
-
-if [ -z "$JAVA_HOME" ] || ! "$JAVA_HOME/bin/java" -version 2>&1 | head -n1 | grep -q "11"; then
-  echo "Provisioning workspace..."
+#!/usr/bin/env bash
+# Build Codename One Android port using JDK 8 for Maven and JDK 17 for compilation
+set -euo pipefail
+ROOT="$(cd "$(dirname "$0")/.." && pwd)"
+cd "$ROOT"
+
+if [ -f "$ROOT/tools/env.sh" ]; then
+  source "$ROOT/tools/env.sh"
+else
   ./scripts/setup-workspace.sh -q -DskipTests
-  source "$DIR/tools/env.sh"
+  source "$ROOT/tools/env.sh"
 fi
 
-if [ -z "$JAVA_HOME" ] || ! "$JAVA_HOME/bin/java" -version 2>&1 | head -n1 | grep -q "11"; then
-  echo "Failed to set up JDK 11." >&2
+if ! "$JAVA_HOME/bin/java" -version 2>&1 | grep -q '1\.8'; then
+  echo "JAVA_HOME must point to JDK 8" >&2
   exit 1
 fi
-
-if [ -z "$JAVA_HOME_17" ] || ! "$JAVA_HOME_17/bin/java" -version 2>&1 | head -n1 | grep -q "17"; then
-  echo "Provisioning JDK 17..."
-  ./scripts/setup-workspace.sh -q -DskipTests
-  source "$DIR/tools/env.sh"
-fi
-
-if [ -z "$JAVA_HOME_17" ] || ! "$JAVA_HOME_17/bin/java" -version 2>&1 | head -n1 | grep -q "17"; then
-  echo "Failed to set up JDK 17." >&2
+if ! "$JAVA_HOME_17/bin/java" -version 2>&1 | grep -q '17\.0'; then
+  echo "JAVA_HOME_17 must point to JDK 17" >&2
   exit 1
 fi
 
 export PATH="$JAVA_HOME/bin:$MAVEN_HOME/bin:$PATH"
-
-echo "JAVA_HOME is set to $JAVA_HOME"
 "$JAVA_HOME/bin/java" -version
-echo "JAVA_HOME_17 is set to $JAVA_HOME_17"
 "$JAVA_HOME_17/bin/java" -version
-echo "PATH is $PATH"
-mvn -version
+"$MAVEN_HOME/bin/mvn" -version
 
 BUILD_CLIENT="$HOME/.codenameone/CodeNameOneBuildClient.jar"
 if [ ! -f "$BUILD_CLIENT" ]; then
-  if ! mvn -f maven/pom.xml cn1:install-codenameone "$@"; then
-    if [ -f maven/CodeNameOneBuildClient.jar ]; then
-      mkdir -p "$(dirname "$BUILD_CLIENT")"
-      cp maven/CodeNameOneBuildClient.jar "$BUILD_CLIENT"
-    else
-      echo "maven/CodeNameOneBuildClient.jar not found." >&2
-    fi
+  if ! "$MAVEN_HOME/bin/mvn" -q -f maven/pom.xml cn1:install-codenameone "$@"; then
+    [ -f maven/CodeNameOneBuildClient.jar ] && cp maven/CodeNameOneBuildClient.jar "$BUILD_CLIENT" || true
   fi
 fi
 
-mvn -f maven/pom.xml -pl android -am clean install "$@"
+"$MAVEN_HOME/bin/mvn" -q -f maven/pom.xml -pl android -am clean install "$@"

scripts/build-ios-port.sh

@@ -1,56 +1,35 @@
-#!/bin/bash
-# Build Codename One iOS port
-# Requires macOS with Xcode installed
-set -e
-
+#!/usr/bin/env bash
+# Build Codename One iOS port (macOS only)
+set -euo pipefail
 if [[ "$(uname)" != "Darwin" ]]; then
-  echo "The iOS port can only be built on macOS." >&2
+  echo "The iOS port can only be built on macOS with Xcode installed." >&2
   exit 1
 fi
 if ! command -v xcodebuild >/dev/null; then
   echo "Xcode command-line tools not found." >&2
   exit 1
 fi
-
-DIR="$(cd "$(dirname "$0")" && pwd)/.."
-cd "$DIR"
-
-if [ -f "$DIR/tools/env.sh" ]; then
-  source "$DIR/tools/env.sh"
-fi
-
-if [ -z "$JAVA_HOME" ] || ! "$JAVA_HOME/bin/java" -version 2>&1 | head -n1 | grep -q "11"; then
-  echo "Provisioning workspace..."
+ROOT="$(cd "$(dirname "$0")/.." && pwd)"
+cd "$ROOT"
+if [ -f "$ROOT/tools/env.sh" ]; then
+  source "$ROOT/tools/env.sh"
+else
   ./scripts/setup-workspace.sh -q -DskipTests
-  source "$DIR/tools/env.sh"
+  source "$ROOT/tools/env.sh"
 fi
-
-if [ -z "$JAVA_HOME" ] || ! "$JAVA_HOME/bin/java" -version 2>&1 | head -n1 | grep -q "11"; then
-  echo "Failed to set up JDK 11." >&2
+if ! "$JAVA_HOME/bin/java" -version 2>&1 | grep -q '1\.8'; then
+  echo "JAVA_HOME must point to JDK 8" >&2
   exit 1
 fi
-
 export PATH="$JAVA_HOME/bin:$MAVEN_HOME/bin:$PATH"
-
-echo "JAVA_HOME is set to $JAVA_HOME"
-if [ -x "$JAVA_HOME/bin/java" ]; then
-  "$JAVA_HOME/bin/java" -version
-else
-  echo "java executable not found under $JAVA_HOME" >&2
-fi
-echo "PATH is $PATH"
-mvn -version
+"$JAVA_HOME/bin/java" -version
+"$MAVEN_HOME/bin/mvn" -version
 
 BUILD_CLIENT="$HOME/.codenameone/CodeNameOneBuildClient.jar"
 if [ ! -f "$BUILD_CLIENT" ]; then
-  if ! mvn -f maven/pom.xml cn1:install-codenameone "$@"; then
-    if [ -f maven/CodeNameOneBuildClient.jar ]; then
-      mkdir -p "$(dirname "$BUILD_CLIENT")"
-      cp maven/CodeNameOneBuildClient.jar "$BUILD_CLIENT"
-    else
-      echo "maven/CodeNameOneBuildClient.jar not found." >&2
-    fi
+  if ! "$MAVEN_HOME/bin/mvn" -q -f maven/pom.xml cn1:install-codenameone "$@"; then
+    [ -f maven/CodeNameOneBuildClient.jar ] && cp maven/CodeNameOneBuildClient.jar "$BUILD_CLIENT" || true
   fi
 fi
 
-mvn -f maven/pom.xml -pl ios -am clean install "$@"
+"$MAVEN_HOME/bin/mvn" -q -f maven/pom.xml -pl ios -am clean install "$@"