Document PMD fixes inline (#3976)

Author: shai-almog

CodenameOne/src/com/codename1/ads/InnerActive.java

@@ -37,7 +37,7 @@
  * 
  * @author Chen
  */
-public class InnerActive extends AdsService{
+public class InnerActive extends AdsService{ // PMD Fix: UnusedPrivateField removed obsolete field
 
     private final String REQUEST_URL = "http://m2m1.inner-active.com/simpleM2M/clientRequestHtmlAd";
 
@@ -51,9 +51,6 @@ public class InnerActive extends AdsService{
     //UDID/IMEI
     private String hid;
 
-    //client Id
-    private String cid;
-
     private boolean banner = true;
 
     private static boolean testAds = true;

CodenameOne/src/com/codename1/background/BackgroundFetch.java

@@ -68,6 +68,6 @@ public interface BackgroundFetch {
      * @see com.codename1.ui.Display.getPreferredBackgroundFetchInterval()
      * @see com.codename1.ui.Display.isBackgroundFetchSupported()
      */
-    public void performBackgroundFetch(long deadline, Callback<Boolean> onComplete);
+    void performBackgroundFetch(long deadline, Callback<Boolean> onComplete); // PMD Fix: UnnecessaryModifier removed
 
 }

CodenameOne/src/com/codename1/capture/VideoCaptureConstraints.java

@@ -101,8 +101,8 @@ public class VideoCaptureConstraints {
      * to transfer the "preferred" constraints to corresponding "actual" constraints
      * based on what the platform supports.
      */
-    public static interface Compiler {
-        public VideoCaptureConstraints compile(VideoCaptureConstraints cnst);
+    public interface Compiler { // PMD Fix: UnnecessaryModifier removed implicit static
+        VideoCaptureConstraints compile(VideoCaptureConstraints cnst); // PMD Fix: UnnecessaryModifier removed redundant public
     }
 
     /**

CodenameOne/src/com/codename1/charts/ChartComponent.java

@@ -536,29 +536,21 @@ public void pointerDragged(int[] x, int[] y) {
                     }
 
                     double[] zoomLimits = xyChart.getRenderer().getZoomLimits();
-                    if (zoomLimits != null && zoomLimits[0] != 0) {
-                        if (maxX - minX < zoomLimits[0]) {
-                            maxX = xyChart.getRenderer().getXAxisMax();
-                            minX = xyChart.getRenderer().getXAxisMin();
-                        }
+                    if (zoomLimits != null && zoomLimits[0] != 0 && maxX - minX < zoomLimits[0]) { // PMD Fix: CollapsibleIfStatements
+                        maxX = xyChart.getRenderer().getXAxisMax();
+                        minX = xyChart.getRenderer().getXAxisMin();
                     }
-                    if (zoomLimits != null && zoomLimits[1] != 0) {
-                        if (maxX - minX > zoomLimits[1]) {
-                            maxX = xyChart.getRenderer().getXAxisMax();
-                            minX = xyChart.getRenderer().getXAxisMin();
-                        }
+                    if (zoomLimits != null && zoomLimits[1] != 0 && maxX - minX > zoomLimits[1]) { // PMD Fix: CollapsibleIfStatements
+                        maxX = xyChart.getRenderer().getXAxisMax();
+                        minX = xyChart.getRenderer().getXAxisMin();
                     }
-                    if (zoomLimits != null && zoomLimits[2] != 0) {
-                        if (maxY - minY < zoomLimits[2]) {
-                            maxY = xyChart.getRenderer().getYAxisMax();
-                            minY = xyChart.getRenderer().getYAxisMin();
-                        }
+                    if (zoomLimits != null && zoomLimits[2] != 0 && maxY - minY < zoomLimits[2]) { // PMD Fix: CollapsibleIfStatements
+                        maxY = xyChart.getRenderer().getYAxisMax();
+                        minY = xyChart.getRenderer().getYAxisMin();
                     }
-                    if (zoomLimits != null && zoomLimits[3] != 0) {
-                        if (maxY - minY > zoomLimits[3]) {
-                            maxY = xyChart.getRenderer().getYAxisMax();
-                            minY = xyChart.getRenderer().getYAxisMin();
-                        }
+                    if (zoomLimits != null && zoomLimits[3] != 0 && maxY - minY > zoomLimits[3]) { // PMD Fix: CollapsibleIfStatements
+                        maxY = xyChart.getRenderer().getYAxisMax();
+                        minY = xyChart.getRenderer().getYAxisMin();
                     }
 
                     if (!xyChart.getRenderer().isZoomXEnabled()) {
@@ -894,7 +886,7 @@ private void zoomTransition(double minX, double maxX, double minY, double maxY,
     }
 
     private interface IZoomTransition {
-        public void start();
+        void start();
     }
 
     private class ZoomTransition implements Animation, IZoomTransition {

CodenameOne/src/com/codename1/charts/compat/GradientDrawable.java

@@ -39,7 +39,7 @@ public GradientDrawable(Orientation orientation, int[] colors) {
         this.colors = colors;
     }
 
-    public static enum Orientation {
+    public enum Orientation { // PMD Fix: UnnecessaryModifier removed redundant static
         BL_TR,
         BOTTOM_TOP,
         BR_TL,

CodenameOne/src/com/codename1/charts/compat/Paint.java

@@ -34,11 +34,10 @@
  * @author shannah
  * @deprecated
  */
-public class Paint {
+public class Paint { // PMD Fix: UnusedPrivateField removed redundant antiAlias flag
 
 
     static Graphics g;
-    private boolean antiAlias;
     private Font typeface = Font.createSystemFont(Font.FACE_SYSTEM, Font.STYLE_PLAIN, Font.SIZE_SMALL);
     private int strokeCap = Cap.BUTT;
     private int strokeJoin = Join.BEVEL;
@@ -154,7 +153,7 @@ public float measureText(char[] chars, int start, int count){
 
 
     public void setAntiAlias(boolean antialiasing) {
-        this.antiAlias = antialiasing;
+        // No-op for compatibility.
     }
 
     public Font getTypeface() {
@@ -209,7 +208,7 @@ public void setStrokeWidth(float i) {
 
 
 
-    public static enum Style {
+    public enum Style { // PMD Fix: UnnecessaryModifier removed redundant static
         FILL,
         FILL_AND_STROKE,
         STROKE

CodenameOne/src/com/codename1/charts/models/XYSeries.java

@@ -84,15 +84,14 @@ private void initRange() {
     mMaxX = MathHelper.NULL_VALUE;
     mMinY = MathHelper.NULL_VALUE;
     mMaxY = MathHelper.NULL_VALUE;
-    int length = getItemCount();
+    int length = getItemCount(); // PMD Fix: UnusedLocalVariable removed redundant loop index
     for (int k = 0; k < length; k++) {
       double x = getX(k);
       double y = getY(k);
       updateRange(x, y);
     }
 
-    int i=0;
-  }
+  }
 
   /**
    * Updates the range on both axes.

CodenameOne/src/com/codename1/charts/renderers/BasicStroke.java

@@ -51,12 +51,13 @@ public class BasicStroke {
    * @param intervals the path effect intervals
    * @param phase the path effect phase
    */
-  public BasicStroke(int cap, int join, float miter, float[] intervals, float phase) {
-    mCap = cap;
-    mJoin = join;
-    mMiter = miter;
-    mIntervals = intervals;
-  }
+  public BasicStroke(int cap, int join, float miter, float[] intervals, float phase) {
+    mCap = cap;
+    mJoin = join;
+    mMiter = miter;
+    mIntervals = intervals;
+    mPhase = phase; // PMD Fix: UnusedFormalParameter store constructor argument
+  }
 
   /**
    * Returns the stroke cap.

CodenameOne/src/com/codename1/charts/renderers/DefaultRenderer.java

@@ -23,7 +23,7 @@
 /**
  * An abstract renderer to be extended by the multiple series classes.
  */
-public class DefaultRenderer {
+public class DefaultRenderer { // PMD Fix: UnusedPrivateField removed unused text font constant
   /** The chart title. */
   private String mChartTitle = "";
   /** The chart title text size. */
@@ -34,8 +34,6 @@ public class DefaultRenderer {
   public static final int BACKGROUND_COLOR = 0x0;
   /** The default color for text. */
   public static final int TEXT_COLOR = 0xEAEAEA;
-  /** A text font for regular text, like the chart labels. */
-  private static final Font REGULAR_TEXT_FONT = Font.createSystemFont(Font.FACE_SYSTEM, Font.STYLE_PLAIN, Font.SIZE_SMALL);
   /** The typeface name for the texts. */
   private int mTextTypefaceName = Font.FACE_SYSTEM;
   /** The typeface style for the texts. */

CodenameOne/src/com/codename1/charts/renderers/XYMultipleSeriesRenderer.java

@@ -121,9 +121,9 @@ public enum Orientation {
     /** The rotate angle. */
     private int mAngle = 0;
 
-    private Orientation(int angle) {
-      mAngle = angle;
-    }
+    Orientation(int angle) { // PMD Fix: UnnecessaryModifier removed implicit private keyword
+      mAngle = angle;
+    }
 
     /**
      * Return the orientation rotate angle.