Use Asciidoctor diagnostics for developer guide linting

Author: shai-almog

.github/workflows/developer-guide-docs.yml

@@ -84,26 +84,29 @@ jobs:
 
       - name: Install Asciidoctor tooling
         run: |
-          gem install --no-document asciidoctor asciidoctor-pdf asciidoctor-lint
+          gem install --no-document asciidoctor asciidoctor-pdf rouge
 
       - name: Run Asciidoctor lint
         run: |
           set -euo pipefail
           REPORT_DIR="build/developer-guide/reports"
           REPORT_FILE="${REPORT_DIR}/asciidoc-lint-report.txt"
           mkdir -p "$REPORT_DIR"
-          if ! command -v asciidoctor-lint >/dev/null 2>&1; then
-            echo "asciidoctor-lint is not available" >&2
-            exit 1
-          fi
           set +e
-          asciidoctor-lint docs/developer-guide/developer-guide.asciidoc | tee "$REPORT_FILE"
+          asciidoctor \
+            --require rouge \
+            --failure-level WARN \
+            --verbose \
+            --trace \
+            -o /dev/null \
+            docs/developer-guide/developer-guide.asciidoc \
+            2>&1 | tee "$REPORT_FILE"
           STATUS=${PIPESTATUS[0]}
           set -e
           echo "ASCII_DOC_LINT_REPORT=$REPORT_FILE" >> "$GITHUB_ENV"
           echo "ASCII_DOC_LINT_STATUS=$STATUS" >> "$GITHUB_ENV"
           if [ "$STATUS" -ne 0 ]; then
-            echo "asciidoctor-lint exited with status $STATUS" >&2
+            echo "Asciidoctor exited with status $STATUS" >&2
           fi
 
       - name: Build Developer Guide HTML and PDF

scripts/developer-guide/summarize_reports.py

@@ -80,7 +80,10 @@ def summarize_asciidoc(report: Path, status: str, summary_key: str, output: Path
     if report.is_file():
         text = report.read_text(encoding="utf-8", errors="ignore")
 
-    pattern = re.compile(r"^\s*[^:\n]+:\d+:\d+:\s+(ERROR|WARN(?:ING)?|INFO)\b", re.MULTILINE)
+    pattern = re.compile(
+        r"^\s*(?:[^:\n]+:\d+:\d+:\s+|asciidoctor:\s+)(ERROR|WARN(?:ING)?|INFO)\b",
+        re.MULTILINE,
+    )
     matches = pattern.findall(text)
 
     counts = {"error": 0, "warning": 0, "info": 0}
@@ -206,7 +209,7 @@ def parse_args() -> argparse.Namespace:
 
     ascii_parser = subparsers.add_parser(
         "ascii",
-        help="Summarize docToolchain AsciiDoc linter results.",
+        help="Summarize Asciidoctor diagnostics.",
         parents=[common],
     )
     ascii_parser.add_argument("--report", type=Path, required=True)