Run Java SE device-runner tests in PR CI (#4147)

* Add Java SE device runner tests to PR workflow

* Harden Java SE device runner test script

* Ensure simulator run is forcibly timed out

* Force-timeout Java SE simulator with log tailing

* Download JMF media jar for Java SE tests

* Improve Java SE device-runner handling

Author: shai-almog

.github/workflows/pr.yml

@@ -300,6 +300,20 @@ jobs:
     - name: Build Android Port
       run: ant -noinput -buildfile Ports/Android/build.xml jar
 
+    - name: Run Java SE device-runner tests
+      env:
+        ARTIFACTS_DIR: ${{ github.workspace }}/artifacts/desktop-device-runner
+      run: ./scripts/run-javase-device-tests.sh
+
+    - name: Upload Java SE device-runner artifacts
+      if: ${{ always() }}
+      uses: actions/upload-artifact@v4
+      with:
+        name: javase-device-runner
+        path: artifacts/desktop-device-runner
+        if-no-files-found: warn
+        retention-days: 14
+
     - name: Packaging Everything
       run: zip -j result.zip CodenameOne/javadocs.zip CodenameOne/dist/CodenameOne.jar CodenameOne/updatedLibs.zip Ports/JavaSE/dist/JavaSE.jar build/CodenameOneDist/CodenameOne/demos/CodenameOne_SRC.zip
 

scripts/run-javase-device-tests.sh

@@ -0,0 +1,242 @@
+#!/usr/bin/env bash
+# Run Codename One device-runner tests on the Java SE (desktop) target
+set -euo pipefail
+
+jd_log() { echo "[run-javase-device-tests] $1"; }
+ensure_dir() { mkdir -p "$1" 2>/dev/null || true; }
+download_file() {
+  local url="$1" dest="$2"
+  curl -fL --retry 3 --retry-delay 2 --connect-timeout 10 -o "$dest" "$url"
+}
+
+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+REPO_ROOT="$(cd "$SCRIPT_DIR/.." && pwd)"
+cd "$REPO_ROOT"
+
+CN1SS_HELPER_SOURCE_DIR="$SCRIPT_DIR/android/tests"
+if [ ! -f "$CN1SS_HELPER_SOURCE_DIR/Cn1ssChunkTools.java" ]; then
+  jd_log "CN1SS helper sources not found at $CN1SS_HELPER_SOURCE_DIR" >&2
+  exit 2
+fi
+
+source "$SCRIPT_DIR/lib/cn1ss.sh"
+cn1ss_log() { jd_log "$1"; }
+
+if [ -z "${JAVA_BIN:-}" ]; then
+  if [ -n "${JAVA_HOME_17_X64:-}" ] && [ -x "$JAVA_HOME_17_X64/bin/java" ]; then
+    JAVA_BIN="$JAVA_HOME_17_X64/bin/java"
+  elif [ -n "${JAVA_HOME_17:-}" ] && [ -x "$JAVA_HOME_17/bin/java" ]; then
+    JAVA_BIN="$JAVA_HOME_17/bin/java"
+  else
+    JAVA_BIN="$(command -v java || true)"
+  fi
+fi
+
+if [ -z "$JAVA_BIN" ]; then
+  jd_log "java binary not found on PATH" >&2
+  exit 2
+fi
+
+JAVA_VERSION_RAW="$($JAVA_BIN -version 2>&1 | head -n1 | sed -E 's/.*version \"([^\"]+)\".*/\1/' || true)"
+JAVA_VERSION_MAJOR="${JAVA_VERSION_RAW%%.*}"
+if [ "$JAVA_VERSION_MAJOR" = "1" ]; then
+  JAVA_VERSION_MAJOR="$(echo "$JAVA_VERSION_RAW" | cut -d. -f2)"
+fi
+
+if [ -z "$JAVA_VERSION_MAJOR" ] || [ "$JAVA_VERSION_MAJOR" -lt 17 ]; then
+  jd_log "Java 17 or newer is required for CN1SS helpers (detected: ${JAVA_VERSION_RAW:-unknown})" >&2
+  exit 2
+fi
+
+JAVAC_BIN="${JAVAC_BIN:-${JAVA_BIN%/*}/javac}"
+if [ -z "$JAVAC_BIN" ] || [ ! -x "$JAVAC_BIN" ]; then
+  JAVAC_BIN="$(command -v javac || true)"
+fi
+if [ -z "$JAVAC_BIN" ] || [ ! -x "$JAVAC_BIN" ]; then
+  jd_log "javac binary not found" >&2
+  exit 2
+fi
+
+JAVAC_VERSION_RAW="$($JAVAC_BIN -version 2>&1 | head -n1 | sed -E 's/.* ([0-9]+(\.[0-9]+)*).*/\1/' || true)"
+JAVAC_VERSION_MAJOR="${JAVAC_VERSION_RAW%%.*}"
+if [ "$JAVAC_VERSION_MAJOR" = "1" ]; then
+  JAVAC_VERSION_MAJOR="$(echo "$JAVAC_VERSION_RAW" | cut -d. -f2)"
+fi
+
+if [ -z "$JAVAC_VERSION_MAJOR" ] || [ "$JAVAC_VERSION_MAJOR" -lt 17 ]; then
+  jd_log "Java 17 or newer is required for compilation (javac detected: ${JAVAC_VERSION_RAW:-unknown})" >&2
+  exit 2
+fi
+
+CN1SS_JAVAC_BIN="$JAVAC_BIN"
+
+if ! command -v python3 >/dev/null 2>&1; then
+  jd_log "python3 binary not found" >&2
+  exit 2
+fi
+
+cn1ss_setup "$JAVA_BIN" "$CN1SS_HELPER_SOURCE_DIR"
+
+CN1_HOME_DIR="${HOME}/.codenameone"
+CN1_MEDIA_JAR="$CN1_HOME_DIR/jmf-2.1.1e.jar"
+CN1_MEDIA_JAR_URL="https://github.com/codenameone/cn1-binaries/raw/refs/heads/master/javase/jmf-2.1.1e.jar"
+
+jd_log "Ensuring Java SE media libraries are available"
+ensure_dir "$CN1_HOME_DIR"
+if [ ! -f "$CN1_MEDIA_JAR" ]; then
+  jd_log "Downloading JMF media support to $CN1_MEDIA_JAR"
+  download_file "$CN1_MEDIA_JAR_URL" "$CN1_MEDIA_JAR"
+else
+  jd_log "Using cached media jar at $CN1_MEDIA_JAR"
+fi
+
+ARTIFACTS_DIR_BASE="${ARTIFACTS_DIR:-${GITHUB_WORKSPACE:-$REPO_ROOT}/artifacts}"
+ARTIFACTS_DIR="${ARTIFACTS_DIR_BASE%/}/desktop-device-runner"
+ensure_dir "$ARTIFACTS_DIR"
+LOG_FILE="$ARTIFACTS_DIR/javase-device-runner.log"
+SCREENSHOT_DIR="$ARTIFACTS_DIR/screenshots"
+PREVIEW_DIR="$ARTIFACTS_DIR/previews"
+ensure_dir "$SCREENSHOT_DIR"
+ensure_dir "$PREVIEW_DIR"
+
+jd_log "Ensuring Java SE port is built"
+ant -noinput -buildfile Ports/JavaSE/build.xml jar
+
+CN1_CLASSPATH="CodenameOne/dist/CodenameOne.jar:Ports/JavaSE/dist/JavaSE.jar:Ports/CLDC11/dist/CLDC11.jar"
+if [ -d "Ports/JavaSE/dist/lib" ]; then
+  CN1_CLASSPATH+="$(printf ':%s' Ports/JavaSE/dist/lib/*)"
+fi
+
+BUILD_DIR="$(mktemp -d "${TMPDIR:-/tmp}/cn1-javase-tests-XXXXXX" 2>/dev/null || echo "${TMPDIR:-/tmp}/cn1-javase-tests")"
+SRC_ROOT="$SCRIPT_DIR/device-runner-app"
+MAIN_SRC="$SRC_ROOT/main"
+TEST_SRC="$SRC_ROOT/tests"
+
+if [ ! -d "$MAIN_SRC" ] || [ ! -d "$TEST_SRC" ]; then
+  jd_log "Device runner sources missing under $SRC_ROOT" >&2
+  exit 2
+fi
+
+mkdir -p "$BUILD_DIR/src"
+rsync -a "$MAIN_SRC/" "$BUILD_DIR/src/"
+rsync -a "$TEST_SRC/" "$BUILD_DIR/src/"
+
+jd_log "Compiling device-runner application sources"
+find "$BUILD_DIR/src" -name '*.java' -print0 | xargs -0 "$JAVAC_BIN" -cp "$CN1_CLASSPATH" -d "$BUILD_DIR/classes"
+
+SIM_TIMEOUT_SECONDS=${SIM_TIMEOUT_SECONDS:-420}
+SIM_KILL_GRACE_SECONDS=${SIM_KILL_GRACE_SECONDS:-30}
+JAVA_CMD=(xvfb-run -a "$JAVA_BIN" \
+  -cp "$CN1_CLASSPATH:$BUILD_DIR/classes" \
+  com.codename1.impl.javase.Simulator com.codenameone.examples.hellocodenameone.HelloCodenameOne)
+
+run_with_timeout() {
+  python3 - "$@" <<'PY'
+import os
+import signal
+import subprocess
+import sys
+
+def kill_process_group(proc, sig):
+    try:
+        os.killpg(proc.pid, sig)
+    except ProcessLookupError:
+        pass
+
+def main():
+    if len(sys.argv) < 4:
+        raise SystemExit(2)
+    timeout_seconds = int(sys.argv[1])
+    kill_grace = int(sys.argv[2])
+    log_path = sys.argv[3]
+    cmd = sys.argv[4:]
+    with open(log_path, 'ab', buffering=0) as log_file:
+        proc = subprocess.Popen(
+            cmd,
+            stdout=log_file,
+            stderr=subprocess.STDOUT,
+            preexec_fn=os.setsid,
+        )
+        try:
+            proc.wait(timeout=timeout_seconds)
+            sys.exit(proc.returncode)
+        except subprocess.TimeoutExpired:
+            kill_process_group(proc, signal.SIGTERM)
+            try:
+                proc.wait(timeout=kill_grace)
+            except subprocess.TimeoutExpired:
+                kill_process_group(proc, signal.SIGKILL)
+                proc.wait()
+            sys.exit(124)
+
+if __name__ == '__main__':
+    main()
+PY
+}
+
+jd_log "Launching Java SE simulator for device-runner app"
+: >"$LOG_FILE"
+set +e
+run_with_timeout "$SIM_TIMEOUT_SECONDS" "$SIM_KILL_GRACE_SECONDS" "$LOG_FILE" "${JAVA_CMD[@]}"
+rc=$?
+set -e
+
+if [ $rc -ne 0 ]; then
+  jd_log "Simulator exited with status $rc (see log at $LOG_FILE)"
+fi
+
+SIM_EXIT_CODE=$rc
+
+TEST_NAMES_RAW="$(cn1ss_list_tests "$LOG_FILE" 2>/dev/null | awk 'NF' | sort -u || true)"
+declare -a TEST_NAMES=()
+if [ -n "$TEST_NAMES_RAW" ]; then
+  while IFS= read -r name; do
+    [ -n "$name" ] || continue
+    TEST_NAMES+=("$name")
+  done <<< "$TEST_NAMES_RAW"
+else
+  TEST_NAMES+=("default")
+fi
+
+jd_log "Detected CN1SS test streams: ${TEST_NAMES[*]}"
+
+declare -a SOURCES=("LOG:$LOG_FILE")
+
+for test in "${TEST_NAMES[@]}"; do
+  png_dest="$SCREENSHOT_DIR/${test}.png"
+  if cn1ss_decode_test_png "$test" "$png_dest" "${SOURCES[@]}"; then
+    jd_log "Decoded screenshot for '$test' -> $png_dest"
+  else
+    jd_log "No screenshot payload detected for '$test'"
+    rm -f "$png_dest" 2>/dev/null || true
+  fi
+
+  preview_dest="$PREVIEW_DIR/${test}.jpg"
+  if cn1ss_decode_test_preview "$test" "$preview_dest" "${SOURCES[@]}"; then
+    jd_log "Decoded preview for '$test' -> $preview_dest"
+  else
+    rm -f "$preview_dest" 2>/dev/null || true
+  fi
+
+done
+
+if [ "$SIM_EXIT_CODE" -eq 124 ]; then
+  screenshot_count=$(find "$SCREENSHOT_DIR" -maxdepth 1 -type f -name '*.png' | wc -l | tr -d '[:space:]')
+  if [ "${screenshot_count:-0}" -gt 0 ]; then
+    jd_log "Simulator timed out but CN1SS artifacts were captured; marking run as successful"
+    SIM_EXIT_CODE=0
+  fi
+fi
+
+# Emit a simple summary for debugging
+SUMMARY_FILE="$ARTIFACTS_DIR/summary.txt"
+{
+  echo "Simulator exit code: $SIM_EXIT_CODE"
+  echo "Log file: $LOG_FILE"
+  echo "Screenshots:"
+  find "$SCREENSHOT_DIR" -maxdepth 1 -type f -name '*.png' -printf '  - %f\n' 2>/dev/null || true
+} > "$SUMMARY_FILE"
+
+jd_log "Desktop device-runner artifacts stored in $ARTIFACTS_DIR"
+
+exit $SIM_EXIT_CODE