Fix SpotBugs UC_USELESS_CONDITION warnings and enforce check in CI

Fixed multiple instances of 'Condition has no effect' (UC_USELESS_CONDITION) in core classes including Grid, MenuBar, MathUtil, Component, and others. Updated generate-quality-report.py to treat this violation as a build failure.

Author: google-labs-jules[bot]

CodenameOne/src/com/codename1/impl/CodenameOneImplementation.java

@@ -7448,7 +7448,8 @@ public int getCommandBehavior() {
      */
     public void setCommandBehavior(int commandBehavior) {
         // PMD Fix (CollapsibleIfStatements): Combine touch capability and behavior checks.
-        if (!isTouchDevice() && commandBehavior == Display.COMMAND_BEHAVIOR_BUTTON_BAR) {
+        boolean touch = isTouchDevice();
+        if (!touch && commandBehavior == Display.COMMAND_BEHAVIOR_BUTTON_BAR) {
             commandBehavior = Display.COMMAND_BEHAVIOR_SOFTKEY;
         }
         this.commandBehavior = commandBehavior;

CodenameOne/src/com/codename1/ui/html/ResourceThreadQueue.java

@@ -540,9 +540,8 @@ void handleImage(Image img, Component cmp, boolean bgUnselected, boolean bgSelec
                     height = img.getHeight() * width / img.getWidth();
                 }
             } else if (height != 0) {
-                if (width == 0) { // If only height was specified, width should be calculated so the image keeps its aspect ratio
-                    width = img.getWidth() * height / img.getHeight();
-                }
+                // If only height was specified, width should be calculated so the image keeps its aspect ratio
+                width = img.getWidth() * height / img.getHeight();
             }
 
             if (width != 0) { // if any of width or height were not 0, the other one was set to non-zero above, so this check suffices

CodenameOne/src/com/codename1/util/MathUtil.java

@@ -928,7 +928,7 @@ private static final double ieee754_asin(double x) {
             q = pio4_hi - 2.0 * w;
             t = pio4_hi - (p - q);
         }
-        if (hx > 0) {
+        if (x > 0) {
             return t;
         } else {
             return -t;