Merge branch 'master' into codex/task-title

Author: shai-almog

.github/workflows/developer-guide-docs.yml

@@ -114,6 +114,20 @@ jobs:
             echo "REV_HUMAN_DATE=$REV_HUMAN_DATE"
           } >> "$GITHUB_ENV"
 
+      - name: Determine Codename One release version
+        run: |
+          set -euo pipefail
+          VERSION="$(python3 scripts/developer-guide/determine_release_version.py)"
+          if [ -z "$VERSION" ]; then
+            echo "Unable to determine Codename One release version" >&2
+            exit 1
+          fi
+          echo "Using Codename One release version: $VERSION" >&2
+          {
+            echo "CN1_RELEASE_VERSION=$VERSION"
+            echo "CN1_PLUGIN_RELEASE_VERSION=$VERSION"
+          } >> "$GITHUB_ENV"
+
       - name: Render publication cover artwork
         run: |
           set -euo pipefail

CodenameOne/src/com/codename1/contacts/ContactsModel.java

@@ -46,7 +46,7 @@ public class ContactsModel extends DefaultListModel {
      * @param ids the contact ids we would like this model to handle
      */
     public ContactsModel(String... ids) {
-        super(ids);
+        super((Object[]) ids);
     }
 
     /**

CodenameOne/src/com/codename1/ui/spinner/Picker.java

@@ -187,7 +187,7 @@ public void actionPerformed(ActionEvent evt) {
                                 gs.setRenderingPrototype((String) renderingPrototype);
                             }
                             String[] strArr = (String[]) metaData;
-                            gs.setModel(new DefaultListModel(strArr));
+                            gs.setModel(new DefaultListModel((Object[]) strArr));
                             if (value != null) {
                                 int slen = strArr.length;
                                 for (int iter = 0; iter < slen; iter++) {

CodenameOne/src/com/codename1/ui/util/UIBuilder.java

@@ -1415,7 +1415,7 @@ private Component createComponent(DataInputStream in, Container parent, Containe
                         items[iter] = in.readUTF();
                     }
                     if (!setListModel(((List) cmp))) {
-                        ((List) cmp).setModel(new DefaultListModel(items));
+                        ((List) cmp).setModel(new DefaultListModel((Object[]) items));
                     }
                     break;
 

Ports/Android/src/com/codename1/impl/android/AndroidAsyncView.java

@@ -409,7 +409,10 @@ public void run() {
         pendingRenderingOperations = tmp;
         try {
             for (AsyncOp o : renderingOperations) {
-                o.prepare();
+                // can happen due to synchronization issues see: https://www.reddit.com/r/cn1/comments/1oo43in/error_while_using_app/
+                if (o != null) {
+                    o.prepare();
+                }
             }
         } catch (java.util.ConcurrentModificationException ex) {
             // This is a race condition that sometimes occurs

docs/developer-guide/About-This-Guide.asciidoc

@@ -17,7 +17,7 @@ While this guide focuses on tutorial and conceptual material, the complete API r
 
 This document includes content from multiple authors and community wiki edits. If you edit pages within the guide feel free to add your name here alphabetized by surname:
 
-- https://github.com/codenameone/[Shai Almog]
+- https://github.com/shai-almog[Shai Almog]
 - https://github.com/Isborg[Ismael Baum]
 - https://twitter.com/ericcoolmandev[Eric Coolman]
 - http://github.com/chen-fishbein/[Chen Fishbein]

docs/developer-guide/Index.asciidoc

@@ -39,6 +39,8 @@ IMPORTANT: Codename One doesn't send source code to the build cloud, only compil
 
 The build servers allow building native iOS Apps without a Mac and native Windows apps without a Windows machine. They remove the need to install/update complex toolchains and simplify the process of building a native app to a right click.
 
+Even though the build servers streamline delivery, Codename One also supports fully local builds. You can install the toolchain on your own hardware and follow the workflows in <<maven-project-workflow>> and <<working-with-codename-one-sources>> to compile, package, and test apps without leaving your desktop environment.
+
 E.g.: Since building native iOS applications requires a Mac OS X machine with a recent version of xcode Codename One maintains such machines in the cloud. When developers send an iOS build such a Mac will be used to generate C source code using https://github.com/codenameone/CodenameOne/tree/master/vm[ParparVM] and it will then compile the C source code using xcode & sign the resulting binary using xcode. You can install the binary to your device or build a distribution binary for the appstore. Since C code is generated it also means that your app will be "future proof" in a case of changes from Apple. You can also inject Objective-C native code into the app while keeping it 100% portable thanks to the "native interfaces" capability of Codename One.
 
 Subscribers can receive the C source code back using the include sources feature of Codename One and use those sources for benchmarking, debugging on devices etc.

docs/developer-guide/Maven-Getting-Started.adoc

@@ -76,9 +76,9 @@ The https://shannah.github.io/cn1app-archetype-kotlin-template/getting-started.h
 
 Here is an example which generates a project based on the bare-bones kotlin template:
 
-[source,bash]
+[source,bash,subs="+attributes"]
 ----
-mvn com.codenameone:codenameone-maven-plugin:7.0.19:generate-app-project \
+mvn com.codenameone:codenameone-maven-plugin:{cn1-plugin-release-version}:generate-app-project \
   -DarchetypeGroupId=$archetypeGroupId \
   -DarchetypeArtifactId=$archetypeArtifactId \
   -DarchetypeVersion=$archetypeVersion \
@@ -96,7 +96,7 @@ Like the `archetype:generate` goal, this will create the project in a directory
 
 Some notes here:
 
-. The `com.codenameone:codenameone-maven-plugin:7.0.19:generate-app-project` argument is the fully-qualified goal name for the `generate-app-project`.  This is necessary since we aren't running this goal in the context of any existing project.  You should adjust the version number (`7.0.19`) to reflect the https://search.maven.org/search?q=a:codenameone-maven-plugin[latest available Codename One version on Maven Central].
+. The `com.codenameone:codenameone-maven-plugin:{cn1-plugin-release-version}:generate-app-project` argument is the fully-qualified goal name for the `generate-app-project`.  This is necessary since we aren't running this goal in the context of any existing project.  You should adjust the version number (`{cn1-plugin-release-version}`) to reflect the https://search.maven.org/search?q=a:codenameone-maven-plugin[latest available Codename One version on Maven Central].
 . The `archetypeGroupId`, `archetypeArtifactId`, and `archetypeVersion` parameters are the same as when using the `archetype:generate` goal, and they will (almost) always refer to the <<cn1app-archetype>>.
 . The `groupId`, `artifactId`, and `version` work the same as for the `archetype:generate` goal.  That is, that they specify the coordinates for your newly created project.
 . The `mainName` specifies the Main class name for your app.  This is just the class name, and should not include the full package.  E.g. "MyApp", not "com.example.MyApp"
@@ -116,12 +116,12 @@ If you have an existing Codename One application project that uses the old Ant p
 
 A minimal invocation of this goal would look like:
 
-[source,bash]
+[source,bash,subs="+attributes"]
 ----
 # Specify your the version of the codenameone-maven-plugin.
 # Find the latest version at
 # https://search.maven.org/search?q=a:codenameone-maven-plugin
-CN1VERSION=7.0.19
+CN1VERSION={cn1-plugin-release-version}
 mvn com.codenameone:codenameone-maven-plugin:$CN1VERSION:generate-app-project \
   -DgroupId=YOUR_GROUP_ID \
   -DartifactId=YOUR_ARTIFACT_ID \
@@ -137,7 +137,7 @@ After building the project, try running it to make sure that the migration worke
 
 ==== Command Line
 
-[source,bash]
+[source,bash,subs="+attributes"]
 ----
 cd myapp
 ./run.sh
@@ -210,9 +210,9 @@ Let's consider a concrete example, now.  Download the KitchenSink Ant project fr
 
 The following is a bash script that uses curl to download this project as a zip file, and then converts it to a fully-functional Maven project.
 
-[source,bash]
+[source,bash,subs="+attributes"]
 ----
-CN1_VERSION=7.0.19
+CN1_VERSION={cn1-plugin-release-version}
 curl -L https://github.com/codenameone/KitchenSink/archive/v1.0-cn7.0.11.zip > master.zip
 unzip master.zip
 rm master.zip

docs/developer-guide/Maven-Project-Workflow.asciidoc

@@ -8,8 +8,5 @@ include::Maven-Getting-Started.adoc[leveloffset=+1]
 include::Maven-Updating-Codename-One.adoc[leveloffset=+1]
 include::Maven-Project-Templates.adoc[leveloffset=+1]
 include::Maven-Creating-CN1Libs.adoc[leveloffset=+1]
-include::Maven-Appendix-Archetypes.adoc[leveloffset=+1]
-include::Maven-Appendix-Goals.adoc[leveloffset=+1]
-include::Maven-Appendix-API.adoc[leveloffset=+1]
-include::Maven-Appendix-Control-Center.adoc[leveloffset=+1]
-include::Maven-Appendix-Rich-Properties.adoc[leveloffset=+1]
+
+// The detailed Maven appendices now live alongside the other appendices at the end of the guide.

docs/developer-guide/Maven-Updating-Codename-One.adoc

@@ -48,10 +48,10 @@ You can also update your Codename One dependencies manually by modifying the `cn
 
 E.g. Open the `pom.xml` file, and look for the following:
 
-[source,xml]
+[source,xml,subs="+attributes"]
 ----
-<cn1.plugin.version>7.0.19</cn1.plugin.version>
-<cn1.version>7.0.19</cn1.version>
+<cn1.plugin.version>{cn1-plugin-release-version}</cn1.plugin.version>
+<cn1.version>{cn1-release-version}</cn1.version>
 ----
 
 Change these values to reflect the latest version of the `codenameone-maven-plugin` found https://search.maven.org/artifact/com.codenameone/codenameone-maven-plugin[here].