Fix Spotbugs warnings: Add final modifier to constant fields (#4317)

* Fix Spotbugs warnings: Add final modifier to constant fields

This commit resolves multiple "Field isn't final but should be" warnings identified by Spotbugs. The `final` modifier has been added to the following fields:

- `ColorUtil`: `LTGRAY`, `BLUE`, `BLACK`, `WHITE`, `CYAN`, `GREEN`, `YELLOW`, `MAGENTA`, `GRAY`
- `Cookie`: `STORAGE_NAME`
- `Log`: `REPORTING_NONE`, `REPORTING_DEBUG`, `REPORTING_PRODUCTION`
- `JavascriptContext`: `jsLookupTable`
- `LocationRequest`: `PRIORITY_HIGH_ACCUARCY`, `PRIORITY_MEDIUM_ACCUARCY`, `PRIORITY_LOW_ACCUARCY`
- `DocumentInfo`: `TYPE_HTML`, `TYPE_IMAGE`, `TYPE_CSS`
- `PlatformDefaults`: `VISUAL_PADDING_PROPERTY`

These fields are intended to be constants (or effectively final in the case of `jsLookupTable`) and enforcing immutability improves thread safety and code clarity. Existing typos in `LocationRequest` field names are preserved for backward compatibility.

* Fix Spotbugs warnings: Add final modifier to constant fields

This commit resolves multiple "Field isn't final but should be" warnings identified by Spotbugs. The `final` modifier has been added to the following fields:

- `ColorUtil`: `LTGRAY`, `BLUE`, `BLACK`, `WHITE`, `CYAN`, `GREEN`, `YELLOW`, `MAGENTA`, `GRAY`
- `Cookie`: `STORAGE_NAME`
- `Log`: `REPORTING_NONE`, `REPORTING_DEBUG`, `REPORTING_PRODUCTION`
- `JavascriptContext`: `DEBUG`
- `LocationRequest`: `PRIORITY_HIGH_ACCUARCY`, `PRIORITY_MEDIUM_ACCUARCY`, `PRIORITY_LOW_ACCUARCY`
- `DocumentInfo`: `TYPE_HTML`, `TYPE_IMAGE`, `TYPE_CSS`
- `PlatformDefaults`: `VISUAL_PADDING_PROPERTY`

These fields are intended to be constants (or effectively final in the case of `DEBUG`) and enforcing immutability improves thread safety and code clarity. Existing typos in `LocationRequest` field names are preserved for backward compatibility.

---------

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>

Author: google-labs-jules[bot]

CodenameOne/src/com/codename1/charts/util/ColorUtil.java

@@ -27,15 +27,15 @@
  * @author shannah
  */
 public class ColorUtil {
-    public static int LTGRAY = IColor.LightGray.argb;
-    public static int BLUE = IColor.Blue.argb;
-    public static int BLACK = IColor.Black.argb;
-    public static int WHITE = IColor.White.argb;
-    public static int CYAN = IColor.Cyan.argb;
-    public static int GREEN = IColor.Green.argb;
-    public static int YELLOW = IColor.Yellow.argb;
-    public static int MAGENTA = IColor.Magenta.argb;
-    public static int GRAY = IColor.Gray.argb;
+    public static final int LTGRAY = IColor.LightGray.argb;
+    public static final int BLUE = IColor.Blue.argb;
+    public static final int BLACK = IColor.Black.argb;
+    public static final int WHITE = IColor.White.argb;
+    public static final int CYAN = IColor.Cyan.argb;
+    public static final int GREEN = IColor.Green.argb;
+    public static final int YELLOW = IColor.Yellow.argb;
+    public static final int MAGENTA = IColor.Magenta.argb;
+    public static final int GRAY = IColor.Gray.argb;
 
 
     public static int argb(int a, int r, int g, int b) {

CodenameOne/src/com/codename1/io/Cookie.java

@@ -34,7 +34,7 @@
  * @author Shai Almog
  */
 public class Cookie implements Externalizable {
-    public static String STORAGE_NAME = "Cookies";
+    public static final String STORAGE_NAME = "Cookies";
     private static boolean autoStored = true;
 
     static {

CodenameOne/src/com/codename1/io/Log.java

@@ -76,15 +76,15 @@ public class Log {
     /**
      * Indicates that log reporting to the cloud should be disabled
      */
-    public static int REPORTING_NONE = 0;
+    public static final int REPORTING_NONE = 0;
     /**
      * Indicates that log reporting to the cloud should occur regardless of whether an error occurred
      */
-    public static int REPORTING_DEBUG = 1;
+    public static final int REPORTING_DEBUG = 1;
     /**
      * Indicates that log reporting to the cloud should occur only if an error occurred
      */
-    public static int REPORTING_PRODUCTION = 3;
+    public static final int REPORTING_PRODUCTION = 3;
     private static boolean crashBound;
     private static Log instance = new Log();
     private static boolean initialized;

CodenameOne/src/com/codename1/javascript/JavascriptContext.java

@@ -86,7 +86,7 @@ public class JavascriptContext {
     /**
      * Flag to enable/disable logging to a debug log.
      */
-    public static boolean DEBUG = false;
+    public static final boolean DEBUG = false;
     /**
      * Running counter to mark the context ID.  Each javascript context has its
      * own lookup table, and this running counter allows us to generate a unique

CodenameOne/src/com/codename1/location/LocationRequest.java

@@ -33,17 +33,17 @@ public class LocationRequest {
     /**
      * When you need gps location updates
      */
-    public static int PRIORITY_HIGH_ACCUARCY = 0;
+    public static final int PRIORITY_HIGH_ACCUARCY = 0;
 
     /**
      * When accuracy is not highly important and you want to save battery
      */
-    public static int PRIORITY_MEDIUM_ACCUARCY = 1;
+    public static final int PRIORITY_MEDIUM_ACCUARCY = 1;
 
     /**
      * When accuracy is not important and you want to save battery
      */
-    public static int PRIORITY_LOW_ACCUARCY = 2;
+    public static final int PRIORITY_LOW_ACCUARCY = 2;
 
     private int priority = PRIORITY_MEDIUM_ACCUARCY;
 

CodenameOne/src/com/codename1/ui/html/DocumentInfo.java

@@ -45,17 +45,17 @@ public class DocumentInfo {
     /**
      * Indicates that the request is for a page
      */
-    public static int TYPE_HTML = 0;
+    public static final int TYPE_HTML = 0;
 
     /**
      * Indicates that the request is for an image
      */
-    public static int TYPE_IMAGE = 1;
+    public static final int TYPE_IMAGE = 1;
 
     /**
      * Indicates that the request is for a CSS file
      */
-    public static int TYPE_CSS = 2;
+    public static final int TYPE_CSS = 2;
 
     private static String DEFAULT_ENCODING = ENCODING_ISO;
 

CodenameOne/src/com/codename1/ui/layouts/mig/PlatformDefaults.java

@@ -118,7 +118,7 @@ public final class PlatformDefaults {
      * to specify the visual padding.
      * <p>
      */
-    public static String VISUAL_PADDING_PROPERTY = "visualPadding";
+    public static final String VISUAL_PADDING_PROPERTY = "visualPadding";
     static BoundSize RELATED_X = null, RELATED_Y = null, UNRELATED_X = null, UNRELATED_Y = null;
     private static int DEF_H_UNIT = UnitValue.LPX;
     private static int DEF_V_UNIT = UnitValue.LPY;