Skip to content

Commit c7b8913

Browse files
Refactor instance inner classes to static to fix SpotBugs warnings.
1 parent bce5969 commit c7b8913

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

maven/core-unittests/src/test/java/com/codename1/components/RSSReaderCoverageTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ public void testBackCommand() {
2222
Assertions.assertEquals("Current", Display.getInstance().getCurrent().getTitle());
2323

2424
RSSReader reader = new RSSReader();
25-
RSSReader.BackCommand backCmd = reader.new BackCommand(previousForm);
25+
RSSReader.BackCommand backCmd = new RSSReader.BackCommand(previousForm);
2626

2727
backCmd.actionPerformed(new ActionEvent(backCmd));
2828

@@ -35,7 +35,7 @@ public void testBackCommand() {
3535
public void testListener() {
3636
RSSReader reader = new RSSReader();
3737
String testUrl = "https://www.example.com";
38-
RSSReader.Listener listener = reader.new Listener(testUrl);
38+
RSSReader.Listener listener = new RSSReader.Listener(testUrl);
3939

4040
listener.actionPerformed(new ActionEvent(reader));
4141

maven/core-unittests/src/test/java/com/codename1/components/WebBrowserTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ void testPropertyTypes() {
4141
void testLoadingInnerClass() {
4242
WebBrowser browser = new WebBrowser();
4343
com.codename1.ui.Form f = new com.codename1.ui.Form();
44-
WebBrowser.Loading loading = browser.new Loading(f);
44+
WebBrowser.Loading loading = new WebBrowser.Loading(f);
4545

4646
assertTrue(loading.animate());
4747

maven/core-unittests/src/test/java/com/codename1/io/Oauth2RefreshTokenRequestTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ public class Oauth2RefreshTokenRequestTest extends UITestBase {
99
@FormTest
1010
public void testRefreshTokenRequest() {
1111
// Just instantiate to cover the class definition
12-
Oauth2.RefreshTokenRequest req = new Oauth2("url", "id", "uri").new RefreshTokenRequest();
12+
Oauth2.RefreshTokenRequest req = new Oauth2.RefreshTokenRequest();
1313
Assertions.assertNotNull(req);
1414
}
1515
}

0 commit comments

Comments
 (0)