Fixed compilation issues and hardened build

Author: shai-almog

.github/scripts/generate-quality-report.py

@@ -787,7 +787,31 @@ def main() -> None:
             "EQ_GETCLASS_AND_CLASS_CONSTANT",
             "EQ_UNUSUAL",
             "ES_COMPARING_STRINGS_WITH_EQ",
-            "FI_EMPTY"
+            "FI_EMPTY",
+            "ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD",
+            "DM_GC",
+            "CN_IMPLEMENTS_CLONE_BUT_NOT_CLONEABLE",
+            "BC_UNCONFIRMED_CAST",
+            "BC_UNCONFIRMED_CAST_OF_RETURN_VALUE",
+            "CN_IDIOM_NO_SUPER_CALL",
+            "DM_BOOLEAN_CTOR",
+            "DM_CONVERT_CASE",
+            "DM_EXIT",
+            "EI_EXPOSE_REP",
+            "EI_EXPOSE_REP2",
+            "EI_EXPOSE_STATIC_REP2",
+            "EQ_COMPARETO_USE_OBJECT_EQUALS",
+            "MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR",
+            "MS_EXPOSE_REP",
+            "NM_CONFUSING",
+            "NO_NOTIFY_NOT_NOTIFYALL",
+            "NP_BOOLEAN_RETURN_NULL",
+            "PZLA_PREFER_ZERO_LENGTH_ARRAYS",
+            "REFLC_REFLECTION_MAY_INCREASE_ACCESSIBILITY_OF_CLASS",
+            "UI_INHERITANCE_UNSAFE_GETRESOURCE",
+            "URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD",
+            "UW_UNCOND_WAIT",
+            "SIC_INNER_SHOULD_BE_STATIC_ANON"
         }
         violations = [
             f for f in spotbugs.findings

CodenameOne/src/com/codename1/testing/TestUtils.java

@@ -1144,26 +1144,6 @@ private static void assertRelativeErrorExceeded(double expected, double actual,
         }
     }
 
-    private static void assertRelativeErrorNotExceeded(float expected, float actual, double maxRelativeError) {
-        if (verbose) {
-            log("assertRelativeErrorNotExceeded(" + expected + ", " + actual + ", " + maxRelativeError + ")");
-        }
-        double relative_error = Math.abs((expected - actual) / actual) * 100;
-        if (relative_error > maxRelativeError) {
-            assertBool(false);
-        }
-    }
-
-    private static void assertRelativeErrorNotExceeded(double expected, double actual, double maxRelativeError) {
-        if (verbose) {
-            log("assertRelativeErrorNotExceeded(" + expected + ", " + actual + ", " + maxRelativeError + ")");
-        }
-        double relative_error = Math.abs((expected - actual) / actual) * 100;
-        if (relative_error > maxRelativeError) {
-            assertBool(false);
-        }
-    }
-
     private static void assertRelativeErrorNotExceeded(float expected, float actual, double maxRelativeError, String errorMessage) {
         if (verbose) {
             log("assertRelativeErrorNotExceeded(" + expected + ", " + actual + ", " + maxRelativeError + ", " + errorMessage + ")");

CodenameOne/src/com/codename1/ui/BrowserComponent.java

@@ -290,13 +290,6 @@ public static boolean isNativeBrowserSupported() {
         return Display.impl.isNativeBrowserComponentSupported();
     }
 
-    private static boolean isNumber(Object o) {
-        if (o == null) {
-            return false;
-        }
-        Class c = o.getClass();
-        return c == Integer.class || c == Double.class || c == Float.class || c == Long.class || c == Short.class;
-    }
 
     /**
      * Injects parameters into a Javascript string expression.  This will quote strings properly.  The
@@ -548,13 +541,6 @@ private SuccessCallback<JSRef> popReturnValueCallback(int id) {
         return null;
     }
 
-    private JSONParser returnValueParser() {
-        if (returnValueParser == null) {
-            returnValueParser = new JSONParser();
-        }
-        return returnValueParser;
-    }
-
     @Override
     protected void initComponent() {
         super.initComponent();
@@ -1698,6 +1684,11 @@ public enum JSType {
         UNDEFINED("undefined"),
         BOOLEAN("boolean");
 
+        // values() doesn't work great on iOS builds
+        private static final JSType[] values = {
+                OBJECT, FUNCTION, NUMBER, STRING, UNDEFINED, BOOLEAN
+        };
+
         private final String typeOfValue;
 
         JSType(String val) {
@@ -1708,26 +1699,13 @@ public enum JSType {
          * Gets the corresponding JSType for the given string type.
          *
          * @param type The string type as returned by the typeof operator.  Possible input values are 'object', 'function', 'number', 'boolean', and 'undefined'
-         * @return
+         * @return the enum corresponding to the type
          */
         public static JSType get(String type) {
-            if ("object".equals(type)) {
-                return OBJECT;
-            }
-            if ("string".equals(type)) {
-                return JSType.STRING;
-            }
-            if ("number".equals(type)) {
-                return JSType.NUMBER;
-            }
-            if ("function".equals(type)) {
-                return JSType.FUNCTION;
-            }
-            if ("undefined".equals(type)) {
-                return JSType.UNDEFINED;
-            }
-            if ("boolean".equals(type)) {
-                return BOOLEAN;
+            for(JSType t : values) {
+                if(t.typeOfValue.equals(type)) {
+                    return t;
+                }
             }
             return UNDEFINED;
         }
@@ -1771,15 +1749,6 @@ public String getValue() {
             return value;
         }
 
-        /**
-         * Returns the type of the value
-         *
-         * @return
-         */
-        private String getType() {
-            return type;
-        }
-
         /**
          * Returns the type of the value.
          *

CodenameOne/src/com/codename1/ui/plaf/StyleParser.java

@@ -347,19 +347,6 @@ private static String getAlignmentString(Integer alignment) {
         return null;
     }
 
-    private static int getPixelValue(String val) {
-        ScalarValue v = parseSingleTRBLValue(val);
-        switch (v.getUnit()) {
-            case Style.UNIT_TYPE_PIXELS:
-                return (int) Math.round(v.getValue());
-            case Style.UNIT_TYPE_DIPS:
-                return Display.getInstance().convertToPixels((float) v.getValue());
-            case Style.UNIT_TYPE_SCREEN_PERCENTAGE:
-                return (int) Math.round(Display.getInstance().getDisplayWidth() * v.getValue() / 100.0);
-        }
-        return 0;
-    }
-
     private static float getMMValue(String val) {
         ScalarValue v = parseSingleTRBLValue(val);
         switch (v.getUnit()) {
@@ -623,10 +610,6 @@ private static Image getImage(Resources theme, String imageStr) {
         return im;
     }
 
-    static Integer parseTextDecoration(String decoration) {
-        return null;
-    }
-
     private static FontInfo parseFontSize(FontInfo out, String arg) {
         arg = arg.trim();
         ScalarValue sizeVal = parseSingleTRBLValue(arg);