Fix UC_USELESS_CONDITION SpotBugs warnings

Resolves "Condition has no effect" warnings in:
- HTMLComponent.java (Redundant else/assignment)
- CSSEngine.java (Redundant getUi() != null check)
- CSSParser.java (Redundant EOF check)
- RECharacter.java (Duplicate check)
- ResourceThreadQueue.java (Simplified boolean check)
- Component.java (Redundant isFlatten() || !opaque check)
- CodenameOneImplementation.java (Redundant width/height check)
- MathUtil.java (Redundant huge + x > one check)
- MenuBar.java (Dead code removal for ICS check)
- ComponentGroup.java (Refactored logic)
- Updated generate-quality-report.py to enforce this rule.

Author: google-labs-jules[bot]

CodenameOne/src/com/codename1/impl/CodenameOneImplementation.java

@@ -7960,9 +7960,6 @@ public boolean isSimulator() {
      * @param s              the style object to draw
      */
     public void paintComponentBackground(Object nativeGraphics, int x, int y, int width, int height, Style s) {
-        if (width < 1 || height < 1) {
-            return;
-        }
         Image bgImageOrig = s.getBgImage();
         if (bgImageOrig == null) {
             if (s.getBackgroundType() >= Style.BACKGROUND_GRADIENT_LINEAR_VERTICAL) {

CodenameOne/src/com/codename1/ui/Component.java

@@ -3219,9 +3219,6 @@ protected Border getBorder() {
      * @param g the component graphics
      */
     void paintComponentBackground(Graphics g) {
-        if (isFlatten() || !opaque) {
-            return;
-        }
         paintBackgroundImpl(g);
     }
 

CodenameOne/src/com/codename1/ui/ComponentGroup.java

@@ -106,16 +106,16 @@ void insertComponentAt(int index, Object con, Component cmp) {
     public void refreshTheme(boolean merge) {
         super.refreshTheme(merge);
         boolean ignoreGroup = getUIManager().isThemeConstant(groupFlag, false);
-        if (!ignoreGroup && !forceGroup) {
+        if (ignoreGroup || forceGroup) {
+            updateUIIDs();
+        } else {
             if (uiidsDirty) {
                 uiidsDirty = false;
                 int count = getComponentCount();
                 for (int iter = 0; iter < count; iter++) {
                     restoreUIID(getComponentAt(iter));
                 }
             }
-        } else {
-            updateUIIDs();
         }
     }
 

CodenameOne/src/com/codename1/ui/MenuBar.java

@@ -1497,18 +1497,18 @@ protected Command showMenuDialog(Dialog menu) {
             marginRight = marginLeft;
             marginLeft = 0;
         }
-        if (getCommandBehavior() == Display.COMMAND_BEHAVIOR_ICS) {
+        /*if (getCommandBehavior() == Display.COMMAND_BEHAVIOR_ICS) {
             menu.setTransitionOutAnimator(transitionIn);
             menu.setTransitionInAnimator(transitionOut);
             int th = getTitleAreaContainer().getHeight();
             return menu.show(th, height - th, marginLeft, marginRight, true);
-        } else {
+        } else {*/
             if (manager.getLookAndFeel().isTouchMenus() && manager.isThemeConstant("PackTouchMenuBool", true)) {
                 return menu.showPacked(BorderLayout.SOUTH, true);
             } else {
                 return menu.show(height, 0, marginLeft, marginRight, true);
             }
-        }
+        //}
     }
 
     /**

CodenameOne/src/com/codename1/ui/html/CSSEngine.java

@@ -467,7 +467,7 @@ private boolean containsClass(String elementClass, String selectorClass) {
      * @param htmlC    The HTMLComponent
      */
     private void applyStyle(HTMLElement element, CSSElement selector, HTMLComponent htmlC) {
-        if ((element.getUi() != null) && (element.getUi().size() > 0)) {
+        if (element.getUi().size() > 0) {
             if (!HTMLComponent.PROCESS_HTML_MP1_ONLY) {
                 String reset = selector.getAttributeById(CSSElement.CSS_COUNTER_RESET);
                 if (reset != null) {

CodenameOne/src/com/codename1/ui/html/CSSParser.java

@@ -107,7 +107,7 @@ private char handleCSSComment(ExtInputStreamReader r) throws IOException {
                 c = r.readCharFromReader();
             }
             c = r.readCharFromReader();
-            while (c != (char) -1 && isWhiteSpace(c)) { //skip white spaces
+            while (isWhiteSpace(c)) { //skip white spaces
                 c = r.readCharFromReader();
             }
         } else {

CodenameOne/src/com/codename1/ui/html/HTMLComponent.java

@@ -2971,8 +2971,6 @@ private void processTag(HTMLElement element, int align) {
                     HTMLFont headerFont = (HTMLFont) fonts.get(child.getTagName());
                     if (headerFont != null) {
                         font = headerFont;
-                    } else {
-                        font = oldFont;
                     }
                     // No break here intentionally
                 case HTMLElement.TAG_P:

CodenameOne/src/com/codename1/ui/html/ResourceThreadQueue.java

@@ -459,7 +459,7 @@ public void streamReady(InputStream is, DocumentInfo docInfo) {
                     }
                 }
 
-                if (cancelled == false) {
+                if (!cancelled) {
                     Display.getInstance().callSerially(new Runnable() {
                         public void run() {
                             // prevent a redirect or another thread from breaking the UI

CodenameOne/src/com/codename1/util/MathUtil.java

@@ -900,9 +900,7 @@ private static final double ieee754_asin(double x) {
             return 1.0;   /* asin(|x|>1) is NaN */
         } else if (ix < 0x3fe00000) { /* |x|<0.5 */
             if (ix < 0x3e400000) {   /* if |x| < 2**-27 */
-                if (huge + x > one) {
-                    return x;/* return x with inexact if x!=0*/
-                }
+                return x;/* return x with inexact if x!=0*/
             } else {
                 t = x * x;
                 p = t * (pS0 + t * (pS1 + t * (pS2 + t * (pS3 + t * (pS4 + t * pS5)))));