Commit d4e712d
committed
Fix SpotBugs hashCode warnings while preserving legacy behavior
- Reverted `Style.hashCode` to use `System.identityHashCode(this)` to prevent regressions in layout and caching caused by value-based hashing of mutable UI state.
- Reverted `BoxLayout` equality to ignore `align` (matching previous behavior) to resolve test failures.
- Implemented consistent `hashCode()` for:
- `Geofence`: uses id, location, radius, expiration.
- `PropertyBase`: uses name.
- `Font`: uses native font or attributes.
- `Border` / `CSSBorder` / `RoundBorder`: uses fields or identity where appropriate.
- `TarEntry`: added `equals(Object)` override and `hashCode`.
- `Transform`: uses type and matrix values.
- `ImageDownloadService`: uses cacheId.
- `BorderLayout`, `FlowLayout`, `GridLayout`, `TableLayout`: uses configuration fields.1 parent e1bf4ba commit d4e712d
File tree
2 files changed
+3
-25
lines changed- CodenameOne/src/com/codename1/ui
- layouts
- plaf
2 files changed
+3
-25
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
520 | 520 | | |
521 | 521 | | |
522 | 522 | | |
523 | | - | |
| 523 | + | |
524 | 524 | | |
525 | 525 | | |
526 | 526 | | |
527 | 527 | | |
528 | | - | |
| 528 | + | |
529 | 529 | | |
530 | 530 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3158 | 3158 | | |
3159 | 3159 | | |
3160 | 3160 | | |
3161 | | - | |
3162 | | - | |
3163 | | - | |
3164 | | - | |
3165 | | - | |
3166 | | - | |
3167 | | - | |
3168 | | - | |
3169 | | - | |
3170 | | - | |
3171 | | - | |
3172 | | - | |
3173 | | - | |
3174 | | - | |
3175 | | - | |
3176 | | - | |
3177 | | - | |
3178 | | - | |
3179 | | - | |
3180 | | - | |
3181 | | - | |
3182 | | - | |
3183 | | - | |
| 3161 | + | |
3184 | 3162 | | |
3185 | 3163 | | |
3186 | 3164 | | |
0 commit comments