Fix SpotBugs SIC_INNER_SHOULD_BE_STATIC Warnings (#4371)

* Refactor instance inner classes to static to fix SpotBugs warnings.

* Refactor instance inner classes to static to fix SpotBugs warnings.

* Refactor instance inner classes to static to fix SpotBugs warnings.

* Refactor instance inner classes to static to fix SpotBugs warnings.

* Refactor instance inner classes to static to fix SpotBugs warnings.

* Refactor instance inner classes to static to fix SpotBugs warnings.

---------

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>

Author: google-labs-jules[bot]

.github/scripts/generate-quality-report.py

@@ -774,7 +774,8 @@ def main() -> None:
             "UC_USELESS_CONDITION",
             "EC_UNRELATED_TYPES",
             "EQ_ALWAYS_FALSE",
-            "SBSC_USE_STRINGBUFFER_CONCATENATION"
+            "SBSC_USE_STRINGBUFFER_CONCATENATION",
+            "SIC_INNER_SHOULD_BE_STATIC"
         }
         violations = [
             f for f in spotbugs.findings

CodenameOne/src/com/codename1/charts/views/BarChart.java

@@ -390,7 +390,7 @@ public enum Type {
         DEFAULT, STACKED, HEAPED
     }
 
-    private class Point {
+    private static class Point {
         int seriesIndex;
         float yval;
     }

CodenameOne/src/com/codename1/components/RSSReader.java

@@ -454,7 +454,7 @@ public void setAddBackToTaget(boolean addBackToTaget) {
         this.addBackToTaget = addBackToTaget;
     }
 
-    class Listener implements ActionListener {
+    static class Listener implements ActionListener {
         private final String url;
 
         public Listener(String url) {
@@ -466,7 +466,7 @@ public void actionPerformed(ActionEvent evt) {
         }
     }
 
-    class BackCommand extends Command {
+    static class BackCommand extends Command {
         private final Form sourceForm;
 
         public BackCommand(Form sourceForm) {

CodenameOne/src/com/codename1/components/SignatureComponent.java

@@ -441,7 +441,7 @@ public Image getValue() {
      * The actual panel for drawing a signature.  This doesn't include any buttons (like done, reset, or cancel),
      * it merely provides the functionality to record the drawing of a signature.
      */
-    private class SignaturePanel extends Component {
+    private static class SignaturePanel extends Component {
 
         private final GeneralPath path = new GeneralPath();
         private final Stroke stroke = new Stroke();

CodenameOne/src/com/codename1/components/WebBrowser.java

@@ -446,7 +446,7 @@ public String setPropertyValue(String name, Object value) {
         return super.setPropertyValue(name, value);
     }
 
-    class Loading implements Painter, Animation {
+    static class Loading implements Painter, Animation {
 
         private final Form f;
 

CodenameOne/src/com/codename1/facebook/FaceBookAccess.java

@@ -1329,7 +1329,7 @@ public void cleanTempStorage() {
         }
     }
 
-    class Listener implements ActionListener {
+    static class Listener implements ActionListener {
         private final FacebookRESTService con;
         private final ActionListener callback;
 

CodenameOne/src/com/codename1/impl/CodenameOneImplementation.java

@@ -8820,7 +8820,7 @@ public String getStackTrace(Thread parentThread, Throwable t) {
         return "";
     }
 
-    class RPush implements Runnable {
+    static class RPush implements Runnable {
         public void run() {
             final long pushId = Preferences.get("push_id", (long) -1);
             if (pushId > -1 && callback != null) {

CodenameOne/src/com/codename1/io/ConnectionRequest.java

@@ -2938,7 +2938,7 @@ public enum CachingMode {
      * @see #setCheckSSLCertificates(boolean)
      * @see #checkSSLCertificates(com.codename1.io.ConnectionRequest.SSLCertificate[])
      */
-    public final class SSLCertificate {
+    public static final class SSLCertificate {
 
         private String certificateUniqueKey;
         private String certificateAlgorithm;

CodenameOne/src/com/codename1/io/Oauth2.java

@@ -662,7 +662,7 @@ private Hashtable getParamsFromURL(String url) {
         return retVal;
     }
 
-    public class RefreshTokenRequest extends AsyncResource<AccessToken> {
+    public static class RefreshTokenRequest extends AsyncResource<AccessToken> {
 
     }
 }

CodenameOne/src/com/codename1/io/gzip/Inflate.java

@@ -764,7 +764,7 @@ boolean inParsingHeader() {
         }
     }
 
-    class Return extends Exception {
+    static class Return extends Exception {
         int r;
 
         Return(int r) {