Skip to content

Commit db63aef

Browse files
Fix repeated conditional tests warnings and enforce rule in CI
Fixed RpC_REPEATED_CONDITIONAL_TEST violations in: - GridBagConstraints.java: Fixed copy-paste error in insets check - CSSBorder.java: Fixed redundant quote check - ImageViewer.java: Fixed logic in keyReleased method - Container.java: Simplified componentAt logic - Form.java: Removed redundant nested if check Updated generate-quality-report.py to enforce this rule.
1 parent b351252 commit db63aef

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

CodenameOne/src/com/codename1/ui/Form.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1462,11 +1462,9 @@ public Container getLayeredPane(Class c, boolean top) {
14621462
layeredPaneImpl.add(cnt);
14631463
} else {
14641464
if (componentCount > 0) {
1465-
if (componentCount > 0) {
1466-
Integer z = (Integer) children.get(0).getClientProperty(Z_INDEX_PROP);
1467-
if (z != null) {
1468-
zIndex = z.intValue();
1469-
}
1465+
Integer z = (Integer) children.get(0).getClientProperty(Z_INDEX_PROP);
1466+
if (z != null) {
1467+
zIndex = z.intValue();
14701468
}
14711469
}
14721470
layeredPaneImpl.addComponent(0, cnt);

0 commit comments

Comments
 (0)