Fix redundant git clone and build delays in setup-workspace.sh (#4290)

* Fix redundant profile activation in setup-workspace.sh

Explicitly disable the `download-cn1-binaries` Maven profile during the `setup-workspace.sh` script execution. The script already provisions these binaries externally and passes the path via `-Dcn1.binaries`, but the profile was still activating and attempting a redundant `git clone` into the target directory, causing concurrency errors (exit code 128) and significant delays.

* Optimize setup-workspace.sh performance

Enhance build performance in `scripts/setup-workspace.sh` by:
1. Adding `-T 1C` to Maven commands to enable parallel builds using one thread per core.
2. Adding `-Dmaven.javadoc.skip=true` and `-Dmaven.source.skip=true` to skip time-consuming and unnecessary documentation and source artifact generation during the workspace setup phase.
3. Explicitly disabling the `download-cn1-binaries` profile (`-P !download-cn1-binaries`) to prevent redundant `git clone` operations that were causing "Result: 128" errors and delays.

* Optimize setup-workspace.sh and trigger CI on changes

1. Optimize `scripts/setup-workspace.sh` build time by enabling parallel builds (`-T 1C`) and skipping unnecessary Javadoc/Source generation.
2. Fix "Result: 128" git errors by explicitly disabling the `download-cn1-binaries` profile (`-P !download-cn1-binaries`).
3. Fix "Stubber.jar not found" build failure by explicitly passing `-Dcn1.binaries="$CN1_BINARIES"` to Maven commands, ensuring the external binaries are located.
4. Update `.github/workflows/pr.yml` to trigger the PR CI workflow when `scripts/setup-workspace.sh` is modified, enabling validation of these changes.

* Fix Android port build script and PR CI triggers

1.  **Optimize `scripts/setup-workspace.sh`:**
    *   Enable parallel builds (`-T 1C`) for faster execution.
    *   Skip Javadoc and Source generation to save time.
    *   Explicitly disable the `download-cn1-binaries` profile (`-P !download-cn1-binaries`) to prevent redundant git operations and "Result: 128" errors.
    *   Pass `-Dcn1.binaries="$CN1_BINARIES"` to ensure the build can locate the pre-provisioned binaries.

2.  **Fix `scripts/build-android-port.sh`:**
    *   Apply the same fixes as above (disable download profile, pass binaries path, optimization flags) to resolve "Result: 128" errors during the Android port build stage.

3.  **Update `.github/workflows/pr.yml`:**
    *   Add `!scripts/setup-workspace.sh` to the `paths-ignore` list for both `push` and `pull_request` triggers. This ensures that changes to the setup script properly trigger the CI workflow for validation.

* Fix Android port build scripts and CI triggers

1.  **Optimize `scripts/setup-workspace.sh`**:
    *   Enable parallel Maven builds (`-T 1C`) for faster execution.
    *   Skip Javadoc and source generation (`-Dmaven.javadoc.skip=true`, `-Dmaven.source.skip=true`).
    *   Disable the `download-cn1-binaries` profile (`-P !download-cn1-binaries`) to prevent redundant cloning and "Result: 128" errors.
    *   Explicitly pass `-Dcn1.binaries="$CN1_BINARIES"` to ensure binaries are located correctly.

2.  **Fix `scripts/build-android-port.sh`**:
    *   Define `CN1_BINARIES` variable with fallback logic to prevent "unbound variable" errors.
    *   Apply the same Maven optimizations and profile deactivation as in `setup-workspace.sh` to resolve build failures.

3.  **Update `.github/workflows/pr.yml`**:
    *   Add `!scripts/setup-workspace.sh` to `paths-ignore` for both `push` and `pull_request` triggers to ensure CI runs when this script is modified.

---------

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>

Author: google-labs-jules[bot]

.github/workflows/pr.yml

@@ -8,6 +8,7 @@ on:
       - '.github/workflows/scripts-android.yml'
       - '.github/workflows/scripts-ios.yml'
       - 'scripts/**'
+      - '!scripts/setup-workspace.sh'
       - 'docs/**'
       - '**/*.md'
       - '.github/workflows/developer-guide-docs.yml'
@@ -20,6 +21,7 @@ on:
       - '.github/workflows/scripts-android.yml'
       - '.github/workflows/scripts-ios.yml'
       - 'scripts/**'
+      - '!scripts/setup-workspace.sh'
       - 'docs/**'
       - '**/*.md'
       - '.github/workflows/developer-guide-docs.yml'

scripts/build-android-port.sh

@@ -15,6 +15,13 @@ TMPDIR="${TMPDIR%/}"
 DOWNLOAD_DIR="${TMPDIR%/}/codenameone-tools"
 log "The DOWNLOAD_DIR is ${DOWNLOAD_DIR}"
 
+CN1_BINARIES_PARENT="$(cd .. && pwd -P)"
+CN1_BINARIES="${CN1_BINARIES_PARENT%/}/cn1-binaries"
+if [ ! -d "$CN1_BINARIES" ]; then
+    # Fallback to the maven build dir if the external one doesn't exist
+    CN1_BINARIES="$(pwd)/maven/target/cn1-binaries"
+fi
+
 ENV_DIR="$DOWNLOAD_DIR/tools"
 ENV_FILE="$ENV_DIR/env.sh"
 
@@ -119,9 +126,9 @@ run_maven() {
 
 BUILD_CLIENT="$HOME/.codenameone/CodeNameOneBuildClient.jar"
 if [ ! -f "$BUILD_CLIENT" ]; then
-  if ! run_maven -q -f maven/pom.xml cn1:install-codenameone "$@"; then
+  if ! run_maven -q -f maven/pom.xml -Dcn1.binaries="$CN1_BINARIES" -P !download-cn1-binaries cn1:install-codenameone "$@"; then
     [ -f maven/CodeNameOneBuildClient.jar ] && cp maven/CodeNameOneBuildClient.jar "$BUILD_CLIENT" || true
   fi
 fi
 
-run_maven -q -f maven/pom.xml -pl android -am -Dmaven.javadoc.skip=true -Djava.awt.headless=true clean install "$@"
+run_maven -q -f maven/pom.xml -pl android -am -Dcn1.binaries="$CN1_BINARIES" -P !download-cn1-binaries -T 1C -Dmaven.javadoc.skip=true -Dmaven.source.skip=true -Djava.awt.headless=true clean install "$@"

scripts/setup-workspace.sh

@@ -226,18 +226,21 @@ if [ ! -d "$CN1_BINARIES/.git" ]; then
 fi
 
 log "Building Codename One core modules"
-"$MAVEN_HOME/bin/mvn" -f maven/pom.xml -DskipTests -Djava.awt.headless=true -Dcn1.binaries="$CN1_BINARIES" -Dcodename1.platform=javase -P local-dev-javase,compile-android install "$@"
+"$MAVEN_HOME/bin/mvn" -f maven/pom.xml -T 1C -Dmaven.javadoc.skip=true -Dmaven.source.skip=true -DskipTests -Djava.awt.headless=true -Dcn1.binaries="$CN1_BINARIES" -Dcodename1.platform=javase -P local-dev-javase,compile-android,!download-cn1-binaries install "$@"
 
 log "Building Codename One Maven plugin"
 "$MAVEN_HOME/bin/mvn" -f maven/pom.xml \
   -pl codenameone-maven-plugin -am \
+  -T 1C -Dmaven.javadoc.skip=true -Dmaven.source.skip=true \
   -DskipTests -Djava.awt.headless=true \
+  -Dcn1.binaries="$CN1_BINARIES" \
+  -P !download-cn1-binaries \
   install "$@"
 
 BUILD_CLIENT="$HOME/.codenameone/CodeNameOneBuildClient.jar"
 log "Ensuring CodeNameOneBuildClient.jar is installed"
 if [ ! -f "$BUILD_CLIENT" ]; then
-  if ! "$MAVEN_HOME/bin/mvn" -f maven/pom.xml cn1:install-codenameone "$@"; then
+  if ! "$MAVEN_HOME/bin/mvn" -f maven/pom.xml -Dcn1.binaries="$CN1_BINARIES" -P !download-cn1-binaries cn1:install-codenameone "$@"; then
     log "Falling back to copying CodeNameOneBuildClient.jar"
     mkdir -p "$(dirname "$BUILD_CLIENT")"
     cp maven/CodeNameOneBuildClient.jar "$BUILD_CLIENT" || true
@@ -272,6 +275,6 @@ if [ "${skip_archetypes:-0}" -eq 0 ]; then
       log "Updating cn1-maven-archetypes version from $current_version to $CN1_VERSION to match local snapshot"
       "$MAVEN_HOME/bin/mvn" -q -B versions:set -DnewVersion="$CN1_VERSION" -DgenerateBackupPoms=false
     fi
-    "$MAVEN_HOME/bin/mvn" -DskipTests -DskipITs=true -Dinvoker.skip=true install
+    "$MAVEN_HOME/bin/mvn" -T 1C -DskipTests -DskipITs=true -Dinvoker.skip=true install
   ) || log "Archetype mvn install failed; continuing."
 fi