Fix SpotBugs UPM_UNCALLED_PRIVATE_METHOD violations

Removed unused private methods across multiple files in the CodenameOne core library to address SpotBugs warnings.
Updated .github/scripts/generate-quality-report.py to fail on future UPM_UNCALLED_PRIVATE_METHOD violations.

Author: google-labs-jules[bot]

CodenameOne/src/com/codename1/io/CacheMap.java

@@ -289,12 +289,6 @@ public Vector getKeysInCache() {
         return r;
     }
 
-    private Vector fetchFromStorageCache(int offset) {
-        Vector v = getStorageCacheContent();
-        Object[] arr = (Object[]) v.elementAt(offset);
-        return (Vector) Storage.getInstance().readObject("$CACHE$" + cachePrefix + arr[1].toString());
-    }
-
     /**
      * Clears the storage cache
      */

CodenameOne/src/com/codename1/io/ConnectionRequest.java

@@ -2732,10 +2732,6 @@ public void downloadImageToFileSystem(String file, SuccessCallback<Image> onSucc
         downloadImageToFileSystem(file, onSuccess, onFail, true);
     }
 
-    private void downloadImage(final SuccessCallback<Image> onSuccess, FailureCallback<Image> onFail) {
-        downloadImage(onSuccess, onFail, true);
-    }
-
     private void downloadImage(final SuccessCallback<Image> onSuccess, final FailureCallback<Image> onFail, boolean useCache) {
         setReadResponseForErrors(false);
         if (useCache) {

CodenameOne/src/com/codename1/payment/Purchase.java

@@ -746,51 +746,6 @@ public Receipt getFirstReceiptExpiringAfter(Date dt, String... skus) {
         return getFirstReceiptExpiringAfter(getReceipts(skus), dt, skus);
     }
 
-    /**
-     * Fetch receipts from IAP service synchronously.
-     *
-     * @param ifOlderThanMs If the current data is not older than this number of milliseconds
-     *                      then it will not attempt to fetch the receipts.
-     * @return true if data was successfully retrieved.  false otherwise.
-     */
-    private boolean loadReceiptsSync(long ifOlderThanMs) {
-        final boolean[] complete = new boolean[1];
-        final boolean[] success = new boolean[1];
-        loadReceipts(ifOlderThanMs, new SuccessCallback<Boolean>() {
-
-            public void onSucess(Boolean value) {
-                complete[0] = true;
-                success[0] = value;
-
-                synchronized (complete) {
-                    complete.notifyAll();
-                }
-
-            }
-
-        });
-
-        if (!complete[0]) {
-            Display.getInstance().invokeAndBlock(new Runnable() {
-
-                public void run() {
-                    while (!complete[0]) {
-                        synchronized (complete) {
-                            try {
-                                complete.wait();
-                            } catch (InterruptedException ex) {
-                                Thread.currentThread().interrupt();
-                                return;
-                            }
-                        }
-                    }
-                }
-
-            });
-        }
-        return success[0];
-    }
-
     /**
      * Indicates whether refunding is possible when the SKU is purchased
      *

CodenameOne/src/com/codename1/testing/TestUtils.java

@@ -52,6 +52,7 @@
 public class TestUtils {
     private static boolean verbose;
 
+    @SuppressWarnings("unused")
     private TestUtils() {
     }
 

CodenameOne/src/com/codename1/ui/BrowserComponent.java

@@ -290,14 +290,6 @@ public static boolean isNativeBrowserSupported() {
         return Display.impl.isNativeBrowserComponentSupported();
     }
 
-    private static boolean isNumber(Object o) {
-        if (o == null) {
-            return false;
-        }
-        Class c = o.getClass();
-        return c == Integer.class || c == Double.class || c == Float.class || c == Long.class || c == Short.class;
-    }
-
     /**
      * Injects parameters into a Javascript string expression.  This will quote strings properly.  The
      * expression should include placeholders for each parameter of the form ${0}, ${1}, etc..
@@ -548,13 +540,6 @@ private SuccessCallback<JSRef> popReturnValueCallback(int id) {
         return null;
     }
 
-    private JSONParser returnValueParser() {
-        if (returnValueParser == null) {
-            returnValueParser = new JSONParser();
-        }
-        return returnValueParser;
-    }
-
     @Override
     protected void initComponent() {
         super.initComponent();

CodenameOne/src/com/codename1/ui/Display.java

@@ -2456,15 +2456,6 @@ public boolean hasDragOccured() {
         return dragOccured;
     }
 
-    private int[] pointerEvent(int off, int[] event) {
-        int[] peX = new int[(event.length - 1) / 2];
-        int offset = 0;
-        for (int iter = off; iter < (event.length - 1); iter += 2) {
-            peX[offset] = event[iter];
-            offset++;
-        }
-        return peX;
-    }
 
     /**
      * Returns true for a case where the EDT has nothing at all to do

CodenameOne/src/com/codename1/ui/Graphics.java

@@ -553,18 +553,6 @@ public void drawArc(int x, int y, int width, int height, int startAngle, int arc
         impl.drawArc(nativeGraphics, xTranslate + x, yTranslate + y, width, height, startAngle, arcAngle);
     }
 
-    private void drawStringImpl(String str, int x, int y) {
-        // remove a commonly used trick to create a spacer label from the paint queue
-        if (str.length() == 0 || (str.length() == 1 && str.charAt(0) == ' ')) {
-            return;
-        }
-        if (!(current instanceof CustomFont)) {
-            impl.drawString(nativeGraphics, str, x + xTranslate, y + yTranslate);
-        } else {
-            current.drawString(this, str, x, y);
-        }
-    }
-
     /**
      * Draw a string using the current font and color in the x,y coordinates. The font is drawn
      * from the top position and not the baseline.

CodenameOne/src/com/codename1/ui/InputComponent.java

@@ -93,10 +93,6 @@ protected InputComponent() {
     }
 
     // varags calls are significantly slower in java
-    private static int max(int a, int b, int c) {
-        return Math.max(Math.max(a, b), c);
-    }
-
     private static int max(int a, int b, int c, int d) {
         return Math.max(Math.max(Math.max(a, b), c), d);
     }

CodenameOne/src/com/codename1/ui/LinearGradientPaint.java

@@ -85,17 +85,6 @@ public LinearGradientPaint(double startX, double startY, double endX, double end
         this.endY = endY;
     }
 
-    private static double findAngle(double x1, double y1, double x2, double y2) {
-        return MathUtil.atan((y2 - y1) / (x2 - x1));
-    }
-
-    private static double scaleX(double theta, double x) {
-        return x / Math.cos(theta);
-    }
-
-    private static double scaleY(double theta, double y) {
-        return y / Math.sin(theta);
-    }
 
     /**
      * Paints linear gradient in the given bounds.

CodenameOne/src/com/codename1/ui/TextSelection.java

@@ -655,11 +655,6 @@ private boolean isVerticallyCoveredByBounds(Component cmp, Rectangle bounds) {
         return false;
     }
 
-    private boolean shouldCoverToEndOfLine(Span span, Rectangle bounds) {
-        int spy = span.getBounds().getY();
-        int sph = span.getBounds().getHeight();
-        return spy + 2 * sph / 3 > bounds.getY() && spy + sph <= bounds.getY() + bounds.getHeight();
-    }
 
     private void updateSnappedSelectedBounds() {
         snappedSelectedBounds.setBounds(selectedBounds.getX(), selectedBounds.getY(), selectedBounds.getWidth(), selectedBounds.getHeight());