Skip to content

Commit e7d6d4e

Browse files
Enable Spotless verification for Android Port and add PR comments
- Added `spotless-maven-plugin` to `maven/android/pom.xml` configured for `Ports/Android/src`. - Updated `scripts/build-android-port.sh` to run `spotless:check` during build. - Updated `.github/workflows/scripts-android.yml` to generate and publish quality reports (including coverage) as a PR comment.
1 parent adebe5d commit e7d6d4e

File tree

3 files changed

+41
-1
lines changed

3 files changed

+41
-1
lines changed

.github/workflows/scripts-android.yml

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -154,10 +154,33 @@ jobs:
154154
compression-level: 6
155155
- name: Upload Android Jacoco coverage report
156156
if: always() && matrix.id == 'default'
157+
id: upload-quality-artifacts
157158
uses: actions/upload-artifact@v4
158159
with:
159160
name: android-jacoco-coverage
160161
path: artifacts/android-coverage-report
161162
if-no-files-found: warn
162163
retention-days: 14
163164
compression-level: 6
165+
- name: Generate quality report summary
166+
if: ${{ always() && matrix.id == 'default' }}
167+
env:
168+
QUALITY_REPORT_TARGET_DIRS: artifacts/android-coverage-report
169+
QUALITY_REPORT_SERVER_URL: ${{ github.server_url }}
170+
QUALITY_REPORT_REPOSITORY: ${{ github.repository }}
171+
QUALITY_REPORT_REF: ${{ github.event.pull_request.head.sha || github.sha }}
172+
JACOCO_REPORT_URL: ${{ steps.upload-quality-artifacts.outputs.artifact-url }}
173+
QUALITY_REPORT_TITLE: "✅ Android Quality Report"
174+
run: python3 .github/scripts/generate-quality-report.py
175+
- name: Publish quality report comment
176+
if: ${{ github.event_name == 'pull_request' && matrix.id == 'default' }}
177+
uses: actions/github-script@v7
178+
with:
179+
script: |
180+
const { publishQualityComment } = require('./.github/scripts/publish-quality-comment.js');
181+
await publishQualityComment({
182+
github,
183+
context,
184+
core,
185+
marker: '<!-- android-quality-report -->'
186+
});

maven/android/pom.xml

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,23 @@
3535

3636
<build>
3737
<sourceDirectory>${src.dir}</sourceDirectory>
38+
<plugins>
39+
<plugin>
40+
<groupId>com.diffplug.spotless</groupId>
41+
<artifactId>spotless-maven-plugin</artifactId>
42+
<version>2.43.0</version>
43+
<configuration>
44+
<java>
45+
<includes>
46+
<include>${project.basedir}/../../Ports/Android/src/**/*.java</include>
47+
</includes>
48+
<googleJavaFormat>
49+
<version>1.17.0</version>
50+
</googleJavaFormat>
51+
</java>
52+
</configuration>
53+
</plugin>
54+
</plugins>
3855
</build>
3956

4057
<profiles>

scripts/build-android-port.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,4 +131,4 @@ if [ ! -f "$BUILD_CLIENT" ]; then
131131
fi
132132
fi
133133

134-
run_maven -q -f maven/pom.xml -pl android -am -Dcn1.binaries="$CN1_BINARIES" -P !download-cn1-binaries -T 1C -Dmaven.javadoc.skip=true -Dmaven.source.skip=true -Djava.awt.headless=true clean install "$@"
134+
run_maven -q -f maven/pom.xml -pl android -am -Dcn1.binaries="$CN1_BINARIES" -P !download-cn1-binaries -T 1C -Dmaven.javadoc.skip=true -Dmaven.source.skip=true -Djava.awt.headless=true clean install spotless:check "$@"

0 commit comments

Comments
 (0)