Mark utility classes final and gate PMD (#4423)

Author: shai-almog

.github/scripts/generate-quality-report.py

@@ -895,6 +895,18 @@ def _is_exempt(f: Finding) -> bool:
                 print(f"  - {v.rule}: {v.location} - {v.message}")
             exit(1)
 
+    pmd = parse_pmd()
+    if pmd:
+        forbidden_pmd_rules = {
+            "ClassWithOnlyPrivateConstructorsShouldBeFinal",
+        }
+        violations = [f for f in pmd.findings if f.rule in forbidden_pmd_rules]
+        if violations:
+            print("\n❌ Build failed due to forbidden PMD violations:")
+            for v in violations:
+                print(f"  - {v.rule}: {v.location} - {v.message}")
+            exit(1)
+
 
 if __name__ == "__main__":
     main()

CodenameOne/src/com/codename1/charts/util/MathHelper.java

@@ -26,7 +26,7 @@
 /**
  * Utility class for math operations.
  */
-public class MathHelper {
+public final class MathHelper {
     /** A value that is used a null value. */
     public static final double NULL_VALUE = -Double.MAX_VALUE + 1;
     /**

CodenameOne/src/com/codename1/components/ClearableTextField.java

@@ -39,7 +39,7 @@
  *
  * @author Shai Almog
  */
-public class ClearableTextField extends Container {
+public final class ClearableTextField extends Container {
     private ClearableTextField() {
         super(new BorderLayout());
     }

CodenameOne/src/com/codename1/components/FileEncodedImage.java

@@ -41,7 +41,7 @@
  *
  * @author Shai Almog
  */
-public class FileEncodedImage extends EncodedImage {
+public final class FileEncodedImage extends EncodedImage {
     private final String fileName;
     private final boolean keep;
     private byte[] data;

CodenameOne/src/com/codename1/components/FileEncodedImageAsync.java

@@ -41,7 +41,7 @@
  *
  * @author Shai Almog
  */
-public class FileEncodedImageAsync extends EncodedImage {
+public final class FileEncodedImageAsync extends EncodedImage {
     private static final Object LOCK = new Object();
     private final String fileName;
     private boolean changePending;

CodenameOne/src/com/codename1/components/InfiniteScrollAdapter.java

@@ -49,7 +49,7 @@
  *
  * @author Shai Almog
  */
-public class InfiniteScrollAdapter {
+public final class InfiniteScrollAdapter {
     private Container infiniteContainer;
     private Runnable fetchMore;
     private final Component ip;

CodenameOne/src/com/codename1/components/ReplaceableImage.java

@@ -32,7 +32,7 @@
  *
  * @author Shai Almog
  */
-public class ReplaceableImage extends EncodedImage {
+public final class ReplaceableImage extends EncodedImage {
     private boolean replaced;
     private byte[] data;
     private final boolean opaque;

CodenameOne/src/com/codename1/components/StorageImage.java

@@ -36,7 +36,7 @@
  *
  * @author Shai Almog
  */
-public class StorageImage extends EncodedImage {
+public final class StorageImage extends EncodedImage {
     private final String fileName;
     private final boolean keep;
     private byte[] data;

CodenameOne/src/com/codename1/components/StorageImageAsync.java

@@ -34,7 +34,7 @@
  *
  * @author Shai Almog
  */
-public class StorageImageAsync extends EncodedImage {
+public final class StorageImageAsync extends EncodedImage {
     private static final Object LOCK = new Object();
     private final String fileName;
     private boolean changePending;

CodenameOne/src/com/codename1/components/ToastBar.java

@@ -82,7 +82,7 @@
  *
  * @author shannah
  */
-public class ToastBar {
+public final class ToastBar {
 
     /**
      * The default timeout for info/error messages