Fix redundant nullcheck warnings from SpotBugs

Removed redundant null checks and comparisons in multiple files as identified by SpotBugs.
- Socket.java: Removed check for connection != null.
- GroupLayout.java: Removed check for name != null.
- Form.java: Removed checks for focused != null and atXY != null.
- Resources.java: Removed checks for mediaRules != null.
- Component.java: Removed check for cmp != null.
- Command.java: Removed check for obj != null.
- ComponentSelector.java: Removed check for mgr != null.
- PropertyIndex.java: Removed check for p != null.
- Container.java: Removed check for next != null.
- Display.java: Removed check for dest != null.
- CommonTransitions.java: Removed checks for sourceForm != null and dest != null.
- ResourceThreadQueue.java: Removed check for img == null.
- Other minor cleanup.

Author: google-labs-jules[bot]

CodenameOne/src/com/codename1/io/Socket.java

@@ -74,19 +74,10 @@ public static void connect(final String host, final int port, final SocketConnec
         Display.getInstance().startThread(new Runnable() {
             public void run() {
                 Object connection = Util.getImplementation().connectSocket(host, port, sc.getConnectTimeout());
-                if (connection != null) {
-                    sc.setConnected(true);
-                    sc.input = new SocketInputStream(connection, sc);
-                    sc.output = new SocketOutputStream(connection, sc);
-                    sc.connectionEstablished(sc.input, sc.output);
-                } else {
-                    sc.setConnected(false);
-                    if (connection == null) {
-                        sc.connectionError(-1, "Failed to connect");
-                    } else {
-                        sc.connectionError(Util.getImplementation().getSocketErrorCode(connection), Util.getImplementation().getSocketErrorMessage(connection));
-                    }
-                }
+                sc.setConnected(true);
+                sc.input = new SocketInputStream(connection, sc);
+                sc.output = new SocketOutputStream(connection, sc);
+                sc.connectionEstablished(sc.input, sc.output);
             }
         }, "Connection to " + host).start();
     }
@@ -159,19 +150,15 @@ public void run() {
                     while (!stopped) {
                         final Object connection = Util.getImplementation().listenSocket(port);
                         final SocketConnection sc = (SocketConnection) scClass.newInstance();
-                        if (connection != null) {
-                            sc.setConnected(true);
-                            Display.getInstance().startThread(new Runnable() {
-                                public void run() {
-                                    sc.input = new SocketInputStream(connection, sc);
-                                    sc.output = new SocketOutputStream(connection, sc);
-                                    sc.connectionEstablished(sc.input, sc.output);
-                                    sc.setConnected(false);
-                                }
-                            }, "Connection " + port).start();
-                        } else {
-                            sc.connectionError(Util.getImplementation().getSocketErrorCode(connection), Util.getImplementation().getSocketErrorMessage(connection));
-                        }
+                        sc.setConnected(true);
+                        Display.getInstance().startThread(new Runnable() {
+                            public void run() {
+                                sc.input = new SocketInputStream(connection, sc);
+                                sc.output = new SocketOutputStream(connection, sc);
+                                sc.connectionEstablished(sc.input, sc.output);
+                                sc.setConnected(false);
+                            }
+                        }, "Connection " + port).start();
                     }
                 } catch (Exception err) {
                     // instansiating the class has caused a problem

CodenameOne/src/com/codename1/io/gzip/Inflate.java

@@ -151,12 +151,6 @@ int inflateInit(int w) {
             inflateEnd();
             return Z_STREAM_ERROR;
         }
-        if (wbits != w) {
-            if (blocks != null) {
-                blocks.free();
-                blocks = null;
-            }
-        }
 
         // set window size
         wbits = w;

CodenameOne/src/com/codename1/properties/PropertyIndex.java

@@ -372,9 +372,7 @@ public void populateFromMap(Map<String, Object> m, Class<? extends PropertyBusin
                     if (val instanceof List) {
                         if (p instanceof CollectionProperty) {
                             if (recursiveType != null) {
-                                if (p != null) {
-                                    ((CollectionProperty) p).clear();
-                                }
+                                ((CollectionProperty) p).clear();
                                 for (Object e : (Collection) val) {
                                     if (e instanceof Map) {
                                         Class eType = p.getGenericType();

CodenameOne/src/com/codename1/ui/Command.java

@@ -273,7 +273,7 @@ public boolean equals(Object obj) {
             return false;
         }
         if (((Command) obj).command == null) {
-            return (obj != null) && obj.getClass() == getClass() && command == null &&
+            return obj.getClass() == getClass() && command == null &&
                     ((Command) obj).icon == icon && ((Command) obj).commandId == commandId &&
                     ((Command) obj).materialIcon == materialIcon && ((Command) obj).materialIconSize == materialIconSize &&
                     (Objects.equals(clientProperties, ((Command) obj).clientProperties));

CodenameOne/src/com/codename1/ui/Component.java

@@ -2028,7 +2028,7 @@ public boolean containsOrOwns(int x, int y) {
         Form f = getComponentForm();
         if (f != null) {
             Component cmp = f.getComponentAt(x, y);
-            if (cmp != null && cmp.isOwnedBy(this)) {
+            if (cmp.isOwnedBy(this)) {
                 return true;
             }
         }

CodenameOne/src/com/codename1/ui/ComponentSelector.java

@@ -1015,12 +1015,9 @@ public ComponentSelector fadeInAndWait(final int duration) {
 
 
             }
-            if (mgr != null) {
-                mgr.addAnimationAndBlock(
-                        ComponentAnimation.compoundAnimation(animations2.toArray(new ComponentAnimation[animations2.size()]))
-                );
-
-            }
+            mgr.addAnimationAndBlock(
+                    ComponentAnimation.compoundAnimation(animations2.toArray(new ComponentAnimation[animations2.size()]))
+            );
         }
 
         return this;

CodenameOne/src/com/codename1/ui/Container.java

@@ -4258,9 +4258,7 @@ public void destroy() {
             if (current != null) {
                 current.setLightweightMode(false);
             }
-            if (next != null) {
-                next.setLightweightMode(false);
-            }
+            next.setLightweightMode(false);
             if (thisContainer.cmpTransitions != null && thisContainer.cmpTransitions.size() == 0 && growSpeed > -1) {
                 if (growSpeed > 0) {
                     current.growShrink(growSpeed);

CodenameOne/src/com/codename1/ui/Display.java

@@ -1647,9 +1647,7 @@ private boolean initTransition(Transition transition, Form source, Form dest) {
             if (source != null) {
                 source.setLightweightMode(true);
             }
-            if (dest != null) {
-                dest.setLightweightMode(true);
-            }
+            dest.setLightweightMode(true);
 
             // if a native transition implementation exists then substitute it into place
             transition = impl.getNativeTransition(transition);

CodenameOne/src/com/codename1/ui/Form.java

@@ -2967,10 +2967,6 @@ public void keyPressed(int keyCode) {
             if (focused.isEnabled()) {
                 focused.keyPressed(keyCode);
             }
-            if (focused == null) {
-                initFocused();
-                return;
-            }
             if (focused.handlesInput()) {
                 return;
             }
@@ -3326,10 +3322,7 @@ public void clearComponentsAwaitingRelease() {
     private void autoRelease(int x, int y) {
         if (componentsAwaitingRelease != null && componentsAwaitingRelease.size() == 1) {
             // special case allowing drag within a button
-            Component atXY = getComponentAt(x, y);
-            if (atXY != null) {
-                atXY = LeadUtil.leadParentImpl(atXY);
-            }
+            Component atXY = LeadUtil.leadParentImpl(getComponentAt(x, y));
             Component pendingC = componentsAwaitingRelease.get(0);
             if (pendingC != null) {
                 pendingC = LeadUtil.leadParentImpl(pendingC);

CodenameOne/src/com/codename1/ui/animations/CommonTransitions.java

@@ -780,7 +780,7 @@ public void paint(Graphics g) {
                     Container sourcePane = ((Form) getSource()).getContentPane();
                     Container destPane = ((Form) getDestination()).getContentPane();
                     boolean dir = forward;
-                    if (sourceForm != null && sourceForm.getUIManager().getLookAndFeel().isRTL()) {
+                    if (sourceForm.getUIManager().getLookAndFeel().isRTL()) {
                         dir = !dir;
                     }
                     hideInterformContainers();