Skip to content

Conversation

@shai-almog
Copy link
Collaborator

Summary

  • include the local notification device test in the CN1SS device runner suite

Testing

  • not run (not requested)

Codex Task

@chatgpt-codex-connector
Copy link

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@shai-almog
Copy link
Collaborator Author

shai-almog commented Dec 17, 2025

Android screenshot updates

Compared 30 screenshots: 27 matched, 3 updated.

  • MediaPlayback — updated screenshot. Screenshot differs (320x616 px, bit depth 8).

    MediaPlayback
    Preview info: JPEG preview quality 70; JPEG preview quality 70.
    Full-resolution PNG saved as MediaPlayback.png in workflow artifacts.

  • graphics-draw-arc — updated screenshot. Screenshot differs (320x616 px, bit depth 8).

    graphics-draw-arc
    Preview info: JPEG preview quality 70; JPEG preview quality 70.
    Full-resolution PNG saved as graphics-draw-arc.png in workflow artifacts.

  • landscape — updated screenshot. Screenshot differs (640x296 px, bit depth 8).

    landscape
    Preview info: Preview provided by instrumentation.
    Full-resolution PNG saved as landscape.png in workflow artifacts.

Native Android coverage

  • 📊 Line coverage: 25.13% (2681/10667 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
    • Other counters: instruction 24.67% (12418/50336), branch 15.24% (707/4640), complexity 17.49% (738/4220), method 32.95% (598/1815), class 34.65% (105/303)
    • Lowest covered classes
      • com.codename1.impl.android.com.codename1.impl.android.AndroidContactsManager – 0.00% (0/400 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$Video – 0.00% (0/168 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.IntentIntegrator – 0.00% (0/139 lines covered)
      • com.codename1.impl.android.util.com.codename1.impl.android.util.Base64 – 0.00% (0/117 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$SocketImpl – 0.00% (0/77 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.AndroidTextureView – 0.00% (0/76 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.AndroidSurfaceView – 0.00% (0/73 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.FridaDetectionUtil – 0.00% (0/64 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.AndroidDB – 0.00% (0/57 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.PushNotificationService – 0.00% (0/54 lines covered)

@shai-almog
Copy link
Collaborator Author

shai-almog commented Dec 17, 2025

iOS screenshot updates

Compared 4 screenshots: 0 matched, 4 updated.

  • graphics-draw-line — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

    graphics-draw-line
    Preview info: JPEG preview quality 70; JPEG preview quality 70; downscaled to 844x1835.
    Full-resolution PNG saved as graphics-draw-line.png in workflow artifacts.

  • graphics-draw-rect — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

    graphics-draw-rect
    Preview info: JPEG preview quality 70; JPEG preview quality 70; downscaled to 844x1835.
    Full-resolution PNG saved as graphics-draw-rect.png in workflow artifacts.

  • graphics-fill-round-rect — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

    graphics-fill-round-rect
    Preview info: JPEG preview quality 70; JPEG preview quality 70; downscaled to 844x1835.
    Full-resolution PNG saved as graphics-fill-round-rect.png in workflow artifacts.

  • kotlin — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

    kotlin
    Preview info: Preview provided by instrumentation.
    Full-resolution PNG saved as kotlin.png in workflow artifacts.

Benchmark Results

  • VM Translation Time: 316 seconds
  • Compilation Time: 66 seconds

@shai-almog shai-almog merged commit a98a485 into master Dec 17, 2025
8 checks passed
shai-almog added a commit that referenced this pull request Dec 17, 2025
shai-almog added a commit that referenced this pull request Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants