diff --git a/.github/scripts/generate-quality-report.py b/.github/scripts/generate-quality-report.py index de5014bb9f..76e49892d7 100755 --- a/.github/scripts/generate-quality-report.py +++ b/.github/scripts/generate-quality-report.py @@ -760,7 +760,8 @@ def main() -> None: forbidden_rules = { "RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE", "RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE", - "UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR" + "UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR", + "SF_SWITCH_NO_DEFAULT" } violations = [ f for f in spotbugs.findings diff --git a/CodenameOne/src/com/codename1/charts/transitions/SeriesTransition.java b/CodenameOne/src/com/codename1/charts/transitions/SeriesTransition.java index 2a22c7410d..1aa77812e5 100644 --- a/CodenameOne/src/com/codename1/charts/transitions/SeriesTransition.java +++ b/CodenameOne/src/com/codename1/charts/transitions/SeriesTransition.java @@ -111,6 +111,9 @@ protected void initTransition() { case EASING_IN_OUT: motion = Motion.createEaseInOutMotion(0, 100, getDuration()); break; + default: + motion = Motion.createLinearMotion(0, 100, getDuration()); + break; } motion.start(); } diff --git a/CodenameOne/src/com/codename1/cloud/CloudObject.java b/CodenameOne/src/com/codename1/cloud/CloudObject.java index 0f39d180bc..f7e1536a89 100644 --- a/CodenameOne/src/com/codename1/cloud/CloudObject.java +++ b/CodenameOne/src/com/codename1/cloud/CloudObject.java @@ -765,6 +765,8 @@ public void propertyChanged(Component source, String propertyName, Object oldVal status = STATUS_MODIFIED; CloudStorage.getInstance().save(CloudObject.this); break; + default: + break; } } }; diff --git a/CodenameOne/src/com/codename1/components/AudioRecorderComponent.java b/CodenameOne/src/com/codename1/components/AudioRecorderComponent.java index 7b20f415b5..71482c51ac 100644 --- a/CodenameOne/src/com/codename1/components/AudioRecorderComponent.java +++ b/CodenameOne/src/com/codename1/components/AudioRecorderComponent.java @@ -176,6 +176,8 @@ public void actionPerformed(ActionEvent evt) { pause.setEnabled(true); revalidateLater(); break; + default: + break; } } diff --git a/CodenameOne/src/com/codename1/components/InteractionDialog.java b/CodenameOne/src/com/codename1/components/InteractionDialog.java index b662426f77..c37c0b2ea9 100644 --- a/CodenameOne/src/com/codename1/components/InteractionDialog.java +++ b/CodenameOne/src/com/codename1/components/InteractionDialog.java @@ -492,7 +492,8 @@ private void disposeTo(int direction, final Runnable onFinish) { case Component.BOTTOM: setY(Display.getInstance().getDisplayHeight()); break; - + default: + break; } if (animateShow) { diff --git a/CodenameOne/src/com/codename1/components/SliderBridge.java b/CodenameOne/src/com/codename1/components/SliderBridge.java index 86e43be17c..2c142e4635 100644 --- a/CodenameOne/src/com/codename1/components/SliderBridge.java +++ b/CodenameOne/src/com/codename1/components/SliderBridge.java @@ -149,6 +149,8 @@ public void actionPerformed(ActionEvent evt) { s.setInfinite(true); } break; + default: + break; } } }); diff --git a/CodenameOne/src/com/codename1/components/ToastBar.java b/CodenameOne/src/com/codename1/components/ToastBar.java index d03c36c530..e21b309076 100644 --- a/CodenameOne/src/com/codename1/components/ToastBar.java +++ b/CodenameOne/src/com/codename1/components/ToastBar.java @@ -289,6 +289,9 @@ public void actionPerformed(NetworkEvent evt) { } else { s.setProgress(-1); } + break; + default: + break; } } }; diff --git a/CodenameOne/src/com/codename1/impl/CodenameOneImplementation.java b/CodenameOne/src/com/codename1/impl/CodenameOneImplementation.java index 5805eea316..c7b7e96581 100644 --- a/CodenameOne/src/com/codename1/impl/CodenameOneImplementation.java +++ b/CodenameOne/src/com/codename1/impl/CodenameOneImplementation.java @@ -2696,6 +2696,8 @@ protected boolean hasDragStarted(final int x, final int y) { startX = Math.min(startX, 2f); startY = Math.min(startY, 2f); break; + default: + break; } // have we passed the motion threshold on the X axis? @@ -5867,6 +5869,8 @@ public void actionPerformed(ActionEvent evt) { }); + break; + default: break; } } @@ -5926,6 +5930,8 @@ public boolean isGalleryTypeSupported(int type) { case Display.GALLERY_VIDEO: case Display.GALLERY_ALL: return true; + default: + break; } return false; } @@ -7970,24 +7976,6 @@ public void paintComponentBackground(Object nativeGraphics, int x, int y, int wi int iH = bgImageOrig.getHeight(); Object bgImage = bgImageOrig.getImage(); switch (s.getBackgroundType()) { - case Style.BACKGROUND_NONE: - if (s.getBgTransparency() != 0) { - setColor(nativeGraphics, s.getBgColor()); - fillRect(nativeGraphics, x, y, width, height, s.getBgTransparency()); - } - return; - case Style.BACKGROUND_IMAGE_SCALED: - if (isScaledImageDrawingSupported()) { - drawImage(nativeGraphics, bgImage, x, y, width, height); - } else { - if (iW != width || iH != height) { - bgImageOrig = bgImageOrig.scaled(width, height); - s.setBgImage(bgImageOrig, true); - bgImage = bgImageOrig.getImage(); - } - drawImage(nativeGraphics, bgImage, x, y); - } - return; case Style.BACKGROUND_IMAGE_SCALED_FILL: float r = Math.max(((float) width) / ((float) iW), ((float) height) / ((float) iH)); int bwidth = (int) (((float) iW) * r); @@ -8110,6 +8098,19 @@ public void paintComponentBackground(Object nativeGraphics, int x, int y, int wi case Style.BACKGROUND_GRADIENT_LINEAR_VERTICAL: case Style.BACKGROUND_GRADIENT_RADIAL: drawGradientBackground(s, nativeGraphics, x, y, width, height); + return; + default: + // Style.BACKGROUND_IMAGE_SCALED: + if (isScaledImageDrawingSupported()) { + drawImage(nativeGraphics, bgImage, x, y, width, height); + } else { + if (iW != width || iH != height) { + bgImageOrig = bgImageOrig.scaled(width, height); + s.setBgImage(bgImageOrig, true); + bgImage = bgImageOrig.getImage(); + } + drawImage(nativeGraphics, bgImage, x, y); + } } } } @@ -8129,6 +8130,13 @@ private void drawGradientBackground(Style s, Object nativeGraphics, int x, int y x, y, width, height, s.getBackgroundGradientRelativeX(), s.getBackgroundGradientRelativeY(), s.getBackgroundGradientRelativeSize()); return; + default: + // Style.BACKGROUND_NONE + if (s.getBgTransparency() != 0) { + setColor(nativeGraphics, s.getBgColor()); + fillRect(nativeGraphics, x, y, width, height, s.getBgTransparency()); + } + break; } setColor(nativeGraphics, s.getBgColor()); fillRect(nativeGraphics, x, y, width, height, s.getBgTransparency()); @@ -8237,6 +8245,8 @@ public void drawLabelComponent(Object nativeGraphics, int cmpX, int cmpY, int cm case Label.TOP: y = y + (cmpHeight - (topPadding + bottomPadding + ((icon != null) ? iconHeight + gap : 0) + fontHeight)) / 2; break; + default: + break; } break; case Component.CENTER: @@ -8266,6 +8276,8 @@ public void drawLabelComponent(Object nativeGraphics, int cmpX, int cmpY, int cm + ((icon != null) ? iconHeight + gap : 0) + fontHeight)) / 2; break; + default: + break; } break; case Component.RIGHT: @@ -8295,6 +8307,8 @@ public void drawLabelComponent(Object nativeGraphics, int cmpX, int cmpY, int cm + bottomPadding + ((icon != null) ? iconHeight + gap : 0) + fontHeight)) / 2; break; + default: + break; } break; default: @@ -8381,6 +8395,8 @@ public void drawLabelComponent(Object nativeGraphics, int cmpX, int cmpY, int cm drawImage(nativeGraphics, icon, x + iconStringWGap, y + fontHeight + gap); } break; + default: + break; } } setAlpha(nativeGraphics, alpha); @@ -8570,6 +8586,8 @@ private int reverseAlignForBidi(boolean rtl, int align) { return Component.LEFT; case Component.LEFT: return Component.RIGHT; + default: + break; } } return align; diff --git a/CodenameOne/src/com/codename1/io/NetworkManager.java b/CodenameOne/src/com/codename1/io/NetworkManager.java index f477b45395..c69f1d65ea 100644 --- a/CodenameOne/src/com/codename1/io/NetworkManager.java +++ b/CodenameOne/src/com/codename1/io/NetworkManager.java @@ -598,6 +598,9 @@ void addToQueue(@Async.Schedule ConnectionRequest request, boolean retry) { case ConnectionRequest.PRIORITY_REDUNDANT: addSortedToQueue(request, i); break; + default: + addSortedToQueue(request, i); + break; } LOCK.notify(); } @@ -877,6 +880,8 @@ private boolean runCurrentRequest(@Async.Execute ConnectionRequest req) { case ConnectionRequest.PRIORITY_REDUNDANT: Thread.currentThread().setPriority(Thread.MIN_PRIORITY); break; + default: + break; } if (progressListeners != null) { diff --git a/CodenameOne/src/com/codename1/l10n/SimpleDateFormat.java b/CodenameOne/src/com/codename1/l10n/SimpleDateFormat.java index ecb178d562..08c192702d 100644 --- a/CodenameOne/src/com/codename1/l10n/SimpleDateFormat.java +++ b/CodenameOne/src/com/codename1/l10n/SimpleDateFormat.java @@ -474,6 +474,8 @@ String format(Date source, StringBuilder toAppendTo) { v = ((calendar.get(Calendar.DAY_OF_WEEK) + 5) % 7) + 1; toAppendTo.append(leftPad(v, len)); break; + default: + break; } } return toAppendTo.toString(); @@ -615,6 +617,8 @@ public Date parse(String source) throws ParseException { // v % 7 + 1 calendar.set(Calendar.DAY_OF_WEEK, (v % 7) + 1); break; + default: + break; } if (s != null) { startIndex += s.length(); diff --git a/CodenameOne/src/com/codename1/properties/PropertyIndex.java b/CodenameOne/src/com/codename1/properties/PropertyIndex.java index 1280a5d6c1..0cf82a73e3 100644 --- a/CodenameOne/src/com/codename1/properties/PropertyIndex.java +++ b/CodenameOne/src/com/codename1/properties/PropertyIndex.java @@ -980,6 +980,8 @@ public void internalize(int version, DataInputStream in) throws IOException { ((MapProperty) pb).setMap((Map) data); } break; + default: + break; } } } diff --git a/CodenameOne/src/com/codename1/properties/UiBinding.java b/CodenameOne/src/com/codename1/properties/UiBinding.java index da8fd09d9b..2cfadbb0ac 100644 --- a/CodenameOne/src/com/codename1/properties/UiBinding.java +++ b/CodenameOne/src/com/codename1/properties/UiBinding.java @@ -796,6 +796,8 @@ public void assignTo(PropertyType value, Picker cmp) { cmp.setSelectedString((String) toComponentType.convert(value)); } break; + default: + break; } } @@ -812,8 +814,9 @@ public PropertyType getFrom(Picker cmp) { return (PropertyType) Integer.valueOf(cmp.getSelectedStringIndex()); } return (PropertyType) toPropertyType.convert(cmp.getSelectedString()); + default: + throw new RuntimeException("Illegal state for picker binding"); } - throw new RuntimeException("Illegal state for picker binding"); } @Override diff --git a/CodenameOne/src/com/codename1/push/PushBuilder.java b/CodenameOne/src/com/codename1/push/PushBuilder.java index 303ae2bebe..d90b28a9dd 100644 --- a/CodenameOne/src/com/codename1/push/PushBuilder.java +++ b/CodenameOne/src/com/codename1/push/PushBuilder.java @@ -183,6 +183,8 @@ public String build() { case 102: sb.append(badge).append(";").append(title).append(";").append(body); break; + default: + break; } if (isRichPush()) { diff --git a/CodenameOne/src/com/codename1/ui/Button.java b/CodenameOne/src/com/codename1/ui/Button.java index de0dfef0fe..4dad66f706 100644 --- a/CodenameOne/src/com/codename1/ui/Button.java +++ b/CodenameOne/src/com/codename1/ui/Button.java @@ -631,6 +631,8 @@ public Image getIconFromState() { } } break; + default: + break; } return icon; } @@ -1004,6 +1006,8 @@ public boolean animate() { case STATE_PRESSED: a |= pressedIcon != null && pressedIcon.isAnimation() && pressedIcon.animate(); break; + default: + break; } } return a; diff --git a/CodenameOne/src/com/codename1/ui/Component.java b/CodenameOne/src/com/codename1/ui/Component.java index c1b000017d..ed2eab8b74 100644 --- a/CodenameOne/src/com/codename1/ui/Component.java +++ b/CodenameOne/src/com/codename1/ui/Component.java @@ -2441,7 +2441,8 @@ int calculateShadowOffsetX(int elevation) { return dp2px(-42); case 24: return dp2px(-65); - + default: + break; } return 0; } @@ -2658,7 +2659,8 @@ public void run() { //drawShadow(g, img, relativeX, relativeY, 0, 9, 46, 8, 0, 0.12f); //drawShadow(g, img, relativeX, relativeY, 0, 11, 15, -7, 0, 0.2f); break; - + default: + break; } synchronized (this) { cachedShadowImage = shadowImage; diff --git a/CodenameOne/src/com/codename1/ui/Container.java b/CodenameOne/src/com/codename1/ui/Container.java index 3e2b9a8d6b..c41ed0cd4f 100644 --- a/CodenameOne/src/com/codename1/ui/Container.java +++ b/CodenameOne/src/com/codename1/ui/Container.java @@ -2675,6 +2675,8 @@ boolean moveScrollTowards(int direction, Component next) { x = 0; } break; + default: + break; } f.setCyclicFocus(cyclic); //if the Form doesn't contain a focusable Component simply move the @@ -4023,6 +4025,8 @@ public java.util.List getChildrenAsList(boolean includeQueued) { case QueuedChange.TYPE_REMOVE: out.remove(change.component); break; + default: + break; } } } diff --git a/CodenameOne/src/com/codename1/ui/Display.java b/CodenameOne/src/com/codename1/ui/Display.java index 32ac0f93d6..a7d4c30668 100644 --- a/CodenameOne/src/com/codename1/ui/Display.java +++ b/CodenameOne/src/com/codename1/ui/Display.java @@ -2295,6 +2295,8 @@ private int handleEvent(int offset, int[] inputEventStackTmp) { offset++; } break; + default: + break; case POINTER_PRESSED: if (recursivePointerReleaseA) { recursivePointerReleaseB = true; diff --git a/CodenameOne/src/com/codename1/ui/Sheet.java b/CodenameOne/src/com/codename1/ui/Sheet.java index df04899d07..837c6d5de5 100644 --- a/CodenameOne/src/com/codename1/ui/Sheet.java +++ b/CodenameOne/src/com/codename1/ui/Sheet.java @@ -618,6 +618,8 @@ private void updateBorderForPosition() { b.bottomLeftMode(true); b.bottomRightMode(true); break; + default: + break; } getStyle().setBorder(b); diff --git a/CodenameOne/src/com/codename1/ui/Slider.java b/CodenameOne/src/com/codename1/ui/Slider.java index af6fc4c68a..689e8f3aa7 100644 --- a/CodenameOne/src/com/codename1/ui/Slider.java +++ b/CodenameOne/src/com/codename1/ui/Slider.java @@ -641,6 +641,8 @@ public void keyPressed(int code) { fireClicked(); } break; + default: + break; } } else { if (!Display.getInstance().isThirdSoftButton() && diff --git a/CodenameOne/src/com/codename1/ui/SwipeableContainer.java b/CodenameOne/src/com/codename1/ui/SwipeableContainer.java index dc22b8eb54..c54df4e408 100644 --- a/CodenameOne/src/com/codename1/ui/SwipeableContainer.java +++ b/CodenameOne/src/com/codename1/ui/SwipeableContainer.java @@ -472,6 +472,8 @@ public void actionPerformed(ActionEvent evt) { } break; } + default: + break; } } } diff --git a/CodenameOne/src/com/codename1/ui/Tabs.java b/CodenameOne/src/com/codename1/ui/Tabs.java index 13da8d58ad..685080739f 100644 --- a/CodenameOne/src/com/codename1/ui/Tabs.java +++ b/CodenameOne/src/com/codename1/ui/Tabs.java @@ -1746,6 +1746,8 @@ public void actionPerformed(ActionEvent evt) { dragStarted = false; break; } + default: + break; } } diff --git a/CodenameOne/src/com/codename1/ui/TextField.java b/CodenameOne/src/com/codename1/ui/TextField.java index 92a508da67..eb19166687 100644 --- a/CodenameOne/src/com/codename1/ui/TextField.java +++ b/CodenameOne/src/com/codename1/ui/TextField.java @@ -1869,6 +1869,8 @@ public void actionPerformed(ActionEvent ev) { ev.consume(); editString(); break; + default: + break; } } } diff --git a/CodenameOne/src/com/codename1/ui/Transform.java b/CodenameOne/src/com/codename1/ui/Transform.java index 9d8164f9a4..4236ad5799 100644 --- a/CodenameOne/src/com/codename1/ui/Transform.java +++ b/CodenameOne/src/com/codename1/ui/Transform.java @@ -300,6 +300,8 @@ private void initNativeTransform() { case TYPE_IDENTITY: impl.setTransformIdentity(nativeTransform); break; + default: + break; } } diff --git a/CodenameOne/src/com/codename1/ui/UIFragment.java b/CodenameOne/src/com/codename1/ui/UIFragment.java index f599228caf..4c7ecb9864 100644 --- a/CodenameOne/src/com/codename1/ui/UIFragment.java +++ b/CodenameOne/src/com/codename1/ui/UIFragment.java @@ -851,8 +851,9 @@ private static Element buildXMLFromJSONNotation(Object o) throws IOException { break; case 'o': m.put("overlay", m.get("o")); - - + break; + default: + break; } } } diff --git a/CodenameOne/src/com/codename1/ui/URLImage.java b/CodenameOne/src/com/codename1/ui/URLImage.java index 44964b8a04..1c20fb1441 100644 --- a/CodenameOne/src/com/codename1/ui/URLImage.java +++ b/CodenameOne/src/com/codename1/ui/URLImage.java @@ -764,6 +764,8 @@ public void onSucess(Image downloadedImage) { } break; } + default: + break; } image = downloadedImage.getImage(); diff --git a/CodenameOne/src/com/codename1/ui/animations/CommonTransitions.java b/CodenameOne/src/com/codename1/ui/animations/CommonTransitions.java index 79ff249a7e..5928549166 100644 --- a/CodenameOne/src/com/codename1/ui/animations/CommonTransitions.java +++ b/CodenameOne/src/com/codename1/ui/animations/CommonTransitions.java @@ -845,6 +845,9 @@ public void paint(Graphics g) { paint(g, c, 0, 0); } g.setAlpha(alpha); + break; + default: + break; } } catch (Throwable t) { // end the transition now just to be safe diff --git a/CodenameOne/src/com/codename1/ui/geom/GeneralPath.java b/CodenameOne/src/com/codename1/ui/geom/GeneralPath.java index b29417f08b..7d18c036ba 100644 --- a/CodenameOne/src/com/codename1/ui/geom/GeneralPath.java +++ b/CodenameOne/src/com/codename1/ui/geom/GeneralPath.java @@ -434,6 +434,8 @@ public boolean isPolygon() { case PathIterator.SEG_CUBICTO: case PathIterator.SEG_QUADTO: return false; + default: + break; } it.next(); } @@ -508,6 +510,8 @@ public String toString() { case PathIterator.SEG_CLOSE: sb.append(" CLOSE]"); break; + default: + break; } it.next(); } @@ -1078,6 +1082,8 @@ private void append(PathIterator path, boolean connect, float[] tmpCoordsBuf) { case PathIterator.SEG_CLOSE: closePath(); break; + default: + break; } path.next(); connect = false; @@ -1309,6 +1315,8 @@ public boolean isRectangle() { case 3: corners[i] = (x == bounds.getX() && y == bounds.getY() + bounds.getHeight()); break; + default: + break; } } @@ -2566,6 +2574,8 @@ public static int crossPath(PathIterator p, double x, double y) { cross += crossLine(cx, cy, cx = mx, cy = my, x, y); } break; + default: + throw new IllegalStateException("Illegal General path segment: " + p.currentSegment(coords)); } // checks if the point (x,y) is the vertex of shape with PathIterator p @@ -2939,6 +2949,8 @@ public static int intersectPath(PathIterator p, double x, double y, double w, do cx = mx; cy = my; break; + default: + throw new IllegalStateException("Illegal General path segment: " + p.currentSegment(coords)); } if (count == CROSSING) { return CROSSING; diff --git a/CodenameOne/src/com/codename1/ui/geom/Geometry.java b/CodenameOne/src/com/codename1/ui/geom/Geometry.java index d5d6ca151f..254c2586e3 100644 --- a/CodenameOne/src/com/codename1/ui/geom/Geometry.java +++ b/CodenameOne/src/com/codename1/ui/geom/Geometry.java @@ -135,6 +135,8 @@ public static void extractBezierCurvesFromPath(Shape shape, List ou prevX = buf[4]; prevY = buf[5]; break; + default: + break; } diff --git a/CodenameOne/src/com/codename1/ui/html/CSSEngine.java b/CodenameOne/src/com/codename1/ui/html/CSSEngine.java index 3aefc73bf9..54aff4a3e6 100644 --- a/CodenameOne/src/com/codename1/ui/html/CSSEngine.java +++ b/CodenameOne/src/com/codename1/ui/html/CSSEngine.java @@ -638,6 +638,8 @@ private void setTextTransformRecursive(Component cmp, int transformType) { } label.setText(newText); break; + default: + break; } } @@ -1051,6 +1053,8 @@ private void applyStyleToUIElement(Component ui, CSSElement selector, HTMLElemen case DISPLAY_MARQUEE: // Animate component (ticker-like) htmlC.marqueeComponents.addElement(ui); break; + default: + break; //TODO - support also: block, inline and list-item (All mandatory in WCSS) } @@ -1872,6 +1876,8 @@ Border createBorder(CSSElement styleAttributes, Component ui, int location, int border = Border.createDashedBorder(borderWidth, borderColor); } + break; + default: break; } diff --git a/CodenameOne/src/com/codename1/ui/html/HTMLComponent.java b/CodenameOne/src/com/codename1/ui/html/HTMLComponent.java index c774b04c42..7e3ff8fc3a 100644 --- a/CodenameOne/src/com/codename1/ui/html/HTMLComponent.java +++ b/CodenameOne/src/com/codename1/ui/html/HTMLComponent.java @@ -1508,6 +1508,8 @@ private HTMLFont getCounterpartFont(int tag, HTMLFont font) { case HTMLElement.TAG_SMALL: attribute = HTMLFont.SMALL; break; + default: + break; } if (attribute == -1) { return font; @@ -2660,6 +2662,8 @@ private void handleInput(HTMLElement element, int align) { } handleImage(element, align, submitCmd); break; + default: + break; } if (cmp != null) { @@ -2984,6 +2988,8 @@ private void processTag(HTMLElement element, int align) { newLineIfNotEmpty(curAlign); pushContainer(child); break; + default: + break; case HTMLElement.TAG_FIELDSET: newLineIfNotEmpty(curAlign); Container newCont = new Container(); @@ -3297,7 +3303,6 @@ private void processTag(HTMLElement element, int align) { curTable.startSegment(HTMLTableModel.SEGMENT_TFOOT); } break; - } if (child.getNumChildren() > 0) { @@ -3627,6 +3632,8 @@ private void processTag(HTMLElement element, int align) { curTable.endSegment(); } break; + default: + break; } diff --git a/CodenameOne/src/com/codename1/ui/html/HTMLFont.java b/CodenameOne/src/com/codename1/ui/html/HTMLFont.java index a1c149e21e..4cae0ce8e3 100644 --- a/CodenameOne/src/com/codename1/ui/html/HTMLFont.java +++ b/CodenameOne/src/com/codename1/ui/html/HTMLFont.java @@ -316,6 +316,8 @@ HTMLFont getCounterpartFont(int attribute) { counterpartSize = (size == Font.SIZE_LARGE) ? Font.SIZE_MEDIUM : Font.SIZE_SMALL; counterpartFonts[attribute] = new HTMLFont(null, Font.createSystemFont(font.getFace(), style, counterpartSize)); break; + default: + break; } } return counterpartFonts[attribute]; diff --git a/CodenameOne/src/com/codename1/ui/layouts/BorderLayout.java b/CodenameOne/src/com/codename1/ui/layouts/BorderLayout.java index d47983354d..7ea723498e 100644 --- a/CodenameOne/src/com/codename1/ui/layouts/BorderLayout.java +++ b/CodenameOne/src/com/codename1/ui/layouts/BorderLayout.java @@ -604,7 +604,10 @@ public void layoutContainer(Container target) { h = targetHeight; x = s.getPaddingLeft(rtl); y = s.getPaddingTop(); + break; } + default: + break; } c.setWidth(w); c.setHeight(h); diff --git a/CodenameOne/src/com/codename1/ui/layouts/BoxLayout.java b/CodenameOne/src/com/codename1/ui/layouts/BoxLayout.java index a839e7e46f..cc9a53d5b6 100644 --- a/CodenameOne/src/com/codename1/ui/layouts/BoxLayout.java +++ b/CodenameOne/src/com/codename1/ui/layouts/BoxLayout.java @@ -410,6 +410,8 @@ public void layoutContainer(Container parent) { dy = (containerBottomInner - lastCmpBottomOuter); break; } + default: + break; } if (dy > 0) { for (int i = 0; i < numOfcomponents; i++) { @@ -435,6 +437,8 @@ public void layoutContainer(Container parent) { dx = (lastCmpLeftOuter - containerLeftInner); break; } + default: + break; } if (dx > 0) { for (int i = 0; i < numOfcomponents; i++) { @@ -456,6 +460,8 @@ public void layoutContainer(Container parent) { dx = (containerRightInner - lastCmpRightOuter); break; } + default: + break; } if (dx > 0) { for (int i = 0; i < numOfcomponents; i++) { diff --git a/CodenameOne/src/com/codename1/ui/layouts/FlowLayout.java b/CodenameOne/src/com/codename1/ui/layouts/FlowLayout.java index 47e83c46a7..1d7e20c627 100644 --- a/CodenameOne/src/com/codename1/ui/layouts/FlowLayout.java +++ b/CodenameOne/src/com/codename1/ui/layouts/FlowLayout.java @@ -465,6 +465,8 @@ private void moveComponents(Container target, int x, int y, int width, int heigh } else { x = width; } + break; + default: break; } Style parentStyle = target.getStyle(); diff --git a/CodenameOne/src/com/codename1/ui/layouts/GridBagLayout.java b/CodenameOne/src/com/codename1/ui/layouts/GridBagLayout.java index 679357cddf..36b13c6024 100644 --- a/CodenameOne/src/com/codename1/ui/layouts/GridBagLayout.java +++ b/CodenameOne/src/com/codename1/ui/layouts/GridBagLayout.java @@ -362,6 +362,8 @@ private int anchorComponentSide(int dispStart, int dispLength, ComponentSide com case ComponentSide.POS_END: s += insDispLength - compLength; break; + default: + break; } return s; } @@ -455,6 +457,8 @@ private int translateRelativeAnchor(int relAnchor, boolean l2r) { case GridBagConstraints.LAST_LINE_END: absAnchor = l2r ? GridBagConstraints.SOUTHEAST : GridBagConstraints.SOUTHWEST; break; + default: + break; } return absAnchor; } diff --git a/CodenameOne/src/com/codename1/ui/layouts/GroupLayout.java b/CodenameOne/src/com/codename1/ui/layouts/GroupLayout.java index fdd761b779..ccac8b2dd2 100644 --- a/CodenameOne/src/com/codename1/ui/layouts/GroupLayout.java +++ b/CodenameOne/src/com/codename1/ui/layouts/GroupLayout.java @@ -997,6 +997,8 @@ private void calculateAutopadding(Group group, int axis, int sizeType, case MAX_SIZE: size = group.getMaximumSize(axis); break; + default: + break; } group.setSize(axis, origin, size); group.calculateAutopadding(axis); @@ -1500,6 +1502,8 @@ int getSpringSize(Spring spring, int axis, int type) { return spring.getPreferredSize(axis); case MAX_SIZE: return spring.getMaximumSize(axis); + default: + break; } //assert false; return 0; diff --git a/CodenameOne/src/com/codename1/ui/layouts/LayeredLayout.java b/CodenameOne/src/com/codename1/ui/layouts/LayeredLayout.java index 4fdeb6a696..fd28527acf 100644 --- a/CodenameOne/src/com/codename1/ui/layouts/LayeredLayout.java +++ b/CodenameOne/src/com/codename1/ui/layouts/LayeredLayout.java @@ -2350,6 +2350,8 @@ public String getValueAsString() { return "auto"; case UNIT_BASELINE: return "baseline"; + default: + break; } return null; } @@ -2387,6 +2389,8 @@ public String getValueAsString(int decimalPlaces) { return "auto"; case UNIT_BASELINE: return "baseline"; + default: + break; } return null; } @@ -2969,6 +2973,7 @@ public Inset getOppositeInset() { break; default: oppSide = Component.LEFT; + break; } return cnst.insets[oppSide]; @@ -3470,6 +3475,8 @@ public Inset translatePixels(int delta, boolean preferMM, Container parent) { } break; } + default: + break; } //calculatedValue += delta; diff --git a/CodenameOne/src/com/codename1/ui/plaf/CSSBorder.java b/CodenameOne/src/com/codename1/ui/plaf/CSSBorder.java index fbbc6d20b2..972382fc43 100644 --- a/CodenameOne/src/com/codename1/ui/plaf/CSSBorder.java +++ b/CodenameOne/src/com/codename1/ui/plaf/CSSBorder.java @@ -526,6 +526,8 @@ private GeneralPath createShape( case CN.RIGHT: width -= arrowHeightPixels; break; + default: + break; } } if (hasBorderRadius()) { @@ -1659,6 +1661,8 @@ public String toBorderStyleCSSString() { return "hidden"; case STYLE_NONE: return "none"; + default: + break; } return "none"; @@ -2159,6 +2163,8 @@ private String getBackgroundPositionCSSString() { case VPOSITION_CENTER: sb.append("center").append(" "); break; + default: + break; } if (verticalPosition != null) { sb.append(verticalPosition.toCSSString()).append(" "); @@ -2175,6 +2181,8 @@ private String getBackgroundPositionCSSString() { case HPOSITION_CENTER: sb.append("center").append(" "); break; + default: + break; } if (horizontalPosition != null) { @@ -2213,6 +2221,8 @@ private Rectangle2D getTargetRect(Component c, Rectangle2D out, Rectangle2D cont w = floatPx(horizontalSize, c, contentRect, true); h = floatPx(verticalSize, c, contentRect, false); break; + default: + break; } @@ -2229,6 +2239,8 @@ private Rectangle2D getTargetRect(Component c, Rectangle2D out, Rectangle2D cont case VPOSITION_OTHER: y = contentRect.getY() + floatPx(verticalPosition, c, contentRect, false); break; + default: + break; } switch (horizontalPositionType) { @@ -2241,6 +2253,8 @@ private Rectangle2D getTargetRect(Component c, Rectangle2D out, Rectangle2D cont case HPOSITION_OTHER: x = contentRect.getX() + floatPx(horizontalPosition, c, contentRect, true); break; + default: + break; } out.setBounds(x, y, w, h); @@ -2304,6 +2318,8 @@ void paint(Graphics g, Component c, Rectangle2D contentRect) { g.tileImage(scaled, (int) (contentRect.getX() + offX), (int) (contentRect.getY() + offY), (int) (contentRect.getWidth() - offX), (int) (contentRect.getHeight() - offY)); break; } + default: + break; } diff --git a/CodenameOne/src/com/codename1/ui/plaf/DefaultLookAndFeel.java b/CodenameOne/src/com/codename1/ui/plaf/DefaultLookAndFeel.java index 117af5cf20..a69484ffc1 100644 --- a/CodenameOne/src/com/codename1/ui/plaf/DefaultLookAndFeel.java +++ b/CodenameOne/src/com/codename1/ui/plaf/DefaultLookAndFeel.java @@ -471,6 +471,8 @@ public Span calculateLabelSpan(TextSelection sel, Label l) { case Label.TOP: y = y + (cmpHeight - (topPadding + bottomPadding + ((icon != null) ? icon.getHeight() + gap : 0) + fontHeight)) / 2; break; + default: + break; } } else if (align == Component.CENTER) { switch (textPos) { @@ -507,6 +509,8 @@ public Span calculateLabelSpan(TextSelection sel, Label l) { ((icon != null) ? icon.getHeight() + gap : 0) + fontHeight)) / 2; break; + default: + break; } } else if (align == Component.RIGHT) { switch (textPos) { @@ -548,6 +552,8 @@ public Span calculateLabelSpan(TextSelection sel, Label l) { bottomPadding + ((icon != null) ? icon.getHeight() + gap : 0) + fontHeight)) / 2; break; + default: + break; } } @@ -616,6 +622,9 @@ public Span calculateLabelSpan(TextSelection sel, Label l) { return calculateSpanForLabelString(sel, l, text, x, y, textSpaceW); //g.drawImage(icon, x + iconStringWGap, y + fontHeight + gap); } + // break; // unreachable because of return + default: + break; } } @@ -837,6 +846,9 @@ public Spans calculateTextAreaSpan(TextSelection sel, TextArea ta) { break; case Component.BOTTOM: topPadding += Math.max(0, (ta.getInnerHeight() - (ta.getRowsGap() + fontHeight) * line)); + break; + default: + break; } //boolean shouldBreak = false; int posOffset = 0; @@ -871,6 +883,8 @@ public Spans calculateTextAreaSpan(TextSelection sel, TextArea ta) { case Component.CENTER: x += (ta.getWidth() - leftPadding - rightPadding - f.stringWidth(displayText)) / 2; break; + default: + break; } //int nextY = ta.getY() + topPadding + (ta.getRowsGap() + fontHeight) * (i + 2); //if this is the last line to display and there is more content and isEndsWith3Points() is true @@ -929,6 +943,9 @@ public void drawTextArea(Graphics g, TextArea ta) { break; case Component.BOTTOM: topPadding += Math.max(0, (ta.getInnerHeight() - ta.getRowsGap() * (line - 1) - fontHeight * line)); + break; + default: + break; } boolean shouldBreak = false; @@ -957,6 +974,8 @@ public void drawTextArea(Graphics g, TextArea ta) { case Component.CENTER: x += (ta.getWidth() - leftPadding - rightPadding - f.stringWidth(displayText)) / 2; break; + default: + break; } int nextY = ta.getY() + topPadding + (ta.getRowsGap() + fontHeight) * (i + 2); //if this is the last line to display and there is more content and isEndsWith3Points() is true @@ -1060,6 +1079,8 @@ private Dimension getPreferredSize(Label l, Image[] icons, Image stateImage) { prefW = Math.max(prefW, font.stringWidth(text)); prefH += font.getHeight(); break; + default: + break; } } //add the state image(relevant for CheckBox\RadioButton) @@ -1079,6 +1100,8 @@ private Dimension getPreferredSize(Label l, Image[] icons, Image stateImage) { case Label.TOP: prefH += gap; break; + default: + break; } } @@ -1376,6 +1399,8 @@ private void drawComponent(Graphics g, Label l, Image icon, Image stateIcon, int case Label.TOP: y = y + (cmpHeight - (topPadding + bottomPadding + ((icon != null) ? icon.getHeight() + gap : 0) + fontHeight)) / 2; break; + default: + break; } } else if (align == Component.CENTER) { switch (textPos) { @@ -1407,6 +1432,8 @@ private void drawComponent(Graphics g, Label l, Image icon, Image stateIcon, int ((icon != null) ? icon.getHeight() + gap : 0) + fontHeight)) / 2; break; + default: + break; } } else if (align == Component.RIGHT) { switch (textPos) { @@ -1437,6 +1464,8 @@ private void drawComponent(Graphics g, Label l, Image icon, Image stateIcon, int bottomPadding + ((icon != null) ? icon.getHeight() + gap : 0) + fontHeight)) / 2; break; + default: + break; } } @@ -1510,6 +1539,8 @@ private void drawComponent(Graphics g, Label l, Image icon, Image stateIcon, int g.drawImage(icon, x + iconStringWGap, y + fontHeight + gap); } break; + default: + break; } } diff --git a/CodenameOne/src/com/codename1/ui/plaf/RoundRectBorder.java b/CodenameOne/src/com/codename1/ui/plaf/RoundRectBorder.java index 7f756944d5..bbccbf78d0 100644 --- a/CodenameOne/src/com/codename1/ui/plaf/RoundRectBorder.java +++ b/CodenameOne/src/com/codename1/ui/plaf/RoundRectBorder.java @@ -869,6 +869,8 @@ private GeneralPath createShape(int shapeW, int shapeH) { case CN.RIGHT: widthF -= ah; break; + default: + break; } } diff --git a/CodenameOne/src/com/codename1/ui/plaf/Style.java b/CodenameOne/src/com/codename1/ui/plaf/Style.java index 004d5ac28c..c3a5c7843d 100644 --- a/CodenameOne/src/com/codename1/ui/plaf/Style.java +++ b/CodenameOne/src/com/codename1/ui/plaf/Style.java @@ -1732,6 +1732,8 @@ public float getPaddingFloatValue(boolean rtl, int orientation) { case Component.RIGHT: orientation = Component.LEFT; break; + default: + break; } } @@ -2349,6 +2351,8 @@ public float getMarginFloatValue(boolean rtl, int orientation) { case Component.RIGHT: orientation = Component.LEFT; break; + default: + break; } } return margin[orientation]; diff --git a/CodenameOne/src/com/codename1/ui/plaf/StyleParser.java b/CodenameOne/src/com/codename1/ui/plaf/StyleParser.java index e350ddf4e1..78eb9320c2 100644 --- a/CodenameOne/src/com/codename1/ui/plaf/StyleParser.java +++ b/CodenameOne/src/com/codename1/ui/plaf/StyleParser.java @@ -2301,6 +2301,9 @@ private Border createRoundRectBorder() { break; case Style.UNIT_TYPE_DIPS: b.shadowSpread((float) sv.getValue()); + break; + default: + break; } } if (getShadowX() != null) { diff --git a/CodenameOne/src/com/codename1/ui/scene/TextPainter.java b/CodenameOne/src/com/codename1/ui/scene/TextPainter.java index 9e51ba57ea..16cfa2c20b 100644 --- a/CodenameOne/src/com/codename1/ui/scene/TextPainter.java +++ b/CodenameOne/src/com/codename1/ui/scene/TextPainter.java @@ -81,6 +81,8 @@ public void paint(Graphics g, Rectangle bounds, Node node) { case Component.RIGHT: x = innerX + innerW - textWidth; break; + default: + break; } switch (vAlign) { @@ -90,6 +92,8 @@ public void paint(Graphics g, Rectangle bounds, Node node) { case Component.BOTTOM: y = innerY + innerH - textHeight; break; + default: + break; } g.setFont(font); g.setColor(style.getFgColor()); diff --git a/CodenameOne/src/com/codename1/ui/spinner/DateTimeRenderer.java b/CodenameOne/src/com/codename1/ui/spinner/DateTimeRenderer.java index 4ff7e33498..6f66a7b824 100644 --- a/CodenameOne/src/com/codename1/ui/spinner/DateTimeRenderer.java +++ b/CodenameOne/src/com/codename1/ui/spinner/DateTimeRenderer.java @@ -158,6 +158,8 @@ public Component getListCellRendererComponent(List list, Object value, int index case Spinner.DATE_FORMAT_DOW_MON_DD_YY: value = getLocalizedDay(c.get(Calendar.DAY_OF_WEEK) - 1) + separatorChar + getLocalizedMonth(month - 1) + separatorChar + twoDigits(day) + separatorChar + year; break; + default: + break; } } else { int v = ((Integer) value).intValue(); diff --git a/CodenameOne/src/com/codename1/ui/spinner/Picker.java b/CodenameOne/src/com/codename1/ui/spinner/Picker.java index 72198641b5..53cb691c62 100644 --- a/CodenameOne/src/com/codename1/ui/spinner/Picker.java +++ b/CodenameOne/src/com/codename1/ui/spinner/Picker.java @@ -163,6 +163,8 @@ public void actionPerformed(ActionEvent evt) { metaData = "minuteStep=" + minuteStep; break; } + default: + break; } setEnabled(false); @@ -204,6 +206,8 @@ public void actionPerformed(ActionEvent evt) { } break; } + default: + break; case Display.PICKER_TYPE_CALENDAR: showInteractionDialog(); evt.consume(); @@ -747,6 +751,8 @@ private static boolean isLightweightModeSupportedForType(int type) { case Display.PICKER_TYPE_DURATION_MINUTES: case Display.PICKER_TYPE_CALENDAR: return true; + default: + break; } return false; } @@ -966,6 +972,8 @@ public void setType(int type) { setDuration(0L); } break; + default: + break; } } @@ -1293,6 +1301,8 @@ protected void updateValue() { } break; } + default: + break; } } diff --git a/CodenameOne/src/com/codename1/ui/spinner/Spinner.java b/CodenameOne/src/com/codename1/ui/spinner/Spinner.java index b0793b3a93..3496dc6676 100644 --- a/CodenameOne/src/com/codename1/ui/spinner/Spinner.java +++ b/CodenameOne/src/com/codename1/ui/spinner/Spinner.java @@ -445,6 +445,8 @@ public void keyReleased(int code) { return; } break; + default: + break; } int actual = seconds + minutes * 60 + hours * 60 * 60; @@ -469,6 +471,8 @@ public void keyReleased(int code) { currentInputAlign = LEFT; lastKeyInteraction = -1; break; + default: + break; } } } else { @@ -494,6 +498,8 @@ public void keyReleased(int code) { int y = c.get(Calendar.YEAR); c.set(Calendar.YEAR, y - (y % 100) + Integer.parseInt(t)); break; + default: + break; } setValue(c.getTime()); @@ -511,6 +517,8 @@ public void keyReleased(int code) { currentInputAlign = LEFT; lastKeyInteraction = -1; break; + default: + break; } } } diff --git a/CodenameOne/src/com/codename1/ui/spinner/SpinnerNode.java b/CodenameOne/src/com/codename1/ui/spinner/SpinnerNode.java index b389fc9a88..52c452df3c 100644 --- a/CodenameOne/src/com/codename1/ui/spinner/SpinnerNode.java +++ b/CodenameOne/src/com/codename1/ui/spinner/SpinnerNode.java @@ -425,6 +425,8 @@ public void render(Graphics g) { case Component.RIGHT: translateX.set(oldTranslateX - boundsInLocal.get().getWidth() * (magnification - 1.0) / 2 / magnification); break; + default: + break; } selectedRowOverlay.visible.set(false); diff --git a/CodenameOne/src/com/codename1/ui/table/Table.java b/CodenameOne/src/com/codename1/ui/table/Table.java index 1c0142c06d..c25f0d9748 100644 --- a/CodenameOne/src/com/codename1/ui/table/Table.java +++ b/CodenameOne/src/com/codename1/ui/table/Table.java @@ -1096,6 +1096,8 @@ public void actionPerformed(ActionEvent evt) { case Display.PICKER_TYPE_STRINGS: model.setValueAt(row, column, ((Picker) c).getSelectedString()); break; + default: + break; } } else { if (c instanceof CheckBox) { diff --git a/CodenameOne/src/com/codename1/ui/table/TableLayout.java b/CodenameOne/src/com/codename1/ui/table/TableLayout.java index 3593b41194..fcf3cf46de 100644 --- a/CodenameOne/src/com/codename1/ui/table/TableLayout.java +++ b/CodenameOne/src/com/codename1/ui/table/TableLayout.java @@ -541,6 +541,8 @@ private void placeComponent(boolean rtl, Constraint con, int x, int y, int width case Component.RIGHT: a = Component.LEFT; break; + default: + break; } } switch (a) { @@ -556,6 +558,8 @@ private void placeComponent(boolean rtl, Constraint con, int x, int y, int width con.parent.setX(x + d / 2); con.parent.setWidth(width - d); break; + default: + break; } } if (pHeight < height) { @@ -569,7 +573,8 @@ private void placeComponent(boolean rtl, Constraint con, int x, int y, int width con.parent.setY(y + d); con.parent.setHeight(height - d); break; - case Component.CENTER: + default: + // Component.CENTER: con.parent.setY(y + d / 2); con.parent.setHeight(height - d); break; diff --git a/CodenameOne/src/com/codename1/ui/util/Resources.java b/CodenameOne/src/com/codename1/ui/util/Resources.java index 1c842e898b..ac872d0f7d 100644 --- a/CodenameOne/src/com/codename1/ui/util/Resources.java +++ b/CodenameOne/src/com/codename1/ui/util/Resources.java @@ -1278,6 +1278,8 @@ Font createTrueTypeFont(Font f, String fontName, String fileName, float fontSize case 4: // pixels break; + default: + break; case 5: // rem fontSize = Font.getDefaultFont().getHeight() * fontSize; break; @@ -1605,6 +1607,8 @@ class MediaRule { new Float(f2), new Float(radialSize)}); break; + default: + break; } continue; } @@ -1899,6 +1903,8 @@ private Object createBorder(DataInputStream input, int type) throws IOException Log.e(t); return Border.createEmpty(); } + default: + break; } return null; diff --git a/CodenameOne/src/com/codename1/ui/util/UIBuilder.java b/CodenameOne/src/com/codename1/ui/util/UIBuilder.java index f48fd88201..15c270201b 100644 --- a/CodenameOne/src/com/codename1/ui/util/UIBuilder.java +++ b/CodenameOne/src/com/codename1/ui/util/UIBuilder.java @@ -534,6 +534,8 @@ private void postCreateComponents(DataInputStream in, Container parent, Resource case PROPERTY_NEXT_FOCUS_RIGHT: c.setNextFocusRight(findByName(in.readUTF(), parent)); break; + default: + break; } name = in.readUTF(); @@ -777,6 +779,8 @@ private Object[] readObjectArrayForListModel(DataInputStream in, Resources res) } } break; + default: + break; } } return elements; @@ -1056,6 +1060,8 @@ private Component createComponent(DataInputStream in, Container parent, Containe } } break; + default: + break; case PROPERTY_EMBED: root.putClientProperty(EMBEDDED_FORM_FLAG, ""); @@ -1175,6 +1181,8 @@ private Component createComponent(DataInputStream in, Container parent, Containe layout = b; break; } + default: + break; case LAYOUT_BORDER: { BorderLayout b = new BorderLayout(); if (in.readBoolean()) { diff --git a/CodenameOne/src/com/codename1/util/Base64.java b/CodenameOne/src/com/codename1/util/Base64.java index 6aa381f330..9f63669428 100644 --- a/CodenameOne/src/com/codename1/util/Base64.java +++ b/CodenameOne/src/com/codename1/util/Base64.java @@ -174,6 +174,8 @@ public static String encode(byte[] in) { out[index++] = map[((in[end + 1] & 0x0f) << 2)]; out[index++] = '='; break; + default: + break; } return new String(out, 0, index); } @@ -211,6 +213,8 @@ public static String encodeNoNewline(byte[] in) { out[index++] = map[((in[end + 1] & 0x0f) << 2)]; out[index++] = '='; break; + default: + break; } return new String(out, 0, index); } diff --git a/CodenameOne/src/com/codename1/util/promise/Promise.java b/CodenameOne/src/com/codename1/util/promise/Promise.java index 38dfc30c32..5dfa8f1d0d 100644 --- a/CodenameOne/src/com/codename1/util/promise/Promise.java +++ b/CodenameOne/src/com/codename1/util/promise/Promise.java @@ -275,6 +275,8 @@ public void run() { case Pending: promiseResult.then(p.promise.resolve, p.promise.reject); break; + default: + break; } } else { p.promise.resolve.call(result); @@ -402,6 +404,8 @@ public Object call(Throwable o) { case Rejected: processThens(error, false); break; + default: + break; } return handler.promise; } diff --git a/CodenameOne/src/com/codename1/util/regex/RECompiler.java b/CodenameOne/src/com/codename1/util/regex/RECompiler.java index 779f47c5c4..e932ba764a 100644 --- a/CodenameOne/src/com/codename1/util/regex/RECompiler.java +++ b/CodenameOne/src/com/codename1/util/regex/RECompiler.java @@ -550,6 +550,8 @@ int characterClass() throws RESyntaxException { case RE.E_DIGIT: range.include('0', '9', include); break; + default: + break; } // Make last char invalid (can't be a range start) @@ -867,6 +869,9 @@ int closure(int[] flags) throws RESyntaxException { if ((terminalFlags[0] & NODE_NULLABLE) != 0) { syntaxError("Closure operand can't be nullable"); } + break; + default: + break; } // If the next character is a '?', make the closure non-greedy (reluctant) @@ -954,6 +959,8 @@ int closure(int[] flags) throws RESyntaxException { setNextOfEnd(n, ret); break; } + default: + break; } } else { // Actually do the closure now @@ -979,6 +986,8 @@ int closure(int[] flags) throws RESyntaxException { setNextOfEnd(ret + RE.nodeSize, n); break; } + default: + break; } }