No need full URI in request

[r3bers]

There is Full URI in constants. But better be URI without base.

bittrex-api/tests/Middleware/AuthenticationTest.php

Line 17 in c449901

private const URI = 'https://api.bittrex.com/api/v1.1/account/getbalances';

Used here:

bittrex-api/tests/Middleware/AuthenticationTest.php

Line 31 in c449901

$request = $this->getHandledRequest(new Request(self::METHOD, self::URI, []));

And here:

bittrex-api/tests/Middleware/AuthenticationTest.php

Line 22 in c449901

$request = $this->getHandledRequest(new Request(self::METHOD, self::URI, []));

According GuzzleHttp Docs Base URI used on Client Class, and in Request only need URI.
I start using BASE_URI in v3 implementation of Authentication Class and catch this error like doubling BASE_URI in PreSign

[codenix-sv]

Hi. Thank you for your feedback!

This improvement will be implemented in the new release.

[r3bers]

I'm made v3 version already. If you wanted, I can return your namespace and pull request all changes. I made mine namespaces just for testing purposes and using both. https://github.com/r3bers/bittrex-api

…

On Sun, 12 Jul 2020, 12:35 Volodymyr Svyryd, ***@***.***> wrote: Hi. Thank you for your feedback! This improvement will be implemented in the new release. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#4 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC3NUQ7PZA5LPOODHE5H5OTR3F7U3ANCNFSM4OR56XAA> .

[codenix-sv]

Thank you for your proposal, but v3 version is already in development.

[r3bers]

Some tip if you will imply HEAD methods for Sequence and count for Private API to prevent throttling.
Bittrex didn't count HEAD in 60 per minute Limit.

[codenix-sv]

Thanks for the tip. I really appreciate your help

[holtkamp]

#4 (comment)

Just wondering, are you still working on this?