Merge branch 'rubocop'

Author: codeout

.rubocop.yml

@@ -0,0 +1,28 @@
+Gemspec/RequiredRubyVersion:
+  Enabled: false
+
+Layout/LineLength:
+  Enabled: false
+
+Metrics/ClassLength:
+  Enabled: false
+Metrics/MethodLength:
+  Enabled: false
+Metrics/BlockLength:
+  Enabled: false
+Metrics/CyclomaticComplexity:
+  Enabled: false
+Metrics/PerceivedComplexity:
+  Enabled: false
+Metrics/AbcSize:
+  Enabled: false
+
+Style/Documentation:
+  Enabled: false
+
+AllCops:
+  NewCops: enable
+  Exclude:
+    - example/**/*
+    - lib/junoser/parser.rb
+    - tmp/rule.rb

Gemfile

@@ -1,4 +1,14 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 # Specify your gem's dependencies in junoser.gemspec
 gemspec
+
+group :development do
+  gem 'bundler', '~> 2.0'
+  gem 'nokogiri'
+  gem 'rake', '~> 13.0'
+  gem 'rubocop'
+  gem 'test-unit'
+end

Gemfile.lock

@@ -7,16 +7,45 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
+    ast (2.4.3)
+    json (2.15.0)
+    language_server-protocol (3.17.0.5)
+    lint_roller (1.1.0)
     mini_portile2 (2.8.9)
     nokogiri (1.18.10)
       mini_portile2 (~> 2.8.2)
       racc (~> 1.4)
+    parallel (1.27.0)
+    parser (3.3.9.0)
+      ast (~> 2.4.1)
+      racc
     parslet (2.0.0)
     power_assert (2.0.5)
+    prism (1.5.1)
     racc (1.8.1)
+    rainbow (3.1.1)
     rake (13.3.0)
+    regexp_parser (2.11.3)
+    rubocop (1.81.1)
+      json (~> 2.3)
+      language_server-protocol (~> 3.17.0.2)
+      lint_roller (~> 1.1.0)
+      parallel (~> 1.10)
+      parser (>= 3.3.0.2)
+      rainbow (>= 2.2.2, < 4.0)
+      regexp_parser (>= 2.9.3, < 3.0)
+      rubocop-ast (>= 1.47.1, < 2.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (>= 2.4.0, < 4.0)
+    rubocop-ast (1.47.1)
+      parser (>= 3.3.7.2)
+      prism (~> 1.4)
+    ruby-progressbar (1.13.0)
     test-unit (3.7.0)
       power_assert
+    unicode-display_width (3.2.0)
+      unicode-emoji (~> 4.1)
+    unicode-emoji (4.1.0)
 
 PLATFORMS
   ruby
@@ -26,6 +55,7 @@ DEPENDENCIES
   junoser!
   nokogiri
   rake (~> 13.0)
+  rubocop
   test-unit
 
 BUNDLED WITH

Rakefile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'bundler/gem_tasks'
 require 'junoser/development'
 require 'nokogiri'
@@ -9,9 +11,9 @@ rule_path = File.join(__dir__, 'tmp/rule.rb')
 ruby_parser_path = File.join(__dir__, 'lib/junoser/parser.rb')
 js_parser_path = File.join(__dir__, 'tmp/junos.js')
 
-def open_files(input, output, &block)
-  i = open(input)
-  o = open(output, 'w')
+def open_files(input, output)
+  i = File.open(input)
+  o = File.open(output, 'w')
 
   yield i, o
 
@@ -71,6 +73,7 @@ namespace :rule do
   task :tree, [:path] do |_, args|
     if args.path
       raise "File not found: #{args.path}" unless File.exist?(args.path)
+
       Junoser::RuleTree::Parser.new(File.read(args.path)).print
     else
       Junoser::RuleTree::Parser.new($stdin.read).print

bin/console

@@ -1,7 +1,8 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
-require "bundler/setup"
-require "junoser"
+require 'bundler/setup'
+require 'junoser'
 
 # You can add fixtures and/or initialization code here to make experimenting
 # with your gem easier. You can also use a different console, if you like.
@@ -10,5 +11,5 @@ require "junoser"
 # require "pry"
 # Pry.start
 
-require "irb"
+require 'irb'
 IRB.start

exe/junoser

@@ -1,13 +1,14 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
+require 'English'
 require 'optparse'
 require 'pathname'
 
-$: << File.expand_path('../../lib', Pathname.new(__FILE__).realpath)
+$LOAD_PATH << File.expand_path('../../lib', Pathname.new(__FILE__).realpath)
 
 require 'junoser'
 
-
 command = nil
 opts = OptionParser.new do |opts|
   opts.banner = 'junoser: an juniper configuration parser'
@@ -41,11 +42,11 @@ opts.parse!
 
 case command
 when :check
-  abort unless Junoser::Cli.commit_check($<)
+  abort unless Junoser::Cli.commit_check($DEFAULT_INPUT)
 when :display_set
-  puts Junoser::Cli.display_set($<)
+  puts Junoser::Cli.display_set($DEFAULT_INPUT)
 when :struct
-  puts Junoser::Cli.struct($<)
+  puts Junoser::Cli.struct($DEFAULT_INPUT)
 else
   puts opts
   abort

exe/junoser-squash

@@ -1,8 +1,11 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
+
+require 'English'
 require 'optparse'
 require 'pathname'
 
-$: << File.expand_path('../../lib', Pathname.new(__FILE__).realpath)
+$LOAD_PATH << File.expand_path('../../lib', Pathname.new(__FILE__).realpath)
 require 'junoser/squash'
 
 command = :squash
@@ -17,9 +20,9 @@ opts = OptionParser.new do |opts|
 end
 opts.parse!
 case command
-  when :squash
-    puts Junoser::Squash.new($<).transform
-  else
-    puts opts
-    abort
+when :squash
+  puts Junoser::Squash.new($DEFAULT_INPUT).transform
+else
+  puts opts
+  abort
 end

junoser.gemspec

@@ -1,31 +1,29 @@
-# coding: utf-8
-lib = File.expand_path('../lib', __FILE__)
+# frozen_string_literal: true
+
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'junoser/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = "junoser"
+  spec.name          = 'junoser'
   spec.version       = Junoser::VERSION
-  spec.authors       = ["Shintaro Kojima"]
-  spec.email         = ["[email protected]"]
+  spec.authors       = ['Shintaro Kojima']
+  spec.email         = ['[email protected]']
 
-  spec.summary       = %q{PEG parser for JUNOS configuration.}
-  spec.description   = %q{PEG parser to vefiry and translate into different formats for JUNOS configuration.}
-  spec.homepage      = "https://github.com/codeout/junoser"
+  spec.summary       = 'PEG parser for JUNOS configuration.'
+  spec.description   = 'PEG parser to vefiry and translate into different formats for JUNOS configuration.'
+  spec.homepage      = 'https://github.com/codeout/junoser'
 
   # Specify which files should be added to the gem when it is released.
   # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
-  spec.files         = Dir.chdir(File.expand_path('..', __FILE__)) do
+  spec.files         = Dir.chdir(File.expand_path(__dir__)) do
     `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features|example)/}) }
   end
-  spec.bindir        = "exe"
+  spec.bindir        = 'exe'
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
-  spec.require_paths = ["lib"]
+  spec.require_paths = ['lib']
 
-  spec.add_dependency "parslet"
+  spec.add_dependency 'parslet'
 
-  spec.add_development_dependency "bundler", "~> 2.0"
-  spec.add_development_dependency "rake", "~> 13.0"
-  spec.add_development_dependency "nokogiri"
-  spec.add_development_dependency "test-unit"
+  spec.metadata['rubygems_mfa_required'] = 'true'
 end

lib/junoser.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'junoser/cli'
 require 'junoser/display'
 require 'junoser/parser'

lib/junoser/cli.rb

@@ -1,9 +1,10 @@
+# frozen_string_literal: true
+
 require 'parslet'
 require 'junoser/display'
 require 'junoser/input'
 require 'junoser/parser'
 
-
 module Junoser
   module Cli
     class << self
@@ -37,7 +38,6 @@ def struct(io_or_string)
         end
       end
 
-
       private
 
       def commit_check_structured(config)