Remove concurrency option from install, as it is not supported with npm workspaces

Author: hlxid

src/install/development.ts

@@ -13,11 +13,7 @@ type CloneRepository = "nodecg-io" | "nodecg-io-docs";
 const nodecgIOCloneURL = "https://github.com/codeoverflow-org/nodecg-io.git";
 const nodecgIODocsCloneURL = "https://github.com/codeoverflow-org/nodecg-io-docs.git";
 
-export async function createDevInstall(
-    requested: DevelopmentInstallation,
-    nodecgIODir: string,
-    concurrency: number,
-): Promise<void> {
+export async function createDevInstall(requested: DevelopmentInstallation, nodecgIODir: string): Promise<void> {
     const wasRepoUpdated = await getGitRepo(nodecgIODir, "nodecg-io");
     await manageDocs(nodecgIODir, requested.cloneDocs);
 
@@ -29,7 +25,7 @@ export async function createDevInstall(
     }
 
     await installNPMDependencies(nodecgIODir);
-    await buildTypeScript(nodecgIODir, concurrency);
+    await buildTypeScript(nodecgIODir);
 
     await writeInstallInfo(nodecgIODir, requested); // save updated install which says that nodecg-io is now installed
 }
@@ -180,8 +176,8 @@ async function installNPMDependencies(nodecgIODir: string) {
     logger.info("Installed npm dependencies.");
 }
 
-async function buildTypeScript(nodecgIODir: string, concurrency: number) {
+async function buildTypeScript(nodecgIODir: string) {
     logger.info("Compiling nodecg-io...");
-    await runNpmBuild(nodecgIODir, "--", "--concurrency", concurrency.toString());
+    await runNpmBuild(nodecgIODir);
     logger.success("Compiled nodecg-io.");
 }

src/install/index.ts

@@ -14,31 +14,17 @@ import { findNodeCGDirectory, getNodeCGIODirectory } from "../utils/nodecgInstal
 export const installModule: CommandModule<unknown, { concurrency: number }> = {
     command: "install",
     describe: "installs nodecg-io to your local nodecg installation",
-
-    builder: (yargs) =>
-        yargs
-            .option("concurrency", {
-                alias: "j",
-                type: "number",
-                description: "The maximum count of concurrent running jobs when building a development install",
-                default: os.cpus().length,
-            })
-            .check((argv) => {
-                if (argv.concurrency < 1) throw new Error("Concurrency must be greater than zero.");
-                return true;
-            }),
-
-    handler: async (argv) => {
+    handler: async () => {
         try {
-            await install(argv.concurrency);
+            await install();
         } catch (err) {
             logger.error(`Error while installing nodecg-io: ${err}`);
             process.exit(1);
         }
     },
 };
 
-async function install(concurrency: number): Promise<void> {
+async function install(): Promise<void> {
     await requireNpmV7();
 
     logger.info("Installing nodecg-io...");
@@ -60,7 +46,7 @@ async function install(concurrency: number): Promise<void> {
 
     // Get packages
     if (requestedInstall.dev) {
-        await createDevInstall(requestedInstall, nodecgIODir, concurrency);
+        await createDevInstall(requestedInstall, nodecgIODir);
     } else {
         await createProductionInstall(
             requestedInstall,

test/install/development.ts

@@ -36,19 +36,19 @@ afterEach(() => {
 
 describe("createDevInstall", () => {
     test("should not do anything if HEAD commit hash didn't change", async () => {
-        await dev.createDevInstall(validDevInstall, fsRoot, 0);
+        await dev.createDevInstall(validDevInstall, fsRoot);
         expect(execSpy).toHaveBeenCalledTimes(0);
     });
 
     test("should execute install and build", async () => {
         fetchSpy.mockResolvedValueOnce(altFetchResult);
-        await dev.createDevInstall(validDevInstall, fsRoot, 0);
+        await dev.createDevInstall(validDevInstall, fsRoot);
         expect(execSpy).toHaveBeenCalledTimes(2);
     });
 
     test("should not clone docs if not wanted in installation info", async () => {
         // cloneDocs is false in validDevInstall, don't need to change it
-        await dev.createDevInstall(validDevInstall, nodecgIODir, 0);
+        await dev.createDevInstall(validDevInstall, nodecgIODir);
         expect(cloneSpy).toHaveBeenCalledTimes(1);
     });
 
@@ -59,7 +59,6 @@ describe("createDevInstall", () => {
                 cloneDocs: true,
             },
             nodecgIODir,
-            0,
         );
         expect(cloneSpy).toHaveBeenCalledTimes(2);
     });