Add tests for getSubPackage and diffPackage with dashboard

Author: hlxid

test/install/production.ts

@@ -1,6 +1,6 @@
 import { vol } from "memfs";
 import * as path from "path";
-import { corePkg, nodecgIODir, twitchChatPkg, validProdInstall } from "../testUtils";
+import { corePkg, dashboardPkg, nodecgIODir, twitchChatPkg, validProdInstall } from "../testUtils";
 import { diffPackages, installPackages, removePackages, validateInstall } from "../../src/install/production";
 import * as installation from "../../src/installation";
 import * as fsUtils from "../../src/fsUtils";
@@ -45,6 +45,13 @@ describe("diffPackages", () => {
         expect(pkgRemove).toStrictEqual([]);
         expect(pkgInstall).toStrictEqual([]);
     });
+
+    test("should install dashboard (sub pkg) if upgrading core", async () => {
+        // dashboard not modified, but should still be installed because it is in core and core gets upgraded
+        const { pkgInstall, pkgRemove } = diffPackages([corePkg2, dashboardPkg], [corePkg, dashboardPkg]);
+        expect(pkgRemove).toStrictEqual([corePkg]);
+        expect(pkgInstall).toStrictEqual([corePkg2, dashboardPkg]);
+    });
 });
 
 describe("removePackages", () => {

test/install/prompt.ts

@@ -25,7 +25,7 @@ describe("getCompatibleVersions", () => {
 });
 
 describe("buildPackageList", () => {
-    const ver = "0.1.0";
+    const ver = "0.1";
     const testSvcName = "testSvc";
     const testSvcPkgName = `nodecg-io-${testSvcName}`;
     const mock = jest.spyOn(npm, "getHighestPatchVersion").mockResolvedValue("0.1.1");

test/npm/pkgManagement.ts

@@ -1,6 +1,6 @@
 import { createFsFromVolume, vol } from "memfs";
-import { createNpmSymlinks, removeNpmPackage, runNpmInstall } from "../../src/npm";
-import { tempDir, corePkg, fsRoot } from "../testUtils";
+import { createNpmSymlinks, getSubPackages, removeNpmPackage, runNpmInstall } from "../../src/npm";
+import { tempDir, corePkg, fsRoot, twitchChatPkg, dashboardPkg } from "../testUtils";
 import * as fsUtils from "../../src/fsUtils";
 import * as path from "path";
 
@@ -45,3 +45,13 @@ describe("removeNpmPackage", () => {
         expect(spy).toHaveBeenCalled();
     });
 });
+
+describe("getSubPackages", () => {
+    test("should return empty list if no packages are inside the passed package", async () => {
+        expect(getSubPackages([corePkg, twitchChatPkg], corePkg)).toStrictEqual([]);
+    });
+
+    test("should return dashboard to be inside core", async () => {
+        expect(getSubPackages([corePkg, dashboardPkg], corePkg)).toStrictEqual([dashboardPkg]);
+    });
+});

test/testUtils.ts

@@ -1,5 +1,5 @@
 import * as temp from "temp";
-import { corePackage } from "../src/install/nodecgIOVersions";
+import { corePackage, dashboardPackage, dashboardPath } from "../src/install/nodecgIOVersions";
 import * as path from "path";
 import { DevelopmentInstallation, ProductionInstallation } from "../src/installation";
 
@@ -21,6 +21,11 @@ export const twitchChatPkg = {
     path: "nodecg-io-twitch-chat",
     version: "0.1.0",
 };
+export const dashboardPkg = {
+    name: dashboardPackage,
+    path: dashboardPath,
+    version: "0.1.0",
+};
 export const nodecgExampleConfig = {
     bundles: {
         paths: ["some-custom-bundle-dir"],