Skip to content

Commit 13349d4

Browse files
author
iclsrc
committed
Merge from 'sycl' to 'sycl-web' (3 commits)
2 parents 9571c4a + 8074617 commit 13349d4

File tree

5 files changed

+9
-21
lines changed

5 files changed

+9
-21
lines changed

sycl/include/sycl/detail/reduction_forward.hpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,10 @@
88

99
#pragma once
1010

11+
#include <sycl/detail/helpers.hpp> // for Builder
1112
#include <sycl/detail/item_base.hpp> // for range
1213
#include <sycl/id.hpp> // for id
13-
#include <sycl/item.hpp> // for getDelinearizedItem, item
14+
#include <sycl/item.hpp> // for item
1415
#include <sycl/nd_range.hpp> // for nd_range
1516
#include <sycl/range.hpp> // for range
1617

@@ -51,7 +52,7 @@ template <class FunctorTy> void withAuxHandler(handler &CGH, FunctorTy Func);
5152

5253
template <int Dims>
5354
item<Dims, false> getDelinearizedItem(range<Dims> Range, id<Dims> Id) {
54-
return {Range, Id};
55+
return Builder::createItem<Dims, false>(Range, Id);
5556
}
5657
} // namespace reduction
5758

sycl/include/sycl/item.hpp

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -21,17 +21,13 @@
2121

2222
namespace sycl {
2323
inline namespace _V1 {
24+
2425
namespace detail {
2526
class Builder;
2627
template <typename TransformedArgType, int Dims, typename KernelType>
2728
class RoundedRangeKernel;
2829
template <typename TransformedArgType, int Dims, typename KernelType>
2930
class RoundedRangeKernelWithKH;
30-
31-
namespace reduction {
32-
template <int Dims>
33-
item<Dims, false> getDelinearizedItem(range<Dims> Range, id<Dims> Id);
34-
} // namespace reduction
3531
} // namespace detail
3632

3733
/// Identifies an instance of the function object executing at each point
@@ -133,10 +129,6 @@ template <int Dimensions = 1, bool with_offset = true> class item {
133129
friend class detail::Builder;
134130

135131
private:
136-
template <int Dims>
137-
friend item<Dims, false>
138-
detail::reduction::getDelinearizedItem(range<Dims> Range, id<Dims> Id);
139-
140132
detail::ItemBase<Dimensions, with_offset> MImpl;
141133
};
142134

sycl/test-e2e/Basic/get_backend.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
// Failing due to old driver
2-
// XFAIL: gpu-intel-dg2
2+
// REQUIRES-INTEL-DRIVER: lin: 27202, win: 101.4677
33
// RUN: %{build} -o %t.out
44
// RUN: %{run-unfiltered-devices} %t.out
55
//

sycl/test-e2e/Graph/Explicit/work_group_size_prop.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,8 @@
55
//
66
// CHECK-NOT: LEAK
77

8-
// Temporarily disabled for CUDA.
9-
// XFAIL: cuda
10-
// Note: failing negative test with HIP in the original test
11-
// TODO: disable hip when HIP backend will be supported by Graph
8+
// Note: failing negative test with CUDA & HIP in the original test
9+
// UNSUPPORTED: cuda, hip
1210

1311
#define GRAPH_E2E_EXPLICIT
1412

sycl/test-e2e/Graph/RecordReplay/work_group_size_prop.cpp

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,8 @@
55
//
66
// CHECK-NOT: LEAK
77

8-
// Temporarily disabled for CUDA.
9-
// XFAIL: cuda
10-
11-
// Note: failing negative test with HIP in the original test
12-
// TODO: disable hip when HIP backend will be supported by Graph
8+
// Note: failing negative test with CUDA & HIP in the original test
9+
// UNSUPPORTED: cuda, hip
1310

1411
#define GRAPH_E2E_RECORD_REPLAY
1512

0 commit comments

Comments
 (0)