Merge pull request #312 from codepress/release/4.2.7

Release/4.2.7

Author: DGStefan

assets/js/admin-page-columns.js

@@ -1,7 +1,7 @@
 <?php
 /*
 Plugin Name: Admin Columns
-Version: 4.2.6
+Version: 4.2.7
 Description: Customize columns on the administration screens for post(types), pages, media, comments, links and users with an easy to use drag-and-drop interface.
 Author: AdminColumns.com
 Author URI: https://www.admincolumns.com
@@ -36,7 +36,7 @@
 }
 
 define( 'AC_FILE', __FILE__ );
-define( 'AC_VERSION', '4.2.6' );
+define( 'AC_VERSION', '4.2.7' );
 
 require_once __DIR__ . '/classes/Dependencies.php';
 

assets/js/admin-page-columns.js.map

@@ -3,9 +3,9 @@ Contributors: codepress, tschutter, davidmosterd, engelen, dungengronovius
 Donate link: https://www.paypal.com/cgi-bin/webscr?cmd=_s-xclick&hosted_button_id=ZDZRSYLQ4Z76J
 Tags: plugins, wordpress, admin, column, columns, custom columns, custom fields, image, dashboard, sortable, filters, posts, media, users, pages, posttypes, manage columns, wp-admin
 Requires at least: 4.7
-Tested up to: 5.6
+Tested up to: 5.6.1
 Requires PHP: 5.6.20
-Stable tag: 4.2.5
+Stable tag: 4.2.7
 
 Customise columns on the administration screens for post(types), pages, media, comments, links and users with an easy to use drag-and-drop interface.
 
@@ -209,6 +209,11 @@ You can find a list of the available actions and filters (and examples on how to
 
 == Changelog ==
 
+= 4.2.7 =
+Release Date: February 8th, 2021
+
+* [Fixed] Some settings were nog saved correctly on the admin settings page
+
 = 4.2.6 =
 Release Date: February 3rd, 2021
 

codepress-admin-columns.php

@@ -28,12 +28,12 @@ export default class ColumnConfigurator {
             initToggle(column);
             initIndicator(column);
             initTypeSelector(column);
-            initColumnRefresh(column);
             initRemoveColumn(column);
             initClone(column);
-            initLabel(column);
             initLabelSettingEvents(column);
             initLabelTooltipsEvent(column);
+            initLabel(column);
+            initColumnRefresh(column);
 
             initMultiSelectFields(column);
             initLabelSetting(column);

readme.txt

@@ -5,9 +5,9 @@ export const initLabel = (column: Column) => {
     column.getElement().querySelectorAll<HTMLSelectElement>('select[data-label="update"]').forEach((select) => {
         select.addEventListener('change', () => {
             let labelSetting = column.getElement().querySelector<HTMLInputElement>('input.ac-setting-input_label');
-            let option = select.querySelector('option:selected');
+            let option = select.selectedOptions.length > 0 ? select.selectedOptions[0] : null;
 
-            if (labelSetting && option) {
+            if (labelSetting &&  option ) {
                 labelSetting.value = option.innerHTML;
                 labelSetting.dispatchEvent(new Event('change'));
             }

src/js/admin/columns/column-configurator.ts

@@ -3,7 +3,8 @@ import {Column} from "../column";
 export const initColumnRefresh = (column: Column) => {
     column.getElement().querySelectorAll<HTMLElement>('[data-refresh="column"]').forEach(element => {
         element.addEventListener('change', () => {
-            column.refresh();
+            // Allow other settings to do their thing first so all changes are refreshed correctly
+            setTimeout(() => column.refresh(), 50);
         });
     });
 }

src/js/admin/columns/events/label.ts

@@ -125,12 +125,14 @@ export class Form {
 
     getFormData(): ListScreenStorageType {
         let columnData: any = {};
+        let titleElement = this.getElement().querySelector<HTMLInputElement>('input[name=title]');
+
         this.getSortedColumns().forEach(column => {
             columnData[column.getName()] = column.getJson();
         });
 
         return {
-            title: '',
+            title: titleElement ? titleElement.value : '',
             list_screen: AC.list_screen,
             list_screen_id: AC.layout,
             columns: columnData,
@@ -187,15 +189,21 @@ export class Form {
     private getPreferences(): keyAnyPair {
         let data: { [key: string]: any } = {};
         document.querySelectorAll<HTMLFormElement>('form[data-form-part=preferences]').forEach(el => {
+            let fData = new FormData(el);
             // @ts-ignore
-            for (let t of new FormData(el).entries()) {
-                data[t[0]] = t[1];
+            for (let entry of fData.entries()) {
+                let key = entry[0];
+                let value = entry[1];
+                let element = el.elements[key];
+
+                data[key] = element.tagName === 'SELECT' && element.hasAttribute('multiple')
+                    ? fData.getAll(key)
+                    : data[key] = value;
             }
         });
 
         return data;
     }
-
 }
 
 const createColumnFromTemplate = () => {