linting

Author: codepunkt

.eslintignore

@@ -0,0 +1,4 @@
+.vscode/
+build/
+coverage/
+node_modules/

.eslintrc

@@ -0,0 +1,39 @@
+{
+  "parser": "babel-eslint",
+  "env": {
+    "browser": true,
+    "es6": true,
+    "node": true,
+    "jest": true
+  },
+  "extends": [ "xo", "plugin:unicorn/recommended" ],
+  "plugins": [ "import", "unicorn" ],
+  "rules": {
+    // omit semicolons. there's only a few cases where automatic
+    // semicolon insertion is problematic - most of which can be
+    // mitigated by other linting rules such as func-call-spacing
+    // or no-unexpected-multiline
+    "semi": [ 2, "never" ],
+    // enforce 2-space indentation
+    "indent": [ 2, 2 ],
+    // enforce arrow parens, regardless of argument count
+    "arrow-parens": [ 2, "always" ],
+    // enforce dangling commas for multiline statements
+    "comma-dangle": [ 2, "always-multiline" ],
+    // enforce consistent spacing inside braces and brackets
+    "array-bracket-spacing": [ 2, "always", {
+      "arraysInArrays": false,
+      "objectsInArrays": false
+    }],
+    "object-curly-spacing": [ 2, "always", {
+      "arraysInObjects": false,
+      "objectsInObjects": false
+    }],
+    // enforce consistent linebreak style for operators, with an
+    // exception being made for multi-line-ternaries so those are
+    // easier to spot
+    "operator-linebreak": [ 2, "after", {
+      "overrides": { "?": "before", ":": "before" }
+    }]
+  }
+}

package.json

@@ -18,14 +18,20 @@
   ],
   "scripts": {
     "build": "babel src --out-dir build",
+    "lint": "eslint src",
     "test": "jest --coverage"
   },
   "dependencies": {},
   "devDependencies": {
     "babel-cli": "^6.18.0",
+    "babel-eslint": "^7.1.1",
     "babel-plugin-transform-object-rest-spread": "^6.22.0",
     "babel-preset-es2015": "^6.18.0",
     "coveralls": "^2.11.15",
+    "eslint": "^3.14.1",
+    "eslint-config-xo": "^0.17.0",
+    "eslint-plugin-import": "^2.2.0",
+    "eslint-plugin-unicorn": "^1.0.0",
     "jest": "^18.1.0"
   },
   "jest": {

src/__tests__/index.test.js

@@ -30,7 +30,7 @@ describe('css-spring', () => {
       spring(
         {
           'padding-left': '-50rem',
-          'opacity': true,
+          opacity: true,
           'margin-right': '0em',
         },
         {

src/__tests__/to-string.test.js

@@ -16,7 +16,7 @@ describe('format', () => {
     expect(
       reduceProperties({
         'padding-right': '12px',
-        'padding-left': '12px'
+        'padding-left': '12px',
       })
     ).toEqual(
       'padding-right:12px;padding-left:12px;'

src/__tests__/util.test.js

@@ -14,7 +14,7 @@ describe('utilities', () => {
     })
 
     test('maps each value', () => {
-      const mapped = mapValues({ foo: 1, bar: 2 }, (v) => 'wat')
+      const mapped = mapValues({ foo: 1, bar: 2 }, () => 'wat')
       expect(mapped).toEqual({ foo: 'wat', bar: 'wat' })
     })
   })

src/index.js

@@ -51,7 +51,7 @@ export const spring = (startProps, endProps, options = {}) => {
       const percent = `${i}%`
       keyframes[percent] = Object.assign(
         keyframes[percent] || {},
-        { [key]: `${+value.toFixed(precision)}${animatableProps[key].unit}` }
+        { [key]: `${Number(value.toFixed(precision))}${animatableProps[key].unit}` }
       )
     }
   })

src/props.js

@@ -22,8 +22,8 @@ export const getAnimatableProps = (startProps, endProps) => {
       if (startMatches && endMatches && startMatches[2] === endMatches[2]) {
         result[key] = {
           unit: startMatches[2],
-          start: +startMatches[1],
-          end: +endMatches[1]
+          start: Number(startMatches[1]),
+          end: Number(endMatches[1]),
         }
       }
     }

src/stepper.js

@@ -1,7 +1,8 @@
 // Taken from react-motion
 // @see https://github.com/chenglou/react-motion/blob/master/src/stepper.js
-const reusedTuple = [0, 0]
+const reusedTuple = [ 0, 0 ]
 
+// eslint-disable-next-line max-params
 export default (secondPerFrame, x, v, destX, k, b, precision = 0.01) => {
   // Spring stiffness, in kg / s^2
 

src/to-string.js

@@ -13,5 +13,4 @@ export const toString = (keyframes, formatter = defaultFormatter) => {
   }, '')
 }
 
-
 export default toString