C++: Also ignore phi input edges in 'AllocaInLoop.ql'.

MathiasVP · MathiasVP · commit 05d46a67936a · 2024-06-05T09:58:44.000+01:00
diff --git a/cpp/ql/src/Likely Bugs/Memory Management/AllocaInLoop.ql b/cpp/ql/src/Likely Bugs/Memory Management/AllocaInLoop.ql
@@ -209,6 +209,7 @@ class LoopWithAlloca extends Stmt {
       DataFlow::localFlow(result, DataFlow::exprNode(va)) and
       // Phi nodes will be preceded by nodes that represent actual definitions
       not result instanceof DataFlow::SsaPhiNode and
+      not result instanceof DataFlow::SsaPhiInputNode and
       // A source is outside the loop if it's not inside the loop
       not exists(Expr e | e = getExpr(result) | this = getAnEnclosingLoopOfExpr(e))
     )

Original file line number	Diff line number	Diff line change
`@@ -209,6 +209,7 @@ class LoopWithAlloca extends Stmt {`
`209`	`209`	`DataFlow::localFlow(result, DataFlow::exprNode(va)) and`
`210`	`210`	`// Phi nodes will be preceded by nodes that represent actual definitions`
`211`	`211`	`not result instanceof DataFlow::SsaPhiNode and`
	`212`	`+ not result instanceof DataFlow::SsaPhiInputNode and`
`212`	`213`	`// A source is outside the loop if it's not inside the loop`
`213`	`214`	`not exists(Expr e \| e = getExpr(result) \| this = getAnEnclosingLoopOfExpr(e))`
`214`	`215`	`)`