Skip to content

Commit 11acb49

Browse files
authored
Merge pull request github#16042 from geoffw0/maddoc
Remove [potentially] untrue claims about models-as-data
2 parents 0bf742b + b2a301c commit 11acb49

File tree

3 files changed

+4
-14
lines changed

3 files changed

+4
-14
lines changed

csharp/ql/lib/semmle/code/csharp/dataflow/internal/ExternalFlow.qll

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,15 +47,13 @@
4747
*
4848
* For sources, an `output` can be either "", "Argument[n]", "Argument[n1..n2]",
4949
* "Parameter", "Parameter[n]", "Parameter[n1..n2]", or "ReturnValue":
50-
* - "": Selects a read of a selected field, property, or parameter.
50+
* - "": Selects a read of a selected field or property.
5151
* - "Argument[n]": Selects the post-update value of an argument in a call to the
5252
* selected element. That is, the value of the argument after the call returns.
5353
* The arguments are zero-indexed, and `this` specifies the qualifier.
5454
* - "Argument[n1..n2]": Similar to "Argument[n]" but select any argument in
5555
* the given range. The range is inclusive at both ends.
5656
* - "Parameter": Selects the value of a parameter of the selected element.
57-
* "Parameter" is also allowed in case the selected element is already a
58-
* parameter itself.
5957
* - "Parameter[n]": Similar to "Parameter" but restricted to a specific
6058
* numbered parameter (zero-indexed, and `this` specifies the value of `this`).
6159
* - "Parameter[n1..n2]": Similar to "Parameter[n]" but selects any parameter

go/ql/lib/semmle/go/dataflow/ExternalFlow.qll

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,15 +34,13 @@
3434
* An `output` can be either "", "Argument[n]", "Argument[n1..n2]", "Parameter",
3535
* "Parameter[n]", "Parameter[n1..n2]", , "ReturnValue", "ReturnValue[n]", or
3636
* "ReturnValue[n1..n2]":
37-
* - "": Selects a read of a selected field, or a selected parameter.
37+
* - "": Selects a read of a selected field.
3838
* - "Argument[n]": Selects the post-update value of an argument in a call to the
3939
* selected element. That is, the value of the argument after the call returns.
4040
* The arguments are zero-indexed, and `-1` specifies the qualifier.
4141
* - "Argument[n1..n2]": Similar to "Argument[n]" but select any argument in
4242
* the given range. The range is inclusive at both ends.
4343
* - "Parameter": Selects the value of a parameter of the selected element.
44-
* "Parameter" is also allowed in case the selected element is already a
45-
* parameter itself.
4644
* - "Parameter[n]": Similar to "Parameter" but restricted to a specific
4745
* numbered parameter (zero-indexed, and `-1` specifies the value of `this`).
4846
* - "Parameter[n1..n2]": Similar to "Parameter[n]" but selects any parameter

swift/ql/lib/codeql/swift/dataflow/ExternalFlow.qll

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,7 @@
2525
* types can be short names or fully qualified names (mixing these two options
2626
* is not allowed within a single signature).
2727
* 6. The `ext` column specifies additional API-graph-like edges. Currently
28-
* there are only two valid values: "" and "Annotated". The empty string has no
29-
* effect. "Annotated" applies if `name` and `signature` were left blank and
30-
* acts by selecting an element that is annotated by the annotation type
31-
* selected by the first 4 columns. This can be another member such as a field
32-
* or method, or a parameter.
28+
* there is only one valid value: "".
3329
* 7. The `input` column specifies how data enters the element selected by the
3430
* first 6 columns, and the `output` column specifies how data leaves the
3531
* element selected by the first 6 columns. An `input` can be either "",
@@ -44,15 +40,13 @@
4440
*
4541
* An `output` can be either "", "Argument[n]", "Argument[n1..n2]", "Parameter",
4642
* "Parameter[n]", "Parameter[n1..n2]", or "ReturnValue":
47-
* - "": Selects a read of a selected field, or a selected parameter.
43+
* - "": Selects a read of a selected field.
4844
* - "Argument[n]": Selects the post-update value of an argument in a call to the
4945
* selected element. That is, the value of the argument after the call returns.
5046
* The arguments are zero-indexed, and `-1` specifies the qualifier.
5147
* - "Argument[n1..n2]": Similar to "Argument[n]" but select any argument in
5248
* the given range. The range is inclusive at both ends.
5349
* - "Parameter": Selects the value of a parameter of the selected element.
54-
* "Parameter" is also allowed in case the selected element is already a
55-
* parameter itself.
5650
* - "Parameter[n]": Similar to "Parameter" but restricted to a specific
5751
* numbered parameter (zero-indexed, and `-1` specifies the value of `this`).
5852
* - "Parameter[n1..n2]": Similar to "Parameter[n]" but selects any parameter

0 commit comments

Comments
 (0)