Skip to content

Commit 128bc99

Browse files
committed
C++: delete some FIXMEs that turned out fine
1 parent b9785ea commit 128bc99

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

cpp/ql/lib/semmle/code/cpp/ir/implementation/raw/internal/TranslatedInitialization.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1067,7 +1067,7 @@ class TranslatedConstructorBareInit extends TranslatedElement, TTranslatedConstr
10671067
result = this.getParent().getChildSuccessor(this, kind)
10681068
}
10691069

1070-
override Instruction getALastInstructionInternal() { none() } // FIXME: does this need to be filled in?
1070+
override Instruction getALastInstructionInternal() { none() }
10711071

10721072
override predicate hasInstruction(Opcode opcode, InstructionTag tag, CppType resultType) {
10731073
none()

cpp/ql/lib/semmle/code/cpp/models/implementations/SmartPointer.qll

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,6 @@ private class SmartPtrDestructor extends Destructor, SideEffectFunction, AliasFu
181181
* Gets the destructor associated with the base type of this smart pointer.
182182
*/
183183
private Destructor getBaseTypeDestructor() {
184-
// TODO: Check if this is join ordered correctly.
185184
result.getDeclaringType() = declaringType.getBaseType()
186185
}
187186

@@ -222,4 +221,4 @@ private class SmartPtrDestructor extends Destructor, SideEffectFunction, AliasFu
222221
// A destructor call does not have a return value
223222
none()
224223
}
225-
}
224+
}

0 commit comments

Comments
 (0)