Skip to content

Commit 174712a

Browse files
committed
Delete unused predicate paramsString
This is needed for other languages, but in Go you cannot have two functions which are distinguished only by their parameter types.
1 parent 4012758 commit 174712a

File tree

1 file changed

+0
-20
lines changed

1 file changed

+0
-20
lines changed

go/ql/lib/semmle/go/dataflow/ExternalFlow.qll

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -267,26 +267,6 @@ private predicate elementSpec(
267267
neutralModel(package, type, name, signature, _, _) and ext = "" and subtypes = false
268268
}
269269

270-
private string paramsStringPart(Function f, int i) {
271-
i = -1 and result = "("
272-
or
273-
exists(int n, string p | f.getParameterType(n).toString() = p |
274-
i = 2 * n and result = p
275-
or
276-
i = 2 * n - 1 and result = "," and n != 0
277-
)
278-
or
279-
i = 2 * f.getNumParameter() and result = ")"
280-
}
281-
282-
/**
283-
* Gets a parenthesized string containing all parameter types of this callable, separated by a comma.
284-
*
285-
* Returns the empty string if the callable has no parameters.
286-
* Parameter types are represented by their type erasure.
287-
*/
288-
string paramsString(Function f) { result = concat(int i | | paramsStringPart(f, i) order by i) }
289-
290270
bindingset[p]
291271
private string interpretPackage(string p) {
292272
exists(string r | r = "([^$]+)([./]\\$ANYVERSION(/|$)(.*))?" |

0 commit comments

Comments
 (0)