Merge pull request github#13456 from asgerf/js/vuex-perf

asgerf · web-flow · commit 318a60b20872 · 2023-06-14T19:50:06.000+02:00
JS: Restrict length of state path in vuex model
diff --git a/javascript/ql/lib/semmle/javascript/frameworks/Vuex.qll b/javascript/ql/lib/semmle/javascript/frameworks/Vuex.qll
@@ -289,7 +289,8 @@ module Vuex {
     or
     exists(string base, string prop |
       result = stateRefByAccessPath(base).getMember(prop) and
-      path = appendToNamespace(base, prop)
+      path = appendToNamespace(base, prop) and
+      path.length() < 100
     )
   }
 

Original file line number	Diff line number	Diff line change
`@@ -289,7 +289,8 @@ module Vuex {`
`289`	`289`	`or`
`290`	`290`	`exists(string base, string prop \|`
`291`	`291`	`result = stateRefByAccessPath(base).getMember(prop) and`
`292`		`- path = appendToNamespace(base, prop)`
	`292`	`+ path = appendToNamespace(base, prop) and`
	`293`	`+ path.length() < 100`
`293`	`294`	`)`
`294`	`295`	`}`
`295`	`296`