Merge pull request github#14943 from rafaelurben/patch-1

JS: Add django template urls as "save urls"

Author: erik-krogh

javascript/ql/src/DOM/TargetBlank.ql

@@ -44,7 +44,9 @@ predicate hasDynamicHrefHostAttributeValue(DOM::ElementDefinition elem) {
       // ... that does not start with a fixed host or a relative path (common formats)
       not url.regexpMatch("(?i)((https?:)?//)?[-a-z0-9.]*/.*") and
       // .. that is not a call to `url_for` in a Flask / nunjucks application
-      not url.regexpMatch("\\{\\{\\s*url(_for)?\\(.+\\).*")
+      not url.regexpMatch("\\{\\{\\s*url(_for)?\\(.+\\).*") and
+      // .. that is not a call to `url` in a Django application
+      not url.regexpMatch("\\{%\\s*url.*")
     )
   )
 }

javascript/ql/src/change-notes/2023-11-28-django-urls.md

@@ -0,0 +1,4 @@
+---
+category: minorAnalysis
+---
+* Added django URLs to detected "safe" URL patterns in `js/unsafe-external-link`. 

javascript/ql/test/query-tests/DOM/TargetBlank/tst.js

@@ -65,4 +65,7 @@ function f() {
 <a href="{{ 	url_for('foo.html', 'foo')}}" target="_blank">Example</a>;
 
 // OK, nunjucks template
-<a href="{{ url('foo', query={bla}) }}" target="_blank">Example</a>
+<a href="{{ url('foo', query={bla}) }}" target="_blank">Example</a>;
+
+// OK, Django application with internal links
+<a href="{% url 'admin:auth_user_changelist' %}" target="_blank">Example</a>