Skip to content

Commit 3fb5ad2

Browse files
committed
Cover all params in QLDoc of modelCoverage
1 parent 60970ff commit 3fb5ad2

File tree

4 files changed

+12
-6
lines changed

4 files changed

+12
-6
lines changed

cpp/ql/lib/semmle/code/cpp/dataflow/ExternalFlow.qll

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -203,8 +203,9 @@ private predicate canonicalNamespaceLink(string namespace, string subns) {
203203
}
204204

205205
/**
206-
* Holds if CSV framework coverage of `namespace` is `n` api endpoints of the
207-
* kind `(kind, part)`.
206+
* Holds if MaD framework coverage of `package` is `n` api endpoints of the
207+
* kind `(kind, part)`, and `pkgs` is the number of subpackages of `package`
208+
* which have MaD framework coverage (including `package` itself).
208209
*/
209210
predicate modelCoverage(string namespace, int namespaces, string kind, string part, int n) {
210211
namespaces = strictcount(string subns | canonicalNamespaceLink(namespace, subns)) and

csharp/ql/lib/semmle/code/csharp/dataflow/internal/ExternalFlow.qll

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,9 @@ private predicate canonicalNamespaceLink(string namespace, string subns) {
121121

122122
/**
123123
* Holds if MaD framework coverage of `namespace` is `n` api endpoints of the
124-
* kind `(kind, part)`.
124+
* kind `(kind, part)`, and `namespaces` is the number of subnamespaces of
125+
* `namespace` which have MaD framework coverage (including `namespace`
126+
* itself).
125127
*/
126128
predicate modelCoverage(string namespace, int namespaces, string kind, string part, int n) {
127129
namespaces = strictcount(string subns | canonicalNamespaceLink(namespace, subns)) and

java/ql/lib/semmle/code/java/dataflow/ExternalFlow.qll

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,8 @@ private predicate canonicalPkgLink(string package, string subpkg) {
211211

212212
/**
213213
* Holds if MaD framework coverage of `package` is `n` api endpoints of the
214-
* kind `(kind, part)`.
214+
* kind `(kind, part)`, and `pkgs` is the number of subpackages of `package`
215+
* which have MaD framework coverage (including `package` itself).
215216
*/
216217
predicate modelCoverage(string package, int pkgs, string kind, string part, int n) {
217218
pkgs = strictcount(string subpkg | canonicalPkgLink(package, subpkg)) and

swift/ql/lib/codeql/swift/dataflow/ExternalFlow.qll

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -191,8 +191,10 @@ private predicate canonicalNamespaceLink(string namespace, string subns) {
191191
}
192192

193193
/**
194-
* Holds if CSV framework coverage of `namespace` is `n` api endpoints of the
195-
* kind `(kind, part)`.
194+
* Holds if MaD framework coverage of `namespace` is `n` api endpoints of the
195+
* kind `(kind, part)`, and `namespaces` is the number of subnamespaces of
196+
* `namespace` which have MaD framework coverage (including `namespace`
197+
* itself).
196198
*/
197199
predicate modelCoverage(string namespace, int namespaces, string kind, string part, int n) {
198200
namespaces = strictcount(string subns | canonicalNamespaceLink(namespace, subns)) and

0 commit comments

Comments
 (0)