Use lookahead in regex to not match e.g. "/v2foo"

owen-mc · owen-mc · commit 46d0c6ff9c7e · 2024-06-26T05:01:09.000+01:00
diff --git a/go/ql/lib/semmle/go/Packages.qll b/go/ql/lib/semmle/go/Packages.qll
@@ -33,7 +33,7 @@ class Package extends @package {
   string toString() { result = "package " + this.getPath() }
 }
 
-string majorVersionSuffixRegex() { result = "[./]v\\d+" }
+string majorVersionSuffixRegex() { result = "[./]v\\d+(?=$|/)" }
 
 /**
  * Gets an import path that identifies a package in module `mod` with the given path,

Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ class Package extends @package {`
`33`	`33`	`string toString() { result = "package " + this.getPath() }`
`34`	`34`	`}`
`35`	`35`
`36`		`-string majorVersionSuffixRegex() { result = "[./]v\\d+" }`
	`36`	`+string majorVersionSuffixRegex() { result = "[./]v\\d+(?=$\|/)" }`
`37`	`37`
`38`	`38`	`/**`
`39`	`39`	* Gets an import path that identifies a package in module `mod` with the given path,