Merge pull request github#16633 from hvitved/dataflow/inline-pred

hvitved · web-flow · commit 58ce3e805e13 · 2024-05-31T20:12:14.000+02:00
Data flow: Inline `isUnreachableInCall1`
diff --git a/shared/dataflow/codeql/dataflow/internal/DataFlowImpl.qll b/shared/dataflow/codeql/dataflow/internal/DataFlowImpl.qll
@@ -348,7 +348,8 @@ module MakeImpl<LocationSig Location, InputSig<Location> Lang> {
       not stateBarrier(node2, state2)
     }
 
-    pragma[nomagic]
+    bindingset[n, cc]
+    pragma[inline_late]
     private predicate isUnreachableInCall1(NodeEx n, LocalCallContextSpecificCall cc) {
       cc.unreachable(n.asNode())
     }

Original file line number	Diff line number	Diff line change
`@@ -348,7 +348,8 @@ module MakeImpl<LocationSig Location, InputSig<Location> Lang> {`
`348`	`348`	`not stateBarrier(node2, state2)`
`349`	`349`	`}`
`350`	`350`
`351`		`- pragma[nomagic]`
	`351`	`+ bindingset[n, cc]`
	`352`	`+ pragma[inline_late]`
`352`	`353`	`private predicate isUnreachableInCall1(NodeEx n, LocalCallContextSpecificCall cc) {`
`353`	`354`	`cc.unreachable(n.asNode())`
`354`	`355`	`}`